GNU bug report logs - #52721
[PATCH] gnu: python-pydata-sphinx-theme: Fix build.

Previous Next

Package: guix-patches;

Reported by: Aleksandr Vityazev <avityazev <at> posteo.org>

Date: Tue, 21 Dec 2021 22:35:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52721 in the body.
You can then email your comments to 52721 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#52721; Package guix-patches. (Tue, 21 Dec 2021 22:35:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Aleksandr Vityazev <avityazev <at> posteo.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 21 Dec 2021 22:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-pydata-sphinx-theme: Fix build.
Date: Tue, 21 Dec 2021 22:34:14 +0000
Hi,

the build fails because a package is required python-docutils < 0.17.


--8<---------------cut here---------------start------------->8---
ERROR: Could not find a version that satisfies the requirement docutils<0.17 (from versions: none)
ERROR: No matching distribution found for docutils<0.17
error: Command '['/gnu/store/3282r97il61j9jkv2aaifa3nwdylzfsv-python-wrapper-3.9.6/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/guix-build-python-pydata-sphinx-theme-0.6.3.drv-0/tmpqhg_sgru', '--quiet', 'docutils<0.17']' returned non-zero exit status 1.
--8<---------------cut here---------------end--------------->8---



* gnu/packages/sphinx (python-pydata-sphinx-theme):
[native-inputs]: Replace python-docutils with python-docutils-0.15.
---
 gnu/packages/sphinx.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/sphinx.scm b/gnu/packages/sphinx.scm
index 3ac5b5e22c..957c4dc9c4 100644
--- a/gnu/packages/sphinx.scm
+++ b/gnu/packages/sphinx.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2021 Hugo Lecomte <hugo.lecomte <at> inria.fr>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2021 Aleksandr Vityazev <avityazev <at> posteo.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -919,7 +920,7 @@ (define-public python-pydata-sphinx-theme
      (list python-beautifulsoup4))
     (native-inputs
      (list python-beautifulsoup4
-           python-docutils
+           python-docutils-0.15
            python-jupyter-sphinx
            python-numpy
            python-numpydoc
-- 
2.34.0



-- 

Aleksandr Vityazev




Information forwarded to guix-patches <at> gnu.org:
bug#52721; Package guix-patches. (Wed, 22 Dec 2021 10:55:01 GMT) Full text and rfc822 format available.

Message #8 received at 52721 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 52721 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-pydata-sphinx-theme: Fix build.
Date: Wed, 22 Dec 2021 10:53:57 +0000
Hi,

> the build fails because a package is required python-docutils < 0.17.

Is python-docutils<0.17 truly required, or are the version requirements
in the source code overly strict? If it's the latter, you could patch
the source code to relax the requirements.

The latter happens often, because library developers often don't know
in advance whether the library is compatible with future versions of
the dependencies.

Greetings,
Maxime.





Information forwarded to guix-patches <at> gnu.org:
bug#52721; Package guix-patches. (Wed, 22 Dec 2021 18:18:01 GMT) Full text and rfc822 format available.

Message #11 received at 52721 <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 52721 <at> debbugs.gnu.org
Subject: [PATCH]v2 gnu: python-pydata-sphinx-theme: Fix build.
Date: Wed, 22 Dec 2021 18:17:57 +0000
[Message part 1 (text/plain, inline)]
Hi,
On 2021-12-22, 10:53 +0000, Maxime Devos <maximedevos <at> telenet.be> wrote:

>> the build fails because a package is required python-docutils < 0.17.
>
> Is python-docutils<0.17 truly required, or are the version requirements
> in the source code overly strict? If it's the latter, you could patch
> the source code to relax the requirements.
>
> The latter happens often, because library developers often don't know
> in advance whether the library is compatible with future versions of
> the dependencies.

For version 0.6.3 there is a file
pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
contains:

docutils==0.16 # temporary pin (0.17 broken captions).

Also, the master version requires "docutils!=0.17.0.

So I created a patch that adds an extra phase.

[0001-gnu-python-pydata-sphinx-theme-Fix-build.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
-- 
Best regards,
Aleksandr Vityazev

Information forwarded to guix-patches <at> gnu.org:
bug#52721; Package guix-patches. (Wed, 22 Dec 2021 18:27:01 GMT) Full text and rfc822 format available.

Message #14 received at 52721 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 52721 <at> debbugs.gnu.org
Subject: Re: [PATCH]v2 gnu: python-pydata-sphinx-theme: Fix build.
Date: Wed, 22 Dec 2021 18:25:55 +0000
Aleksandr Vityazev schreef op wo 22-12-2021 om 18:17 [+0000]:
> 
> > > the build fails because a package is required python-docutils <
> > > 0.17.
> > 
> > Is python-docutils<0.17 truly required, or are the version
> > requirements
> > in the source code overly strict? If it's the latter, you could
> > patch
> > the source code to relax the requirements.
> > 
> > The latter happens often, because library developers often don't
> > know
> > in advance whether the library is compatible with future versions
> > of
> > the dependencies.
> 
> For version 0.6.3 there is a file
> pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
> contains:
> 
> docutils==0.16 # temporary pin (0.17 broken captions).
> 
> Also, the master version requires "docutils!=0.17.0.
> 
> So I created a patch that adds an extra phase.

In that case, docutil<0.17 appears to be actually required, so the
solution would be to use docutils=0.15 as you did originally, I think?
Preferably with a comment ; captions are broken in 0.17..

Greetings,
Maxime.





Information forwarded to guix-patches <at> gnu.org:
bug#52721; Package guix-patches. (Thu, 23 Dec 2021 22:55:01 GMT) Full text and rfc822 format available.

Message #17 received at 52721 <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 52721 <at> debbugs.gnu.org
Subject: Re: bug#52721: [PATCH] gnu: python-pydata-sphinx-theme: Fix build.
Date: Thu, 23 Dec 2021 22:54:27 +0000
Hi,

On 2021-12-22, 18:25 +0000, Maxime Devos <maximedevos <at> telenet.be> wrote:

>> For version 0.6.3 there is a file
>> pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
>> contains:
>> 
>> docutils==0.16 # temporary pin (0.17 broken captions).
>> 
>> Also, the master version requires "docutils!=0.17.0.
>> 
>> So I created a patch that adds an extra phase.
>
> In that case, docutil<0.17 appears to be actually required, so the
> solution would be to use docutils=0.15 as you did originally, I think?
> Preferably with a comment ; captions are broken in 0.17..
>

These were pushed by Efraim Flashner with
8efa775653f78dad8b254e719677e663be8f3240.

-- 
Best regards,
Aleksandr Vityazev




Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Sat, 25 Dec 2021 20:04:02 GMT) Full text and rfc822 format available.

Notification sent to Aleksandr Vityazev <avityazev <at> posteo.org>:
bug acknowledged by developer. (Sat, 25 Dec 2021 20:04:02 GMT) Full text and rfc822 format available.

Message #22 received at 52721-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 52721-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: [bug#52721] [PATCH] gnu: python-pydata-sphinx-theme: Fix build.
Date: Sat, 25 Dec 2021 22:02:37 +0200
[Message part 1 (text/plain, inline)]
On Thu, Dec 23, 2021 at 10:54:27PM +0000, Aleksandr Vityazev wrote:
> Hi,
> 
> On 2021-12-22, 18:25 +0000, Maxime Devos <maximedevos <at> telenet.be> wrote:
> 
> >> For version 0.6.3 there is a file
> >> pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
> >> contains:
> >> 
> >> docutils==0.16 # temporary pin (0.17 broken captions).
> >> 
> >> Also, the master version requires "docutils!=0.17.0.
> >> 
> >> So I created a patch that adds an extra phase.
> >
> > In that case, docutil<0.17 appears to be actually required, so the
> > solution would be to use docutils=0.15 as you did originally, I think?
> > Preferably with a comment ; captions are broken in 0.17..
> >
> 
> These were pushed by Efraim Flashner with
> 8efa775653f78dad8b254e719677e663be8f3240.
> 

Sorry, I didn't check for patches before working on this patch.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 23 Jan 2022 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 65 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.