GNU bug report logs - #52729
[PATCH] gnu: ocaml: Update to 4.13.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52729 in the body.
You can then email your comments to 52729 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ocaml: Update to 4.13.
Date: Wed, 22 Dec 2021 04:16:09 +0100

[Message part 1 (text/plain, inline)]

Hi Guix!

This patch updates ocaml to the latest version, without the need to
keep the previous version around like previous updates :)

[0001-gnu-ocaml-Update-to-4.13.patch (text/x-patch, attachment)]

Message #8 received at 52729 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 52729 <at> debbugs.gnu.org
Subject: Re: bug#52729: [PATCH] gnu: ocaml: Update to 4.13.
Date: Wed, 22 Dec 2021 14:33:55 +0100

Hi Julien,

On mer., 22 déc. 2021 at 04:16, Julien Lepiller <julien <at> lepiller.eu> wrote:

> This patch updates ocaml to the latest version, without the need to
> keep the previous version around like previous updates :)

Cool!

I have not looked into all the details, from the surface, LGTM.

However, I note that:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build ocaml-ppx-tools-versioned
[...]
starting phase `build'
       ocaml src/ast-version,src/compiler-functions-file (exit 1)
(cd _build/default/src && /gnu/store/xp09a2invgrnah62sf9carz9bkld1w6f-ocaml-4.13.1/bin/ocaml config/gen.ml 4.13.1)
Unkown OCaml version 4.13.1
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "dune" arguments: ("build" "@install" "--release") exit-status: 1 term-signal: #f stop-signal: #f>
phase `build' failed after 0.9 seconds
command "dune" "build" "@install" "--release" failed with status 1
builder for `/gnu/store/vbmvzq7if77zsl29945pyw7s2jbsmg7s-ocaml-migrate-parsetree-1-1.8.0.drv' failed with exit code 1
build of /gnu/store/vbmvzq7if77zsl29945pyw7s2jbsmg7s-ocaml-migrate-parsetree-1-1.8.0.drv failed
View build log at '/var/log/guix/drvs/vb/mvzq7if77zsl29945pyw7s2jbsmg7s-ocaml-migrate-parsetree-1-1.8.0.drv.bz2'.
cannot build derivation `/gnu/store/l3575b4ici05g7b8d9dc55wbbddmblwp-ocaml-ppx-tools-versioned-5.4.0.drv': 1 dependencies couldn't be built
guix build: error: build of `/gnu/store/l3575b4ici05g7b8d9dc55wbbddmblwp-ocaml-ppx-tools-versioned-5.4.0.drv' failed
--8<---------------cut here---------------end--------------->8---


On a side note, have you tried to replace boot/ocamlc (and friends) with
the bootstrapped ones (camlboot -> ocaml-4.07 -> *).  Other said, what
is the most affordable path to exploit camlboot and have a good
bootstrapping story for OCaml.


Cheers,
simon

Message #11 received at 52729 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 52729 <at> debbugs.gnu.org
Subject: Re: bug#52729: [PATCH] gnu: ocaml: Update to 4.13.
Date: Wed, 22 Dec 2021 08:43:00 -0500

Le 22 décembre 2021 08:33:55 GMT-05:00, zimoun <zimon.toutoune <at> gmail.com> a écrit :
>Hi Julien,
>
>On mer., 22 déc. 2021 at 04:16, Julien Lepiller <julien <at> lepiller.eu> wrote:
>
>> This patch updates ocaml to the latest version, without the need to
>> keep the previous version around like previous updates :)
>
>Cool!
>
>I have not looked into all the details, from the surface, LGTM.
>
>However, I note that:
>
>--8<---------------cut here---------------start------------->8---
>$ ./pre-inst-env guix build ocaml-ppx-tools-versioned
>[...]
>starting phase `build'
>       ocaml src/ast-version,src/compiler-functions-file (exit 1)
>(cd _build/default/src && /gnu/store/xp09a2invgrnah62sf9carz9bkld1w6f-ocaml-4.13.1/bin/ocaml config/gen.ml 4.13.1)
>Unkown OCaml version 4.13.1
>error: in phase 'build': uncaught exception:
>%exception #<&invoke-error program: "dune" arguments: ("build" "@install" "--release") exit-status: 1 term-signal: #f stop-signal: #f>
>phase `build' failed after 0.9 seconds
>command "dune" "build" "@install" "--release" failed with status 1
>builder for `/gnu/store/vbmvzq7if77zsl29945pyw7s2jbsmg7s-ocaml-migrate-parsetree-1-1.8.0.drv' failed with exit code 1
>build of /gnu/store/vbmvzq7if77zsl29945pyw7s2jbsmg7s-ocaml-migrate-parsetree-1-1.8.0.drv failed
>View build log at '/var/log/guix/drvs/vb/mvzq7if77zsl29945pyw7s2jbsmg7s-ocaml-migrate-parsetree-1-1.8.0.drv.bz2'.
>cannot build derivation `/gnu/store/l3575b4ici05g7b8d9dc55wbbddmblwp-ocaml-ppx-tools-versioned-5.4.0.drv': 1 dependencies couldn't be built
>guix build: error: build of `/gnu/store/l3575b4ici05g7b8d9dc55wbbddmblwp-ocaml-ppx-tools-versioned-5.4.0.drv' failed
>--8<---------------cut here---------------end--------------->8---
>

Thanks! I forgot that one. ppx-tools-versionned is not compatible, and it's only used by migrate-parstree-1, which has no dependents. I only need it for ocaml 4.07, so I'll remove them both, and keep only the ocaml4.07 variant.

>
>On a side note, have you tried to replace boot/ocamlc (and friends) with
>the bootstrapped ones (camlboot -> ocaml-4.07 -> *).  Other said, what
>is the most affordable path to exploit camlboot and have a good
>bootstrapping story for OCaml.

Currently we can only use camlboot to bootstrap ocaml 4.07, which is what we do. We plan to improve it so it can build newer versions though.

>
>
>Cheers,
>simon

Message #14 received at 52729 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 52729 <at> debbugs.gnu.org
Subject: Re: bug#52729: [PATCH] gnu: ocaml: Update to 4.13.
Date: Wed, 22 Dec 2021 14:51:49 +0100

Hi,

On Wed, 22 Dec 2021 at 14:43, Julien Lepiller <julien <at> lepiller.eu> wrote:

> >On a side note, have you tried to replace boot/ocamlc (and friends) with
> >the bootstrapped ones (camlboot -> ocaml-4.07 -> *).  Other said, what
> >is the most affordable path to exploit camlboot and have a good
> >bootstrapping story for OCaml.
>
> Currently we can only use camlboot to bootstrap ocaml 4.07, which is what we do. We plan to improve it so it can build newer versions though.

Yes, I remember when discussing the patch adding camlboot and
ocaml4.07-boot. :-)  That's what you explained [1].

Well, a direct bootstrap camlboot -> ocaml-4.13 is better for sure,
but harder.  Instead, my question is: have you tried a chain of
boostrap: camlboot -> ocaml-4.07 -> ? -> ocaml-4.13.  I could be
temporary solution waiting camlboot improvements, no?

1: <https://issues.guix.gnu.org/46806#11>


Cheers,
simon

Message #17 received at 52729 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 52729 <at> debbugs.gnu.org
Subject: Re: bug#52729: [PATCH v2] gnu: ocaml: Update to 4.13.
Date: Thu, 23 Dec 2021 14:01:09 +0100

[Message part 1 (text/plain, inline)]

Le Wed, 22 Dec 2021 14:51:49 +0100,
zimoun <zimon.toutoune <at> gmail.com> a écrit :

> Hi,
> 
> On Wed, 22 Dec 2021 at 14:43, Julien Lepiller <julien <at> lepiller.eu>
> wrote:
> 
> > >On a side note, have you tried to replace boot/ocamlc (and
> > >friends) with the bootstrapped ones (camlboot -> ocaml-4.07 -> *).
> > > Other said, what is the most affordable path to exploit camlboot
> > > and have a good
> > >bootstrapping story for OCaml.  
> >
> > Currently we can only use camlboot to bootstrap ocaml 4.07, which
> > is what we do. We plan to improve it so it can build newer versions
> > though.  
> 
> Yes, I remember when discussing the patch adding camlboot and
> ocaml4.07-boot. :-)  That's what you explained [1].
> 
> Well, a direct bootstrap camlboot -> ocaml-4.13 is better for sure,
> but harder.  Instead, my question is: have you tried a chain of
> boostrap: camlboot -> ocaml-4.07 -> ? -> ocaml-4.13.  I could be
> temporary solution waiting camlboot improvements, no?
> 
> 1: <https://issues.guix.gnu.org/46806#11>
> 
> 
> Cheers,
> simon

Here's v2 of the patch series: the first two patches build only the
4.07 version for migrate-parsetree <at> 1 and for ppx-tools-versioned. That
way, they don't fail when updating to ocaml 4.13. I checked that
everything builds like before. I still have issues with bap because
llvm <at> 3.8.1 fails.

[0001-gnu-ocaml-ppx-tools-versioned-Only-build-ocaml-4.07-.patch (text/x-patch, attachment)]

[0002-gnu-ocaml-migrate-parstree-1-Only-build-ocaml4.07-va.patch (text/x-patch, attachment)]

[0003-gnu-ocaml-Update-to-4.13.patch (text/x-patch, attachment)]

Message #20 received at 52729 <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 52729 <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#52729] [PATCH v2] gnu: ocaml: Update to 4.13.
Date: Sat, 08 Jan 2022 20:45:45 +0000

Hi Julien,

> gnu: ocaml-ppx-tools-versioned: Only build ocaml-4.07 variant.

Any reason for not using the package-with-ocaml4.07 transformation?

> gnu: ocaml: Update to 4.13.

js-of-ocaml and ocaml-dot-merlin-reader are also updated in this
commit. Could they be split to separate commits?

Other than that everything seems to be compiling and working
fine. Thank you very much!

-pukkamustard


Julien Lepiller <julien <at> lepiller.eu> writes:

> Le Wed, 22 Dec 2021 14:51:49 +0100,
> zimoun <zimon.toutoune <at> gmail.com> a écrit :
>
>> Hi,
>> 
>> On Wed, 22 Dec 2021 at 14:43, Julien Lepiller <julien <at> lepiller.eu>
>> wrote:
>> 
>> > >On a side note, have you tried to replace boot/ocamlc (and
>> > >friends) with the bootstrapped ones (camlboot -> ocaml-4.07 -> *).
>> > > Other said, what is the most affordable path to exploit camlboot
>> > > and have a good
>> > >bootstrapping story for OCaml.  
>> >
>> > Currently we can only use camlboot to bootstrap ocaml 4.07, which
>> > is what we do. We plan to improve it so it can build newer versions
>> > though.  
>> 
>> Yes, I remember when discussing the patch adding camlboot and
>> ocaml4.07-boot. :-)  That's what you explained [1].
>> 
>> Well, a direct bootstrap camlboot -> ocaml-4.13 is better for sure,
>> but harder.  Instead, my question is: have you tried a chain of
>> boostrap: camlboot -> ocaml-4.07 -> ? -> ocaml-4.13.  I could be
>> temporary solution waiting camlboot improvements, no?
>> 
>> 1: <https://issues.guix.gnu.org/46806#11>
>> 
>> 
>> Cheers,
>> simon
>
> Here's v2 of the patch series: the first two patches build only the
> 4.07 version for migrate-parsetree <at> 1 and for ppx-tools-versioned. That
> way, they don't fail when updating to ocaml 4.13. I checked that
> everything builds like before. I still have issues with bap because
> llvm <at> 3.8.1 fails.
>
> [2. text/x-patch; 0001-gnu-ocaml-ppx-tools-versioned-Only-build-ocaml-4.07-.patch]...
>
> [3. text/x-patch; 0002-gnu-ocaml-migrate-parstree-1-Only-build-ocaml4.07-va.patch]...
>
> [4. text/x-patch; 0003-gnu-ocaml-Update-to-4.13.patch]...

Message #25 received at 52729-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 52729-done <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#52729] [PATCH v2] gnu: ocaml: Update to 4.13.
Date: Sun, 9 Jan 2022 10:55:13 +0100

Le Sat, 08 Jan 2022 20:45:45 +0000,
pukkamustard <pukkamustard <at> posteo.net> a écrit :

> Hi Julien,
> 
> > gnu: ocaml-ppx-tools-versioned: Only build ocaml-4.07 variant.  
> 
> Any reason for not using the package-with-ocaml4.07 transformation?

No reason at all, thanks for noticing.

> 
> > gnu: ocaml: Update to 4.13.  
> 
> js-of-ocaml and ocaml-dot-merlin-reader are also updated in this
> commit. Could they be split to separate commits?

Unfortunately I cannot update these packages independently without
something breaking.

> 
> Other than that everything seems to be compiling and working
> fine. Thank you very much!
> 

Thanks for the review, pushed to master as
92c63bc491a4f3098e94e7e58ec83b89f771c13c to
3e8e6ebf000b1cbc4ff4b9ba84c7abdcbdf0ffb4

> -pukkamustard
> 
> 
> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > Le Wed, 22 Dec 2021 14:51:49 +0100,
> > zimoun <zimon.toutoune <at> gmail.com> a écrit :
> >  
> >> Hi,
> >> 
> >> On Wed, 22 Dec 2021 at 14:43, Julien Lepiller <julien <at> lepiller.eu>
> >> wrote:
> >>   
> >> > >On a side note, have you tried to replace boot/ocamlc (and
> >> > >friends) with the bootstrapped ones (camlboot -> ocaml-4.07 ->
> >> > >*).
> >> > > Other said, what is the most affordable path to exploit
> >> > > camlboot and have a good
> >> > >bootstrapping story for OCaml.    
> >> >
> >> > Currently we can only use camlboot to bootstrap ocaml 4.07, which
> >> > is what we do. We plan to improve it so it can build newer
> >> > versions though.    
> >> 
> >> Yes, I remember when discussing the patch adding camlboot and
> >> ocaml4.07-boot. :-)  That's what you explained [1].
> >> 
> >> Well, a direct bootstrap camlboot -> ocaml-4.13 is better for sure,
> >> but harder.  Instead, my question is: have you tried a chain of
> >> boostrap: camlboot -> ocaml-4.07 -> ? -> ocaml-4.13.  I could be
> >> temporary solution waiting camlboot improvements, no?
> >> 
> >> 1: <https://issues.guix.gnu.org/46806#11>
> >> 
> >> 
> >> Cheers,
> >> simon  
> >
> > Here's v2 of the patch series: the first two patches build only the
> > 4.07 version for migrate-parsetree <at> 1 and for ppx-tools-versioned.
> > That way, they don't fail when updating to ocaml 4.13. I checked
> > that everything builds like before. I still have issues with bap
> > because llvm <at> 3.8.1 fails.
> >
> > [2. text/x-patch;
> > 0001-gnu-ocaml-ppx-tools-versioned-Only-build-ocaml-4.07-.patch]...
> >
> > [3. text/x-patch;
> > 0002-gnu-ocaml-migrate-parstree-1-Only-build-ocaml4.07-va.patch]...
> >
> > [4. text/x-patch; 0003-gnu-ocaml-Update-to-4.13.patch]...  
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.