GNU bug report logs - #52738
[PATCH] gnu: Add poweralertd

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52738 in the body.
You can then email your comments to 52738 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH] gnu: Add poweralertd
Date: Wed, 22 Dec 2021 18:51:35 +0100

* gnu/packages/freedesktop.scm (poweralertd): Add variable.
---
 gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index dcd1870e41..896f8e2847 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2429,6 +2429,33 @@ (define-public xdg-desktop-portal-wlr
 compositors.")
     (license license:expat)))
 
+(define-public poweralertd
+  (package
+    (name "poweralertd")
+    (version "0.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.sr.ht/~kennylevinsen/poweralertd")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "19rw9q4pcqw56nmzjfglfikzx5wwjl4n08awwdhg0jy1k0bm3dvp"))))
+    (build-system meson-build-system)
+    (arguments
+     '(#:configure-flags '("-Dman-pages=enabled")))
+    (native-inputs
+     (list scdoc pkg-config bash-minimal))
+    (inputs
+     (list elogind))
+    (home-page "https://git.sr.ht/~kennylevinsen/poweralertd")
+    (synopsis "Power alert daemon")
+    (description "poweralertd is a daemon that watches for UPower events and
+notifies the user using any notification daemon implementing
+@code{org.freedesktop.Notifications}.")
+    (license license:gpl3)))
+
 (define-public waypipe
   (package
     (name "waypipe")
-- 
2.34.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Josselin Poiret via Guix-patches via <guix-patches <at> gnu.org>,
 52738 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: Re: [bug#52738] [PATCH] gnu: Add poweralertd
Date: Thu, 23 Dec 2021 12:11:47 +0100

[Message part 1 (text/plain, inline)]

Hi,

Josselin Poiret schrieb am Mittwoch der 22. Dezember 2021 um 18:51 +01:

> * gnu/packages/freedesktop.scm (poweralertd): Add variable.
> ---
>  gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index dcd1870e41..896f8e2847 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -2429,6 +2429,33 @@ (define-public xdg-desktop-portal-wlr
>  compositors.")
>      (license license:expat)))
>  
> +(define-public poweralertd
> +  (package
> +    (name "poweralertd")
> +    (version "0.2.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.sr.ht/~kennylevinsen/poweralertd")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "19rw9q4pcqw56nmzjfglfikzx5wwjl4n08awwdhg0jy1k0bm3dvp"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     '(#:configure-flags '("-Dman-pages=enabled")))
> +    (native-inputs
> +     (list scdoc pkg-config bash-minimal))
> +    (inputs
> +     (list elogind))
> +    (home-page "https://git.sr.ht/~kennylevinsen/poweralertd")

Nitpick: <https://sr.ht/~kennylevinsen/poweralertd> seems more
appropriate since it also contains links to the ML and bug tracker.

> +    (synopsis "Power alert daemon")
> +    (description "poweralertd is a daemon that watches for UPower events and
> +notifies the user using any notification daemon implementing
> +@code{org.freedesktop.Notifications}.")
> +    (license license:gpl3)))

The LICENSE file doesn’t mention “only v3”, so it should probably be
‘gpl3+’.

Otherwise, LGTM!

--8<---------------cut here---------------start------------->8---
Result of running `guix review 20211222175135.8490-1-dev <at> jpoiret.xyz -D': (still a WIP)

  Successfully built 1 out of 1 package(s).

  No lint warnings were emitted
--8<---------------cut here---------------end--------------->8---

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 52738 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Xinglu Chen <public <at> yoctocell.xyz>,
	52738 <at> debbugs.gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH v2] gnu: Add poweralertd
Date: Sat, 25 Dec 2021 12:30:57 +0100

* gnu/packages/freedesktop.scm (poweralertd): Add variable.
---
Hello,

Here is a modified patch with those changes.

Thanks for the review!

Best,
Josselin

 gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index dcd1870e41..e8e1cb9ca4 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2429,6 +2429,33 @@ (define-public xdg-desktop-portal-wlr
 compositors.")
     (license license:expat)))
 
+(define-public poweralertd
+  (package
+    (name "poweralertd")
+    (version "0.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.sr.ht/~kennylevinsen/poweralertd")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "19rw9q4pcqw56nmzjfglfikzx5wwjl4n08awwdhg0jy1k0bm3dvp"))))
+    (build-system meson-build-system)
+    (arguments
+     '(#:configure-flags '("-Dman-pages=enabled")))
+    (native-inputs
+     (list scdoc pkg-config bash-minimal))
+    (inputs
+     (list elogind))
+    (home-page "https://sr.ht/~kennylevinsen/poweralertd")
+    (synopsis "Power alert daemon")
+    (description "poweralertd is a daemon that watches for UPower events and
+notifies the user using any notification daemon implementing
+@code{org.freedesktop.Notifications}.")
+    (license license:gpl3+)))
+
 (define-public waypipe
   (package
     (name "waypipe")
-- 
2.34.0

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Josselin Poiret via Guix-patches via <guix-patches <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Xinglu Chen <public <at> yoctocell.xyz>,
 52738-done <at> debbugs.gnu.org
Subject: Re: [bug#52738] [PATCH v2] gnu: Add poweralertd
Date: Mon, 17 Jan 2022 00:23:12 +0100

Hello,

Josselin Poiret via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/freedesktop.scm (poweralertd): Add variable.

Applied. Thank you and thanks to Xinglu Chen for the review.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.