GNU bug report logs - #52777
29.0.50; [PATCH] Update modus-themes to version 2.0.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52777 in the body.
You can then email your comments to 52777 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Update modus-themes to version 2.0.0
Date: Fri, 24 Dec 2021 15:57:06 +0200

[Message part 1 (text/plain, inline)]

Dear maintainers,

I have prepared a patch for the latest version of the modus-themes.
Please find it attached.

The change log entry for version 2.0.0 is available here:
<https://protesilaos.com/codelog/2021-12-24-modus-themes-2-0-0/>.

All the best,
Protesilaos

-- 
Protesilaos Stavrou
https://protesilaos.com

[0001-Update-modus-themes-to-version-2.0.0.patch (text/x-patch, attachment)]

Message #8 received at 52777 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 52777 <at> debbugs.gnu.org
Subject: Re: bug#52777: 29.0.50; [PATCH] Update modus-themes to version 2.0.0
Date: Fri, 24 Dec 2021 15:18:26 -0800

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> I have prepared a patch for the latest version of the modus-themes.
> Please find it attached.

Thanks!  One minor comment below, other than that LGTM after skimming
the patch.

> --- a/etc/themes/modus-operandi-theme.el
> +++ b/etc/themes/modus-operandi-theme.el
> @@ -4,24 +4,24 @@ ;;; modus-operandi-theme.el --- Accessible light theme (WCAG AAA) -*- lexical-bi
>
>  ;; Author: Protesilaos Stavrou <info <at> protesilaos.com>
>  ;; URL: https://gitlab.com/protesilaos/modus-themes
> -;; Version: 1.7.0
> +;; Version: 2.0.0
>  ;; Package-Requires: ((emacs "27.1"))
>  ;; Keywords: faces, theme, accessibility
>
>  ;; This file is part of GNU Emacs.
>
> -;; GNU Emacs is free software: you can redistribute it and/or modify
> +;; This program is free software; you can redistribute it and/or modify
>  ;; it under the terms of the GNU General Public License as published by
> -;; the Free Software Foundation, either version 3 of the License, or
> -;; (at your option) any later version.
> +;; the Free Software Foundation, either version 3 of the License, or (at
> +;; your option) any later version.
>  ;;
> -;; GNU Emacs is distributed in the hope that it will be useful,
> -;; but WITHOUT ANY WARRANTY; without even the implied warranty of
> -;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -;; GNU General Public License for more details.
> +;; This program is distributed in the hope that it will be useful, but
> +;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +;; General Public License for more details.
>  ;;
>  ;; You should have received a copy of the GNU General Public License
> -;; along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.
> +;; along with this program.  If not, see <https://www.gnu.org/licenses/>.

I recently fixed the copyright header, you might want to keep that
change in this file and others.

Message #13 received at 52777 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52777 <at> debbugs.gnu.org
Subject: Re: bug#52777: 29.0.50; [PATCH] Update modus-themes to version 2.0.0
Date: Sat, 25 Dec 2021 08:07:43 +0200

[Message part 1 (text/plain, inline)]

On 2021-12-24, 15:18 -0800, Stefan Kangas <stefan <at> marxist.se> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> I have prepared a patch for the latest version of the modus-themes.
>> Please find it attached.
>
> Thanks!  One minor comment below, other than that LGTM after skimming
> the patch.

Thank you for the review!

>> --- a/etc/themes/modus-operandi-theme.el
>> +++ b/etc/themes/modus-operandi-theme.el
>> @@ -4,24 +4,24 @@ ;;; modus-operandi-theme.el --- Accessible light theme (WCAG AAA) -*- lexical-bi
>>
>>  ;; Author: Protesilaos Stavrou <info <at> protesilaos.com>
>>  ;; URL: https://gitlab.com/protesilaos/modus-themes
>> -;; Version: 1.7.0
>> +;; Version: 2.0.0
>>  ;; Package-Requires: ((emacs "27.1"))
>>  ;; Keywords: faces, theme, accessibility
>>
>>  ;; This file is part of GNU Emacs.
>>
>> -;; GNU Emacs is free software: you can redistribute it and/or modify
>> +;; This program is free software; you can redistribute it and/or modify
>>  ;; it under the terms of the GNU General Public License as published by
>> -;; the Free Software Foundation, either version 3 of the License, or
>> -;; (at your option) any later version.
>> +;; the Free Software Foundation, either version 3 of the License, or (at
>> +;; your option) any later version.
>>  ;;
>> -;; GNU Emacs is distributed in the hope that it will be useful,
>> -;; but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> -;; GNU General Public License for more details.
>> +;; This program is distributed in the hope that it will be useful, but
>> +;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +;; General Public License for more details.
>>  ;;
>>  ;; You should have received a copy of the GNU General Public License
>> -;; along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.
>> +;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
>
> I recently fixed the copyright header, you might want to keep that
> change in this file and others.

I updated the patch (attached).  I can push it from here, if you want.

-- 
Protesilaos Stavrou
https://protesilaos.com

[0001-Update-modus-themes-to-version-2.0.0.patch (text/x-patch, attachment)]

Message #16 received at 52777 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 52777 <at> debbugs.gnu.org
Subject: Re: bug#52777: 29.0.50; [PATCH] Update modus-themes to version 2.0.0
Date: Sat, 25 Dec 2021 08:20:48 -0800

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> I updated the patch (attached).  I can push it from here, if you want.

Yup, please go ahead.

Message #21 received at 52777-done <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52777-done <at> debbugs.gnu.org
Subject: Re: bug#52777: 29.0.50; [PATCH] Update modus-themes to version 2.0.0
Date: Sat, 25 Dec 2021 18:49:20 +0200

On 2021-12-25, 08:20 -0800, Stefan Kangas <stefan <at> marxist.se> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> I updated the patch (attached).  I can push it from here, if you want.
>
> Yup, please go ahead.

Done.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.