GNU bug report logs - #52806
[PATCH] gnu: Add xinitrc-xsession.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52806 in the body.
You can then email your comments to 52806 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add xinitrc-xsession.
Date: Sun, 26 Dec 2021 16:46:44 +0000

[Message part 1 (text/plain, inline)]

Hi Guix,

This is a simple package from Arch's AUR that provides an xsession for using a user's ~/.xinitrc. I've been using this for a while to launch a bare WM (XMonad recently, but others in the past) from GDM and SDDM. There's no formal homepage and the git url will show as 404 in guix lint (I think because there is only git access). I added a description as well.

Thanks!

John

[0001-gnu-Add-xinitrc-xsession.patch (text/x-patch, attachment)]

Message #8 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: [PATCH v2] gnu: Add xinitrc-xsession.
Date: Mon, 27 Dec 2021 05:13:17 +0000

[Message part 1 (text/plain, inline)]

I forgot to note in the description that ~/.xinitrc needs to be executable for this xsession to run. Attached is the revised patch.

Thanks!
John

[0001-gnu-Add-xinitrc-xsession.patch (text/x-patch, attachment)]

Message #11 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: [PATCH v3] gnu: Add xinitrc-xsession.
Date: Mon, 27 Dec 2021 15:19:06 +0000

[Message part 1 (text/plain, inline)]

Adjusted indentation and description per suggestions on another package (#52803). Did not see guix lint pick up that the description did not start with the package name, will have to investigate.

Thanks!
John

[0001-gnu-Add-xinitrc-xsession.patch (text/x-patch, attachment)]

Message #14 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: [PATCH v4] gnu: Add xinitrc-xsession.
Date: Tue, 11 Jan 2022 21:29:11 +0000

[Message part 1 (text/plain, inline)]

Updated this package after feedback via IRC, updated to use git-version and gexp.

[0001-gnu-Add-xinitrc-xsession.patch (text/x-patch, attachment)]

Message #17 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: John Kehayias <john.kehayias <at> protonmail.com>, "52806 <at> debbugs.gnu.org"
 <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v4] gnu: Add xinitrc-xsession.
Date: Tue, 11 Jan 2022 23:24:26 +0100

[Message part 1 (text/plain, inline)]

John Kehayias via Guix-patches via schreef op di 11-01-2022 om 21:29 [+0000]:
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (let* ((xinitrc-desktop
> +                        (string-append #$output
"/share/xsessions/xinitrc.desktop"))
> +                       (xinitrc-helper
> +                        (string-append #$output
"/bin/xinitrcsession-helper")))
> +                  (substitute* xinitrc-desktop
> +                    (("Exec=xinitrcsession-helper")
> +                     (string-append "Exec=" xinitrc-helper)))))))

'outputs' is unused here, so you can simplify the lambda from
(lambda * (#:key outputs #:allow-other-keys) ...)
to
(lambda _ ...).

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Tue, 11 Jan 2022 22:34:16 +0000

[Message part 1 (text/plain, inline)]

Hi Maxime,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:

> 'outputs' is unused here, so you can simplify the lambda from
> (lambda * (#:key outputs #:allow-other-keys) ...)
> to
> (lambda _ ...).
>

Right, another thing that can be removed here with the gexp. Thanks!

John

[0001-gnu-Add-xinitrc-xsession.patch (text/x-patch, attachment)]

Message #23 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Thu, 27 Jan 2022 03:33:21 +0000

Hi Maxime,

Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
>
> > 'outputs' is unused here, so you can simplify the lambda from
> > (lambda * (#:key outputs #:allow-other-keys) ...)
> > to
> > (lambda _ ...).
>

Was there anything else I should take care of?

Thanks again for the suggestion!

John

Message #26 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: control <at> debbugs.gnu.org, "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Thu, 27 Jan 2022 16:56:02 +0100

[Message part 1 (text/plain, inline)]

user guix
usertag 52806 + reviewed-looks-good
thanks

John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
> Hi Maxime,
> 
> Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:
> 
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > 
> > On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> > 
> > > 'outputs' is unused here, so you can simplify the lambda from
> > > (lambda * (#:key outputs #:allow-other-keys) ...)
> > > to
> > > (lambda _ ...).
> > 
> 
> Was there anything else I should take care of?

IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
the source code of xinitrc-xsession.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: control <at> debbugs.gnu.org, "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Fri, 28 Jan 2022 20:47:08 +0000

Thanks Maxime!

------- Original Message -------

On Thursday, January 27th, 2022 at 10:56 AM, Maxime Devos wrote:

> user guix
> usertag 52806 + reviewed-looks-good
> thanks
>
> John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
>
> > Was there anything else I should take care of?
>
> IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
> the source code of xinitrc-xsession.
>

There is not much to the source, mostly it is an easy way to provide an xsession for your xinitrc. So the source is just a desktop file and helper script to execute a user's xinitrc. Basically making it convenient, through having this in your system configuration, to login through a display manager but with the more barebones (or controllable) xinit style. For example, I use this to set up my bare WM (xmonad) the same as I do when I don't run a display manager.

John

Message #32 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Fri, 28 Jan 2022 22:34:46 +0100

[Message part 1 (text/plain, inline)]

Maxime Devos schreef op do 27-01-2022 om 16:56 [+0100]:
> > [...]
> > Was there anything else I should take care of?
> 
> IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
> the source code of xinitrc-xsession.
> 
> Greetings,
> Maxime.

Also, to be clear, I'm not a committer.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 52806-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>, Maxime Devos
 <maximedevos <at> telenet.be>
Cc: 52806-done <at> debbugs.gnu.org
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Fri, 04 Feb 2022 20:52:09 +0100

Am Dienstag, dem 11.01.2022 um 22:34 +0000 schrieb John Kehayias:
> Hi Maxime,
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> 
> On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> 
> > 'outputs' is unused here, so you can simplify the lambda from
> > (lambda * (#:key outputs #:allow-other-keys) ...)
> > to
> > (lambda _ ...).
> > 
> 
> Right, another thing that can be removed here with the gexp. Thanks!
> 
> John
Hi, I was told Maxime already reviewed this, so I pushed it.  Cheers!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.