GNU bug report logs - #52834
sanity-check fails with namespace packages

Previous Next

To reply to this bug, email your comments to 52834 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: bug-guix <bug-guix <at> gnu.org>
Cc: Lars-Dominik Braun <lars <at> 6xq.net>
Subject: sanity-check fails with namespace packages
Date: Mon, 27 Dec 2021 21:49:18 +0100

Hi,

I just investigated some failing python packages 
<https://ci.guix.gnu.org/eval/16105/dashboard> and found that 
"python2-zppe-*" packages fail. (Most due to a dependency failing , 
though. Actually failing are python2-zope-testing and python2-zope-event).

These fail due to sanity-check not being able to import "zope" - which 
is a namespace package. Both use the "src directory layout" (source is 
contained in a sub-directory "src").

This could be solved by fetching a list og namespace-packages and 
checking whether a fails import is a namespace-package. Maybe there are 
other solution.

try:

     nspkgs = set(dist.get_metadata_lines('namespace_packages.txt'))

except:

    nspkgs = set()

Anyhow, since Python2 is EOL since long, I'm not sure whether it's worth 
the effort.

WDYT?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #8 received at 52834 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 52834 <at> debbugs.gnu.org
Subject: Re: sanity-check fails with namespace packages
Date: Tue, 28 Dec 2021 15:03:38 +0100

Hi Hartmut,

> These fail due to sanity-check not being able to import "zope" - which 
> is a namespace package. Both use the "src directory layout" (source is 
> contained in a sub-directory "src").
As far as I see PEP 420 (implicit namespace packages) is supported by
Python >=3.3 only, so I’m not sure the packages would work even if we
disabled 'sanity-check, do they? Either way, I’m in favor of removing
broken Python 2 packages.

> This could be solved by fetching a list og namespace-packages and 
> checking whether a fails import is a namespace-package. Maybe there are 
> other solution.
> […]
>       nspkgs = set(dist.get_metadata_lines('namespace_packages.txt'))
Depending on undocumented setuptools behavior should imo be avoided and
– for top_level.txt – phased out if possible.

Cheers,
Lars

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.