GNU bug report logs - #52837
Failed to compile rav1e which is dependence for tons of packages

Previous Next

Package: guix;

Reported by: Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>

Date: Mon, 27 Dec 2021 23:54:03 UTC

Severity: normal

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52837 in the body.
You can then email your comments to 52837 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Mon, 27 Dec 2021 23:54:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Mon, 27 Dec 2021 23:54:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>
To: bug-guix <at> gnu.org
Subject: Failed to compile rav1e which is dependence for tons of packages
Date: Tue, 28 Dec 2021 02:09:42 +0300
Hi there,

rav1e failed to compile with error:

starting phase `build'
Error: CliError { error: Some(failed to select a version for `clang-sys`.
    ... required by package `bindgen v0.58.1`
    ... which is depended on by `dav1d-sys v0.3.4`
    ... which is depended on by `rav1e v0.4.1 (/tmp/guix-build-rav1e-0.4.1.drv-0/rav1e-0.4.1)`
versions that meet the requirements `^1` are: 1.0.0

the package `clang-sys` links to the native library `clang`, but it conflicts with a previous package which links to `clang` as well:
package `clang-sys v0.29.3`
    ... which is depended on by `bindgen v0.54.1`
    ... which is depended on by `aom-sys v0.2.1`
    ... which is depended on by `rav1e v0.4.1 (/tmp/guix-build-rav1e-0.4.1.drv-0/rav1e-0.4.1)`

The issue caused by commit ad1e8a0906c. Possible fix:

diff --git a/gnu/packages/crates-graphics.scm b/gnu/packages/crates-graphics.scm
index e4cd01fadf..269bd991ab 100644
--- a/gnu/packages/crates-graphics.scm
+++ b/gnu/packages/crates-graphics.scm
@@ -208,7 +208,7 @@ (define-public rust-aom-sys-0.2
     (build-system cargo-build-system)
     (arguments
       `(#:cargo-inputs
-        (("rust-bindgen" ,rust-bindgen-0.54)
+        (("rust-bindgen" ,rust-bindgen-0.58)
          ("rust-metadeps" ,rust-metadeps-1))))
     (native-inputs
      (list pkg-config))


-- 




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 01:21:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Evgenii Lepikhin via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: Failed to compile rav1e which is dependence for tons
 of packages
Date: Mon, 27 Dec 2021 20:20:32 -0500
On Tue, Dec 28, 2021 at 02:09:42AM +0300, Evgenii Lepikhin via Bug reports for GNU Guix wrote:
> Hi there,
> 
> rav1e failed to compile with error:

Oof, thanks for the report. Looking into it now...




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 01:21:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 01:33:01 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Evgenii Lepikhin via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 52837 <at> debbugs.gnu.org, mail <at> nicolasgoaziou.fr
Subject: Re: bug#52837: Failed to compile rav1e which is dependence for tons
 of packages
Date: Mon, 27 Dec 2021 20:32:44 -0500
On Tue, Dec 28, 2021 at 02:09:42AM +0300, Evgenii Lepikhin via Bug reports for GNU Guix wrote:
> Hi there,
> 
> rav1e failed to compile with error:

Alright, for now I've reverted the commits that caused the problem.

Specifically, I reverted this range of commits:
5b1ec376239602725171d4523406801b684ee195^..13d3120095e4baa03594d095b0afe9febbb7cee0

IIUC, these were pushed together.

Nicolas, can you take a look at the suggested fix shown below?

> The issue caused by commit ad1e8a0906c. Possible fix:
> 
> diff --git a/gnu/packages/crates-graphics.scm b/gnu/packages/crates-graphics.scm
> index e4cd01fadf..269bd991ab 100644
> --- a/gnu/packages/crates-graphics.scm
> +++ b/gnu/packages/crates-graphics.scm
> @@ -208,7 +208,7 @@ (define-public rust-aom-sys-0.2
>      (build-system cargo-build-system)
>      (arguments
>        `(#:cargo-inputs
> -        (("rust-bindgen" ,rust-bindgen-0.54)
> +        (("rust-bindgen" ,rust-bindgen-0.58)
>           ("rust-metadeps" ,rust-metadeps-1))))
>      (native-inputs
>       (list pkg-config))
> 
> 
> -- 




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 01:33:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 03:59:01 GMT) Full text and rfc822 format available.

Message #20 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: 0xFA11BABE <0xFA11BABE <at> protonmail.com>
To: "52837 <at> debbugs.gnu.org" <52837 <at> debbugs.gnu.org>
Subject: Failed to compile rav1e which is dependence for tons of packages
Date: Tue, 28 Dec 2021 03:04:27 +0000
[Message part 1 (text/plain, inline)]
I got the same problem.

> starting phase `build'
> Error: CliError { error: Some(failed to select a version for `clang-sys`.
> ... required by package `bindgen v0.58.1`
> ... which is depended on by `dav1d-sys v0.3.4`
> ... which is depended on by `rav1e v0.4.1 (/tmp/guix-build-rav1e-0.4.1.drv-0/rav1e-0.4.1)`
> versions that meet the requirements `^1` are: 1.0.0
>
> the package `clang-sys` links to the native library `clang`, but it conflicts with a previous package which links to `clang` as well:
> package `clang-sys v0.29.3`
> ... which is depended on by `bindgen v0.54.1`
> ... which is depended on by `aom-sys v0.2.1`
> ... which is depended on by `rav1e v0.4.1 (/tmp/guix-build-rav1e-0.4.1.drv-0/rav1e-0.4.1)`
>
> failed to select a version for `clang-sys` which could resolve this conflict), exit_code: 101 }
> error: in phase 'build': uncaught exception:
> %exception #<&invoke-error program: "cargo" arguments: ("cinstall" "--release" "--prefix=/gnu/store/83mfvccy0szp2v9v2qk8xf5wz867ndnx-rav1e-0.4.1") exit-status: 1 term-signal: #f stop-signal: #f>
> phase `build' failed after 0.7 seconds
> command "cargo" "cinstall" "--release" "--prefix=/gnu/store/83mfvccy0szp2v9v2qk8xf5wz867ndnx-rav1e-0.4.1" failed with status 1
[Message part 2 (text/html, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 06:02:01 GMT) Full text and rfc822 format available.

Message #23 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>
To: 52837 <at> debbugs.gnu.org
Subject: We need deeper research
Date: Tue, 28 Dec 2021 09:01:07 +0300
Hi,

Suggested fix is insufficient because dependency on version is hard coded in the crate: https://github.com/rust-av/aom-rs/blob/ea9a45d6ec7bfd2cd0d6f9f43268d9e379bba168/aom-sys/Cargo.toml#L18

We need to update both rust-aom-sys to == 0.3.0 and rav1e to >= 0.5.0.


-- 
QA automation teamlead at Mail.ru.




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 13:47:01 GMT) Full text and rfc822 format available.

Message #26 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: Failed to compile rav1e which is dependence for tons
 of packages
Date: Tue, 28 Dec 2021 14:46:23 +0100
Hello,

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Dec 28, 2021 at 02:09:42AM +0300, Evgenii Lepikhin via Bug reports for GNU Guix wrote:
>> Hi there,
>> 
>> rav1e failed to compile with error:
>
> Alright, for now I've reverted the commits that caused the problem.
>
> Specifically, I reverted this range of commits:
> 5b1ec376239602725171d4523406801b684ee195^..13d3120095e4baa03594d095b0afe9febbb7cee0

Thank you.

You reverted 100+ commits but only one of them is problematic. Could you
unrevert them barring ad1e8a0906cca4f5c2fd18534a935a375161e608?

> IIUC, these were pushed together.
>
> Nicolas, can you take a look at the suggested fix shown below?

IIUC, a safe solution would be to exceptionally provide both
rust-dav1d-sys 0.3.2 (for rav1e) and 0.3.4 (for nushell), the latter
being called rust-dav1d-sys-0.3.

With this we do not have to bother updating rav1e yet.

WDYT?


Regards,
-- 
Nicolas Goaziou




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 19:36:01 GMT) Full text and rfc822 format available.

Message #29 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: Failed to compile rav1e which is dependence for tons
 of packages
Date: Tue, 28 Dec 2021 14:35:09 -0500
On Tue, Dec 28, 2021 at 02:46:23PM +0100, Nicolas Goaziou wrote:
> You reverted 100+ commits but only one of them is problematic. Could you
> unrevert them barring ad1e8a0906cca4f5c2fd18534a935a375161e608?

I did so like this:

`git cherry-pick 5b1ec376239602725171d4523406801b684ee195^..13d3120095e4baa03594d095b0afe9febbb7cee0 && \
git revert ad1e8a0906cca4f5c2fd18534a935a375161e608`

Then, rav1e (and FFmpeg) built successfully.

So, I pushed as 9309b488ca4ceef4fcc9283546e3b05c57b16ca8.

> IIUC, a safe solution would be to exceptionally provide both
> rust-dav1d-sys 0.3.2 (for rav1e) and 0.3.4 (for nushell), the latter
> being called rust-dav1d-sys-0.3.
> 
> With this we do not have to bother updating rav1e yet.
> 
> WDYT?

Sounds like a plan. Are you able to do it?




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 19:42:01 GMT) Full text and rfc822 format available.

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Evgenii Lepikhin via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: We need deeper research
Date: Tue, 28 Dec 2021 14:41:26 -0500
On Tue, Dec 28, 2021 at 09:01:07AM +0300, Evgenii Lepikhin via Bug reports for GNU Guix wrote:
> Hi,
> 
> Suggested fix is insufficient because dependency on version is hard coded in the crate: https://github.com/rust-av/aom-rs/blob/ea9a45d6ec7bfd2cd0d6f9f43268d9e379bba168/aom-sys/Cargo.toml#L18
> 
> We need to update both rust-aom-sys to == 0.3.0 and rav1e to >= 0.5.0.

Okay, that's good to know. I hope that somebody will try it and report
back.




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 19:42:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 20:32:02 GMT) Full text and rfc822 format available.

Message #38 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: Failed to compile rav1e which is dependence for tons
 of packages
Date: Tue, 28 Dec 2021 21:31:19 +0100
Hello,

Leo Famulari <leo <at> famulari.name> writes:

> So, I pushed as 9309b488ca4ceef4fcc9283546e3b05c57b16ca8.

Thanks!
>
>> IIUC, a safe solution would be to exceptionally provide both
>> rust-dav1d-sys 0.3.2 (for rav1e) and 0.3.4 (for nushell), the latter
>> being called rust-dav1d-sys-0.3.
>> 
>> With this we do not have to bother updating rav1e yet.
>> 
>> WDYT?
>
> Sounds like a plan. Are you able to do it?

This is now done on master. AFAICT both nushell and rav1e build. I'll
let the OP confirm the issue is fixed and close the bug report.

Regards,
-- 
Nicolas Goaziou




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Tue, 28 Dec 2021 21:30:02 GMT) Full text and rfc822 format available.

Message #41 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: Failed to compile rav1e which is dependence for tons
 of packages
Date: Tue, 28 Dec 2021 16:29:46 -0500
On Tue, Dec 28, 2021 at 09:31:19PM +0100, Nicolas Goaziou wrote:
> This is now done on master. AFAICT both nushell and rav1e build. I'll
> let the OP confirm the issue is fixed and close the bug report.

Thanks!

I noticed that Guix complained about "possibly undefined variables" for
llvm and clang and rust-dav1d-sys-0.3.2 failed to build, so I pushed a
commit that imports the LLVM module in (gnu package video).

At first I was confused because rav1e still built, but our Rust
packaging doesn't require dependencies to build.




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Wed, 29 Dec 2021 08:43:01 GMT) Full text and rfc822 format available.

Message #44 received at 52837 <at> debbugs.gnu.org (full text, mbox):

From: Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52837 <at> debbugs.gnu.org
Subject: Re: bug#52837: We need deeper research
Date: Wed, 29 Dec 2021 11:42:43 +0300
On 2021-12-28 14:41, Leo Famulari wrote:

>> We need to update both rust-aom-sys to == 0.3.0 and rav1e to >= 0.5.0.
>
> Okay, that's good to know. I hope that somebody will try it and report
> back.

Now it is fixed.

Thank you.


-- 
QA automation teamlead at Mail.ru.




Information forwarded to bug-guix <at> gnu.org:
bug#52837; Package guix. (Wed, 29 Dec 2021 13:58:02 GMT) Full text and rfc822 format available.

Message #47 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Evgenii Lepikhin via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>, 52837-done <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#52837: We need deeper research
Date: Wed, 29 Dec 2021 14:57:29 +0100
Hello,

Evgenii Lepikhin via Bug reports for GNU Guix <bug-guix <at> gnu.org> writes:

> Now it is fixed.

Closing it, then. Thanks for the feedback.

Regards,
-- 
Nicolas Goaziou




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Wed, 29 Dec 2021 13:58:02 GMT) Full text and rfc822 format available.

Notification sent to Evgenii Lepikhin <e.lepikhin <at> corp.mail.ru>:
bug acknowledged by developer. (Wed, 29 Dec 2021 13:58:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 27 Jan 2022 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 60 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.