GNU bug report logs - #52875
[PATCH] gnu: Add musikcube.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52875 in the body.
You can then email your comments to 52875 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add musikcube.
Date: Wed, 29 Dec 2021 12:13:30 -0500

* gnu/packages/music.scm (musikcube): New variable.
---
 gnu/packages/music.scm | 51 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 4a3e122936..94566efc12 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -121,6 +121,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gnunet)
   #:use-module (gnu packages gpodder)
   #:use-module (gnu packages graphics)
   #:use-module (gnu packages graphviz)
@@ -132,6 +133,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages java)
   #:use-module (gnu packages libffi)
+  #:use-module (gnu packages libevent)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux) ; for alsa-utils
   #:use-module (gnu packages lirc)
@@ -6826,3 +6828,52 @@ (define-public opustags
 choice.")
     (home-page "https://github.com/fmang/opustags")
     (license license:bsd-3)))
+
+(define-public musikcube
+  (package
+    (name "musikcube")
+    (version "0.96.10")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/clangen/musikcube/")
+                     (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "06myr83x8jvzlzchg3jsw1163n2lcsbmb176zgnx7xxa26jpdbh1"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+       #:tests? #f ; No test suite
+       #:configure-flags
+       #~(list
+           "-DCMAKE_BUILD_TYPE=Release"
+           "-DENABLE_BUNDLED_TAGLIB=false"
+           ;; Use the "wide" ncurses headers but don't look for them in an
+           ;; ncursesw directory. For more info:
+           ;; https://github.com/clangen/musikcube/wiki/building#compiler-cannot-find-ncurseswcursesh
+           "-DNO_NCURSESW=true"
+           ;; We will strip the binaries ourselves in the 'strip' phase.
+           "-DDISABLE_STRIP=true")))
+    (native-inputs
+     (list pkg-config))
+    (inputs
+     (list alsa-lib
+           boost
+           curl
+           ffmpeg
+           lame
+           libev
+           libmicrohttpd
+           libopenmpt
+           ncurses
+           openssl
+           pulseaudio
+           taglib
+           zlib))
+    (synopsis "Terminal-based music player, library, and streaming audio server")
+    (description "Musikcube is a terminal-based music player, library, and
+streaming audio server.")
+    (home-page "https://musikcube.com/")
+    (license license:bsd-3)))
-- 
2.34.0

Message #8 received at 52875 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52875 <at> debbugs.gnu.org
Subject: Re: [bug#52875] [PATCH] gnu: Add musikcube.
Date: Thu, 30 Dec 2021 00:13:49 +0100

Hello,

Leo Famulari <leo <at> famulari.name> writes:

> * gnu/packages/music.scm (musikcube): New variable.

Nice! Thanks.

> +(define-public musikcube
> +  (package
> +    (name "musikcube")
> +    (version "0.96.10")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                     (url "https://github.com/clangen/musikcube/")
> +                     (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "06myr83x8jvzlzchg3jsw1163n2lcsbmb176zgnx7xxa26jpdbh1"))))

Nitpick: origin could go below source, and hash in front of base32.

> +    (build-system cmake-build-system)
> +    (arguments
> +     (list
> +       #:tests? #f ; No test suite

Note that indentation is a bit off.

> +       #:configure-flags
> +       #~(list
> +           "-DCMAKE_BUILD_TYPE=Release"
> +           "-DENABLE_BUNDLED_TAGLIB=false"
> +           ;; Use the "wide" ncurses headers but don't look for them in an
> +           ;; ncursesw directory. For more info:
> +           ;; https://github.com/clangen/musikcube/wiki/building#compiler-cannot-find-ncurseswcursesh
> +           "-DNO_NCURSESW=true"
> +           ;; We will strip the binaries ourselves in the 'strip' phase.
> +           "-DDISABLE_STRIP=true")))

OOC, why are use using gexp since you do not ungexp later on? Wouldn't
a regular quote, or even a quasiquote suffice?

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Message #13 received at 52875-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 52875-done <at> debbugs.gnu.org
Subject: Re: [bug#52875] [PATCH] gnu: Add musikcube.
Date: Fri, 31 Dec 2021 13:20:14 -0500

On Thu, Dec 30, 2021 at 12:13:49AM +0100, Nicolas Goaziou wrote:
> OOC, why are use using gexp since you do not ungexp later on? Wouldn't
> a regular quote, or even a quasiquote suffice?

Good point, I simplified it to use regular quoting.

I left the indentation as is, because it seems typical for Guix. My
sense of Scheme style is... naive.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.