GNU bug report logs - #52878
[PATCH] Fix display-comint-buffer-action default behavior

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52878 in the body.
You can then email your comments to 52878 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: bug-gnu-emacs <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] Fix display-comint-buffer-action default behavior
Date: Wed, 29 Dec 2021 13:38:06 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* lisp/window.el (display-comint-buffer-action): Make it an alist.
---

This is my first real contribution to Emacs :)

My copyright papers are all good (not that it matters for this).

The recent change that added display-comint-buffer-action does not do what it was supposed to.  Since it is not a list, when it gets passed to display-buffer, display-buffer ignores the value.

I'm not 100% I did everything right, but I looked at gdb-display-buffer-other-frame-action for reference and verified the behavior of the change myself.


 lisp/window.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/window.el b/lisp/window.el
index d75dd9931b..34b2d0c78a 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7474,9 +7474,9 @@ display-buffer-base-action
   :version "24.1"
   :group 'windows)
 
-(defcustom display-comint-buffer-action 'display-buffer-same-window
-  "The action to display a comint buffer."
-  :type 'display-buffer--action-function-custom-type
+(defcustom display-comint-buffer-action '((display-buffer-same-window))
+  "`display-buffer' action for displaying comint buffers."
+  :type display-buffer--action-custom-type
   :risky t
   :version "29.1"
   :group 'windows
-- 
2.34.0

Message #8 received at 52878 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Morgan.J.Smith <at> outlook.com
Cc: 52878 <at> debbugs.gnu.org
Subject: Re: bug#52878: [PATCH] Fix display-comint-buffer-action default
 behavior
Date: Wed, 29 Dec 2021 12:35:26 -0800

Morgan.J.Smith <at> outlook.com writes:

> This is my first real contribution to Emacs :)

Congratulations, and welcome here!

> The recent change that added display-comint-buffer-action does not do
> what it was supposed to.  Since it is not a list, when it gets passed
> to display-buffer, display-buffer ignores the value.

I think we will see what will happen to that recent change.  There is
even talk about reverting it on emacs-devel, but nothing conclusive as
of yet.  So be aware that your patch might have to wait until that
discussion is concluded.

Message #11 received at 52878 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Morgan.J.Smith <at> outlook.com, 52878 <at> debbugs.gnu.org
Subject: Re: bug#52878: [PATCH] Fix display-comint-buffer-action default
 behavior
Date: Thu, 6 Jan 2022 18:16:07 +0100

A minor issue: The "right" initial value should probably be

'(display-buffer-same-window . ((inhibit-same-window . nil)))

since otherwise

(setq display-buffer-base-action
      '(nil . ((inhibit-same-window . t))))

would inhibit using the same window.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.