GNU bug report logs - #52893
gnu: add python-lief

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52893 in the body.
You can then email your comments to 52893 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Ford <fanquake <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: gnu: add python-lief
Date: Thu, 30 Dec 2021 16:52:02 +0800

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[add_python_lief.patch (application/octet-stream, attachment)]

Message #8 received at 52893 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Michael Ford <fanquake <at> gmail.com>
Cc: 52893 <at> debbugs.gnu.org
Subject: Re: [bug#52893] gnu: add python-lief
Date: Thu, 30 Dec 2021 11:02:08 +0100

Hello,

Michael Ford <fanquake <at> gmail.com> writes:

> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 3a9e35aacf..08ab5431f3 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -27844,3 +27844,26 @@ (define-public python-iwlib
>      (description
>       "This package provides a Python interface to iw wireless tools.")
>      (license license:gpl2)))
> +
> +(define-public lief

Thank you. Some comments follow.

But first and foremost, you need to provide a proper commit message, and
use `git format-patch' to send it to the list.  See Contributing section
in the manual, and examples of messages in the commits history of the
probject.

> +  (package
> +   (name "python-lief")

Package name and variable name are differents, this should be (name
"lief"), since it doesn't seem to be Python specific.

> +   (version "0.11.5")
> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url "https://github.com/lief-project/LIEF.git")

You can remove ".git" suffix here.

> +           (commit version)))
> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32
> +       "0qahjfg1n0x76ps2mbyljvws1l3qhkqvmxqbahps4qgywl2hbdkj"))))

Hash string should go on the same line as base32.

> +   (build-system python-build-system)
> +   (native-inputs
> +    `(("cmake" ,cmake)))

I think this is the other way. You may use cmake-build-system, and
provide python-wrapper as a native input.

> +   (home-page "https://github.com/lief-project/LIEF")
> +   (synopsis "Library to Instrument Executable Formats")
> +   (description "Python library to to provide a cross platform library which can
> +parse, modify and abstract ELF, PE and MachO formats.")

AFAIU, this is not a Python-only library. Besides, the description
should consist of full sentences.

I made the changes suggested above, but couldn't run the tests. Also,
I didn't build documentation. Eventually, the process seems to create
static libraries, it would be nice to remove them. Could you look into
it and see what is possible to do?

--8<---------------cut here---------------start------------->8---
(define-public lief
  (package
    (name "lief")
    (version "0.11.5")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
             (url "https://github.com/lief-project/LIEF")
             (commit version)))
       (file-name (git-file-name name version))
       (sha256
        (base32 "0qahjfg1n0x76ps2mbyljvws1l3qhkqvmxqbahps4qgywl2hbdkj"))))
    (build-system cmake-build-system)
    (arguments
     `(#:tests? #f                      ;FIXME: Require git
       #:configure-flags (list "-DLIEF_INSTALL_PYTHON=ON")))
    (native-inputs
     (list python-wrapper))
    (home-page "https://github.com/lief-project/LIEF")
    (synopsis "Library to Instrument Executable Formats")
    (description
     "LIEF is a library which can parse, modify and abstract ELF, PE
and MachO formats.  It can be used in C, C++ and Python.")
    (license license:asl2.0)))
--8<---------------cut here---------------end--------------->8---


Regards,
-- 
Nicolas Goaziou

Message #13 received at 52893-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 52893-done <at> debbugs.gnu.org
Subject: gnu: add python-lief
Date: Tue, 11 Feb 2025 20:24:35 +0000

[Message part 1 (text/plain, inline)]

Hi,

This project is already in Guix's master branch.

83bfdb40978 gnu: python-lief: Update to 0.12.3.
3451b4adb7e gnu: python-lief: Update to 0.12.2.
e4aca1cc3f8 gnu: Add python-lief.

Closing as not applied.

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.