GNU bug report logs - #52900
[PATCH] gnu: libfido2: install udev rules

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52900 in the body.
You can then email your comments to 52900 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: dan <igaryhe <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libfido2: install udev rules
Date: Fri, 31 Dec 2021 01:00:32 +0800

[arguments]: Add a configure flag specifying the installation directory of the
udev rule.

---
 gnu/packages/security-token.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 6a3e2d9179..719515e3ea 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -777,7 +777,9 @@ (define-public libfido2
        ("openssl" ,openssl)))
     (build-system cmake-build-system)
     (arguments
-     '(#:phases
+     '(#:configure-flags
+       (list (string-append "-DUDEV_RULES_DIR=" %output "/lib/udev/rules.d"))
+       #:phases
        (modify-phases %standard-phases
          ;; regress tests enabled only for debug builds
          (delete 'check))))
-- 
2.34.0

Message #8 received at 52900 <at> debbugs.gnu.org (full text, mbox):

From: dan <igaryhe <at> gmail.com>
To: 52900 <at> debbugs.gnu.org
Subject: Update cover letter
Date: Fri, 31 Dec 2021 01:12:11 +0800

For some reason the cover letter was not shown up properly.  The 
following is the missing line:

* gnu/packages/security-token.scm(libfido2): Install udev rules.
-- 
dan

Message #11 received at 52900 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "52900 <at> debbugs.gnu.org" <52900 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: libfido2: install udev rules
Date: Wed, 15 Jun 2022 16:13:57 +0000

Hello,

Thanks for the patch. Could you update it to match the current package definition of libfido2 (and you may want to add your copyright line to the top)?

Since libu2f is deprecated, we should rely on libfido2, so we need the udev rules that this patch makes available. I tested a local version which just needed to add the (string-append...) s-expression to the #:configure-flags that are currently present. I tested that it built and did have the udev rules.

Thanks!
John

Message #14 received at 52900 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 52900 <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>, ngraves <at> ngraves.fr,
 dan <igaryhe <at> gmail.com>
Subject: [PATCH] gnu: libfido2: install udev rules.
Date: Thu, 06 Oct 2022 19:07:28 +0200

[arguments]: Add a configure flag specifying the installation directory of the
udev rule.
---
 gnu/packages/security-token.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 447a7a582d..5f10b5592a 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -909,7 +909,8 @@ (define-public libfido2
                "-DPKG_CONFIG_EXECUTABLE="
                (search-input-file %build-inputs
                                   (string-append
-                                    "/bin/" ,(pkg-config-for-target)))))
+                                   "/bin/" ,(pkg-config-for-target))))
+             (string-append "-DUDEV_RULES_DIR=" %output "/lib/udev/rules.d"))
        #:phases
        (modify-phases %standard-phases
          ;; regress tests enabled only for debug builds
--
2.37.3

--
Best regards,
Nicolas Graves

Message #19 received at 52900-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: John Kehayias <john.kehayias <at> protonmail.com>, 52900-done <at> debbugs.gnu.org,
 dan <igaryhe <at> gmail.com>
Subject: Re: [bug#52900] [PATCH] gnu: libfido2: install udev rules.
Date: Thu, 13 Oct 2022 12:44:19 +0100

[Message part 1 (text/plain, inline)]

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> [arguments]: Add a configure flag specifying the installation directory of the
> udev rule.
> ---
>  gnu/packages/security-token.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks all, I've gone ahead and pushed this to master as.
33f56db65498b75ad0a55b780ce501d2b3532044.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.