GNU bug report logs - #52910
[PATCH] gnu: krita: Fix build.

Previous Next

Package: guix-patches;

Reported by: Vinicius Monego <monego <at> posteo.net>

Date: Fri, 31 Dec 2021 01:07:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52910 in the body.
You can then email your comments to 52910 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#52910; Package guix-patches. (Fri, 31 Dec 2021 01:07:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vinicius Monego <monego <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 31 Dec 2021 01:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH] gnu: krita: Fix build.
Date: Fri, 31 Dec 2021 01:06:32 +0000
* gnu/packages/kde.scm (krita)[inputs]: Remove python, python-pyqt,
python-sip.
---
 gnu/packages/kde.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 8531e8683e..dfd4cd197c 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -533,9 +533,6 @@ expression library, that is used in Krita.")
            openjpeg
            perl
            poppler-qt5
-           python
-           python-pyqt
-           python-sip
            qtbase-5
            qtdeclarative
            qtmultimedia

base-commit: 04c7220bc11756e638f931370f539005177afab9
-- 
2.30.2





Information forwarded to guix-patches <at> gnu.org:
bug#52910; Package guix-patches. (Fri, 31 Dec 2021 22:40:02 GMT) Full text and rfc822 format available.

Message #8 received at 52910 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 52910 <at> debbugs.gnu.org
Subject: Re: [bug#52910] [PATCH] gnu: krita: Fix build.
Date: Fri, 31 Dec 2021 17:39:38 -0500
On Fri, Dec 31, 2021 at 01:06:32AM +0000, Vinicius Monego wrote:
> * gnu/packages/kde.scm (krita)[inputs]: Remove python, python-pyqt,
> python-sip.

It's hard to find the error in the voluminous Krita build log.

Here it is:

------
[ 64%] Generating _tmp/krita/sipkritapart0.cpp
cd /tmp/guix-build-krita-5.0.0.drv-0/build/plugins/extensions/pykrita/sip && /gnu/store/aain9m7r37jlzd21kvgvrkhc2pm7mk1w-cmake-minimal-3.21.3/bin/cmake -E echo Generating\ SIP\ 5+\ bindings\ for\ PyKrita.krita...
Generating SIP 5+ bindings for PyKrita.krita...
cd /tmp/guix-build-krita-5.0.0.drv-0/build/plugins/extensions/pykrita/sip && /gnu/store/aain9m7r37jlzd21kvgvrkhc2pm7mk1w-cmake-minimal-3.21.3/bin/cmake -E env PYTHONPATH=: /gnu/store/p5fgysbcnnp8b1d91mrvjvababmczga0-python-3.9.6/bin/python3 /tmp/guix-build-krita-5.0.0.drv-0/krita-5.0.0/cmake/modules/sip-generate.py --build-dir /tmp/guix-build-krita-5.0.0.drv-0/build/plugins/extensions/pykrita/sip/_tmp --target-dir lib/krita-python-libs/PyKrita --concatenate 1
These bindings will be built: kritamod.
Generating the kritamod bindings...
sip-generate.py: Unable to find file "QtCore/QtCoremod.sip"

make[2]: *** [plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krita_autogen.dir/build.make:79: plugins/extensions/pykrita/sip/_tmp/krita/sipkritapart0.cpp] Error 1
make[2]: Leaving directory '/tmp/guix-build-krita-5.0.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:29065: plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krita_autogen.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-krita-5.0.0.drv-0/build'
make: *** [Makefile:149: all] Error 2
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("-j" "1") exit-status: 2 term-signal: #f stop-signal: #f>
phase `build' failed after 42393.6 seconds
------

Googling for this error message from sip-generate.py, there is plenty of
discussion. For example, this thread:

https://groups.google.com/g/linux.debian.bugs.dist/c/FdgUVpZ4SWE

It's okay if we can't fix it or don't want to fix it, and instead choose
to remove the relevant functionality. But did we try to fix it yet? Can
you take a look?




Information forwarded to guix-patches <at> gnu.org:
bug#52910; Package guix-patches. (Fri, 31 Dec 2021 23:44:02 GMT) Full text and rfc822 format available.

Message #11 received at 52910 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52910 <at> debbugs.gnu.org
Subject: Re: [bug#52910] [PATCH] gnu: krita: Fix build.
Date: Fri, 31 Dec 2021 23:43:26 +0000
Em sex, 2021-12-31 às 17:39 -0500, Leo Famulari escreveu:
> On Fri, Dec 31, 2021 at 01:06:32AM +0000, Vinicius Monego wrote:
> > * gnu/packages/kde.scm (krita)[inputs]: Remove python, python-pyqt,
> > python-sip.
> 
> It's hard to find the error in the voluminous Krita build log.
> 
> Here it is:
> 
> ------
> [ 64%] Generating _tmp/krita/sipkritapart0.cpp
> cd /tmp/guix-build-krita-5.0.0.drv-
> 0/build/plugins/extensions/pykrita/sip &&
> /gnu/store/aain9m7r37jlzd21kvgvrkhc2pm7mk1w-cmake-minimal-
> 3.21.3/bin/cmake -E echo Generating\ SIP\ 5+\ bindings\ for\
> PyKrita.krita...
> Generating SIP 5+ bindings for PyKrita.krita...
> cd /tmp/guix-build-krita-5.0.0.drv-
> 0/build/plugins/extensions/pykrita/sip &&
> /gnu/store/aain9m7r37jlzd21kvgvrkhc2pm7mk1w-cmake-minimal-
> 3.21.3/bin/cmake -E env PYTHONPATH=:
> /gnu/store/p5fgysbcnnp8b1d91mrvjvababmczga0-python-3.9.6/bin/python3
> /tmp/guix-build-krita-5.0.0.drv-0/krita-5.0.0/cmake/modules/sip-
> generate.py --build-dir /tmp/guix-build-krita-5.0.0.drv-
> 0/build/plugins/extensions/pykrita/sip/_tmp --target-dir lib/krita-
> python-libs/PyKrita --concatenate 1
> These bindings will be built: kritamod.
> Generating the kritamod bindings...
> sip-generate.py: Unable to find file "QtCore/QtCoremod.sip"
> 
> make[2]: ***
> [plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krit
> a_autogen.dir/build.make:79:
> plugins/extensions/pykrita/sip/_tmp/krita/sipkritapart0.cpp] Error 1
> make[2]: Leaving directory '/tmp/guix-build-krita-5.0.0.drv-0/build'
> make[1]: *** [CMakeFiles/Makefile2:29065:
> plugins/extensions/pykrita/sip/CMakeFiles/python_module_PyKrita_krita
> _autogen.dir/all] Error 2
> make[1]: Leaving directory '/tmp/guix-build-krita-5.0.0.drv-0/build'
> make: *** [Makefile:149: all] Error 2
> error: in phase 'build': uncaught exception:
> %exception #<&invoke-error program: "make" arguments: ("-j" "1")
> exit-status: 2 term-signal: #f stop-signal: #f>
> phase `build' failed after 42393.6 seconds
> ------
> 
> Googling for this error message from sip-generate.py, there is plenty
> of
> discussion. For example, this thread:
> 
> https://groups.google.com/g/linux.debian.bugs.dist/c/FdgUVpZ4SWE
> 
> It's okay if we can't fix it or don't want to fix it, and instead
> choose
> to remove the relevant functionality. But did we try to fix it yet?
> Can
> you take a look?

I did try to fix it by setting "PYQT_SIP_DIR_OVERRIDE" [1] to point to
the correct sip dir (see the veusz package for instance), but CMake
ignored that variable when I set it.

The problem is that Krita in my machine takes 4 to 5 hours to reach
67%, where it fails, to test if it works or not. In the CI, Krita takes
as many minutes to fail at 67% as Blender takes to fully build.

The functionality was also never "enabled" because the build failed
before it could be used.

https://docs.krita.org/en/untranslatable_pages/cmake_settings_for_developers.html





Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Sun, 02 Jan 2022 02:22:02 GMT) Full text and rfc822 format available.

Notification sent to Vinicius Monego <monego <at> posteo.net>:
bug acknowledged by developer. (Sun, 02 Jan 2022 02:22:02 GMT) Full text and rfc822 format available.

Message #16 received at 52910-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 52910-done <at> debbugs.gnu.org
Subject: Re: [bug#52910] [PATCH] gnu: krita: Fix build.
Date: Sat, 1 Jan 2022 21:21:36 -0500
On Fri, Dec 31, 2021 at 11:43:26PM +0000, Vinicius Monego wrote:
> I did try to fix it by setting "PYQT_SIP_DIR_OVERRIDE" [1] to point to
> the correct sip dir (see the veusz package for instance), but CMake
> ignored that variable when I set it.
> 
> The problem is that Krita in my machine takes 4 to 5 hours to reach
> 67%, where it fails, to test if it works or not. In the CI, Krita takes
> as many minutes to fail at 67% as Blender takes to fully build.
> 
> The functionality was also never "enabled" because the build failed
> before it could be used.

Okay. I added the context to the commit message and pushed as
2c6dfeac6459901b500a81a1d733a48993792a11




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 30 Jan 2022 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 86 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.