GNU bug report logs - #52932
[PATCH] gnu: uim: Build with '-O2'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52932 in the body.
You can then email your comments to 52932 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 路辉 <luhux76 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: uim: Build with '-O2'.
Date: Sat, 1 Jan 2022 13:08:13 +0000

* gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g".
---
 gnu/packages/xorg.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index b09d95f770..fa747ebac4 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2021 Matthew James Kraai <kraai <at> ftbfs.org>
 ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
 ;;; Copyright © 2021 qblade <qblade <at> protonmail.com>
+;;; Copyright © 2021 Lu Hui <luhux76 <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6446,7 +6447,8 @@ (define-public uim
        (list "--with-anthy-utf8"
              (string-append "--with-lispdir=" %output "/share/emacs")
              ;; Set proper runpath
-             (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib"))
+             (string-append "LDFLAGS=-Wl,-rpath=" %output "/lib")
+             "CFLAGS=-O2 -g -fcommon")
        #:phases
        (modify-phases %standard-phases
          ;; Set path of uim-el-agent and uim-el-helper-agent executables
-- 
2.34.0

Message #8 received at 52932 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 52932 <at> debbugs.gnu.org
Subject: Re: [bug#52932] [PATCH] gnu: uim: Build with '-O2'.
Date: Sat, 1 Jan 2022 22:58:51 -0500

On Sat, Jan 01, 2022 at 01:08:13PM +0000, 路辉 wrote:
> * gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g".

Thanks! I see this fixes the build.

> +             "CFLAGS=-O2 -g -fcommon")

Did you mean to use '-fcommon' too? It's not in the commit message.

Message #11 received at 52932 <at> debbugs.gnu.org (full text, mbox):

From: 路辉 <luhux76 <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52932 <at> debbugs.gnu.org
Subject: Re: [bug#52932] [PATCH] gnu: uim: Build with '-O2'.
Date: Sun, 2 Jan 2022 22:19:07 +0800

[Message part 1 (text/plain, inline)]

sorry, I'm careless.

New patch v

[0001-gnu-uim-Build-with-O2-g-fcommon.patch (text/x-patch, attachment)]

Message #16 received at 52932-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 52932-done <at> debbugs.gnu.org
Subject: Re: [bug#52932] [PATCH] gnu: uim: Build with '-O2'.
Date: Sun, 2 Jan 2022 12:43:42 -0500

On Sun, Jan 02, 2022 at 10:19:07PM +0800, 路辉 wrote:
> New patch v

> From 7cf15ce69ac9a46a8d0d05891d84c17c59ba73c6 Mon Sep 17 00:00:00 2001
> From: Lu Hui <luhux76 <at> gmail.com>
> Date: Sat, 1 Jan 2022 15:53:22 +0800
> Subject: [PATCH] gnu: uim: Build with '-O2 -g -fcommon'.
> 
> * gnu/packages/xorg.scm (uim) [arguments]: Pass "-O2 -g -fcommon".

Thanks! Pushed as b2ed92ec58ea122e96b2f2b00f43af254b305c75

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.