GNU logs - #52951, boring messages

Message sent to daniel@HIDDEN, arthur.miller@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs
Resent-From: Stefan Kangas <stefan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: daniel@HIDDEN, arthur.miller@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jan 2022 14:42:01 +0000
Resent-Message-ID: <handler.52951.B.164113446818355 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 52951 <at> debbugs.gnu.org
Cc: Daniel Jensen <daniel@HIDDEN>, Arthur Miller <arthur.miller@HIDDEN>
From: Stefan Kangas <stefan@HIDDEN>
MIME-Version: 1.0
Date: Sun, 2 Jan 2022 09:41:03 -0500
Message-ID: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=209.85.214.182;
 envelope-from=stefankangas@HIDDEN; helo=mail-pl1-f182.google.com
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) FREEMAIL_FORGED_FROMDOMAIN=0.249,
 FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

Severity: wishlist

We have talked about adding the library sv-kalender.el to Emacs itself:

    https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00030.html

I am opening this bug to track this work.  The main question that
remains is whether or not we have the necessary copyright assignments.

Daniel, if I understand correctly, you have already assigned copyright
to the FSF for Emacs contributions.  Are you okay with including
sv-kalender.el in Emacs itself?  Could you please also confirm that you
have written that file yourself?

The current plan would be to include sv-kalender.el as a "core" package
in the main Emacs repository.  This means that it will be maintained in
emacs.git, but we will have the option to release new versions of the
package on GNU ELPA.

Thanks in advance.

[Please use "Reply to all" to make sure any followups land in the bug
 tracker.]

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefan Kangas <stefan@HIDDEN>
Subject: bug#52951: Acknowledgement (Including Swedish calendar
 localization (sv-kalender.el) in Emacs)
Message-ID: <handler.52951.B.164113446818355.ack <at> debbugs.gnu.org>
References: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
X-Gnu-PR-Message: ack 52951
X-Gnu-PR-Package: emacs
Reply-To: 52951 <at> debbugs.gnu.org
Date: Sun, 02 Jan 2022 14:42:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Daniel Jensen <daniel@HIDDEN>, Arthur Miller <arthur.miller@HIDDEN=
om>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 52951 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
52951: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D52951
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs
Resent-From: Daniel Jensen <daniel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jan 2022 22:52:02 +0000
Resent-Message-ID: <handler.52951.B52951.164116388532557 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stefan Kangas <stefan@HIDDEN>
Cc: 52951 <at> debbugs.gnu.org, Arthur Miller <arthur.miller@HIDDEN>
Authorized-sender: daniel@HIDDEN
From: Daniel Jensen <daniel@HIDDEN>
References: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
Date: Sun, 02 Jan 2022 20:16:35 +0100
In-Reply-To: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
 (Stefan Kangas's message of "Sun, 2 Jan 2022 09:41:03 -0500")
Message-ID: <87ee5q6j8s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2022-01-02 at 09:41, Stefan Kangas wrote:

> Severity: wishlist
>
> We have talked about adding the library sv-kalender.el to Emacs itself:
>
>     https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00030.html
>
> I am opening this bug to track this work.  The main question that
> remains is whether or not we have the necessary copyright assignments.
>
> Daniel, if I understand correctly, you have already assigned copyright
> to the FSF for Emacs contributions.  Are you okay with including
> sv-kalender.el in Emacs itself?  Could you please also confirm that you
> have written that file yourself?

I have assigned copyright to the FSF, yes. I wrote sv-kalender.el. Some
of it was adapted from holiday code in Emacs at the time, but it was a
long time ago and I don't recall any specifics -- it is not a copyright
problem anyway. I don't mind at all having it included in Emacs.

> The current plan would be to include sv-kalender.el as a "core" package
> in the main Emacs repository.  This means that it will be maintained in
> emacs.git, but we will have the option to release new versions of the
> package on GNU ELPA.

I'm glad you want to include it in Emacs. I'm sure some improvement is
needed to have it match Emacs standards. Unfortunately I don't have the
time to work on this project right now, but I wish you luck. Thank you!

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs
Resent-From: Stefan Kangas <stefan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jan 2022 23:44:02 +0000
Resent-Message-ID: <handler.52951.B52951.16411670245509 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Daniel Jensen <daniel@HIDDEN>
Cc: 52951 <at> debbugs.gnu.org, Arthur Miller <arthur.miller@HIDDEN>
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <87ee5q6j8s.fsf@HIDDEN> (Daniel Jensen's message of "Sun, 
 02 Jan 2022 20:16:35 +0100")
References: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
 <87ee5q6j8s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Sun, 2 Jan 2022 18:43:35 -0500
Message-ID: <CADwFkmm4UsmA=h_Ln+GZy72+bP7Z3N4avBn76nHoffQCNKz5kQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Daniel Jensen <daniel@HIDDEN> writes:

> I have assigned copyright to the FSF, yes. I wrote sv-kalender.el. Some
> of it was adapted from holiday code in Emacs at the time, but it was a
> long time ago and I don't recall any specifics -- it is not a copyright
> problem anyway. I don't mind at all having it included in Emacs.

Thanks for confirming this.  I have used this library for a very long
time, so I'm happy to see it getting mainlined.

> I'm glad you want to include it in Emacs. I'm sure some improvement is
> needed to have it match Emacs standards. Unfortunately I don't have the
> time to work on this project right now, but I wish you luck. Thank you!

I will mark myself as the maintainer if no one else is interested.  The
documentation will need to be translated to English (to the extent
possible), but maybe there are other things to clean up as well.

I will base this on the latest version at this URL:

    http://bigwalter.net/daniel/elisp/sv-kalender.el

It seems to incorporate some fixes from Arthur Miller.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs
References: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
In-Reply-To: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@HIDDEN>
Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 05 Jan 2022 09:55:02 +0000
Resent-Message-ID: <handler.52951.B52951.16413765017344 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 52951
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Daniel Jensen <daniel@HIDDEN>, 52951 <at> debbugs.gnu.org, Arthur Miller <arthur.miller@HIDDEN>
Received: via spool by 52951-submit <at> debbugs.gnu.org id=B52951.16413765017344
          (code B ref 52951); Wed, 05 Jan 2022 09:55:02 +0000
Received: (at 52951) by debbugs.gnu.org; 5 Jan 2022 09:55:01 +0000
Received: from localhost ([127.0.0.1]:39603 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n530W-0001uO-QV
	for submit <at> debbugs.gnu.org; Wed, 05 Jan 2022 04:55:01 -0500
Received: from mail1450c50.megamailservers.eu ([91.136.14.50]:54648
 helo=mail265c50.megamailservers.eu)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mattiase@HIDDEN>) id 1n530U-0001u4-1l
 for 52951 <at> debbugs.gnu.org; Wed, 05 Jan 2022 04:54:59 -0500
X-Authenticated-User: mattiase@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu;
 s=maildub; t=1641376486;
 bh=AE9dLLBtmJaUqUbnmzFsnpcGRWzZcW1TmGwE5rUh0ik=;
 h=From:Subject:Date:Cc:To:From;
 b=Q6x7dThx8H2cUKDkPCXGXRZM1DUYoK3AxOn0kKsgd2nRKuYLAjkiufXnHy3EQnjg6
 50ZljWPKq4L2C1HwRv9RmBlkO0M58Yw5cdl3UiSfQVmkSHQGpXK9ExYVedMnowRwLw
 GDlovjDdFNB5FPw7/R7KHkLwh6f6wd8BeyYUv7Yo=
Feedback-ID: mattiase@HIDDEN
Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se
 [188.150.171.71]) (authenticated bits=0)
 by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2059sic6015422; 
 Wed, 5 Jan 2022 09:54:45 +0000
From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Message-Id: <E46A0E93-A34A-41AE-8357-7C9048B3DECA@HIDDEN>
Date: Wed, 5 Jan 2022 10:54:43 +0100
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-CTCH-RefID: str=0001.0A742F28.61D56AE6.004F, ss=1, re=0.000, recu=0.000,
 reip=0.000, cl=1, cld=1, fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
X-CTCH-Score: 0.000
X-CTCH-Rules: 
X-CTCH-Flags: 0
X-CTCH-ScoreCust: 0.000
X-Origin-Country: SE
X-Spam-Score: 1.4 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: > http://bigwalter.net/daniel/elisp/sv-kalender.el Thank you!
 > (setq calendar-time-display-form > '(24-hours ":" minutes)) 
 Content analysis details:   (1.4 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.4 KHOP_HELO_FCRDNS       Relay HELO differs from its IP's reverse DNS
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

> http://bigwalter.net/daniel/elisp/sv-kalender.el

Thank you!

> (setq calendar-time-display-form
>       '(24-hours ":" minutes))

Standard Swedish style uses a dot as separator; the colon appears to =
have crept in as a fairly recent Anglicism (and I think it looks a bit =
tacky).

The file should also use lexical-binding: t.

> (eval-after-load "solar"

We should probably use `with-eval-after-load`.

>            (eval calendar-location-name)

Would `symbol-value` do instead of `eval` here?

>         '((if (fboundp 'atan)

I think we can assume the presence of `atan`.

>               (funcall 'holiday-sexp calendar-daylight-savings-starts

>           (funcall 'holiday-sexp calendar-daylight-savings-ends

Why the explicit `funcall`s? Is this a holiday code subtlety?

By the way, is there a way to do without the defadvice? They tend to be =
brittle.

Last modified: Wed, 5 Jan 2022 10:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.