GNU bug report logs - #52954
Rename split-string to string-split

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Sun, 2 Jan 2022 16:47:01 UTC

Severity: wishlist

Tags: wontfix

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52954 in the body.
You can then email your comments to 52954 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#52954; Package emacs. (Sun, 02 Jan 2022 16:47:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 02 Jan 2022 16:47:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Rename split-string to string-split
Date: Sun, 2 Jan 2022 11:46:37 -0500
Severity: wishlist

The function `split-string' does not follow use the `string-' prefix
that we use for many other string functions.  How about renaming it and
introducing an alias for the old name?

IOW, basically the below and the necessary documentation fixes and so
on:

diff --git a/lisp/subr.el b/lisp/subr.el
index 11105c4aa6..a9bd406b63 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -4890,7 +4890,7 @@ split-string-default-separators
 ;; defaulted, OMIT-NULLS should be treated as t.  Simplifying the logical
 ;; expression leads to the equivalent implementation that if SEPARATORS
 ;; is defaulted, OMIT-NULLS is treated as t.
-(defun split-string (string &optional separators omit-nulls trim)
+(defun string-split (string &optional separators omit-nulls trim)
   "Split STRING into substrings bounded by matches for SEPARATORS.

 The beginning and end of STRING, and each match for SEPARATORS, are
@@ -4969,6 +4969,7 @@ split-string
     (funcall push-one)

     (nreverse list)))
+(defalias 'split-string #'string-split) ; renamed in 29.1

 (defun combine-and-quote-strings (strings &optional separator)
   "Concatenate the STRINGS, adding the SEPARATOR (default \" \").




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52954; Package emacs. (Fri, 14 Jan 2022 09:10:02 GMT) Full text and rfc822 format available.

Message #8 received at 52954 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52954 <at> debbugs.gnu.org
Subject: Re: bug#52954: Rename split-string to string-split
Date: Fri, 14 Jan 2022 10:09:08 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

> The function `split-string' does not follow use the `string-' prefix
> that we use for many other string functions.  How about renaming it and
> introducing an alias for the old name?

We've got a whole bunch of functions that are
`something-something-string', and I'd rather not rename them all.  So
I'm leaning towards "no" (because having several names for functions
that are commonly used makes reading code more of a chore), and I'm
therefore closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) wontfix. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 14 Jan 2022 09:10:03 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 52954 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 14 Jan 2022 09:10:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52954; Package emacs. (Fri, 14 Jan 2022 09:44:02 GMT) Full text and rfc822 format available.

Message #15 received at 52954 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52954 <at> debbugs.gnu.org
Subject: Re: bug#52954: Rename split-string to string-split
Date: Fri, 14 Jan 2022 01:43:09 -0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> We've got a whole bunch of functions that are
> `something-something-string', and I'd rather not rename them all.  So
> I'm leaning towards "no" (because having several names for functions
> that are commonly used makes reading code more of a chore), and I'm
> therefore closing this bug report.

Fair enough.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 11 Feb 2022 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 47 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.