GNU bug report logs - #52971
Tests warn after eieio-compat.el was moved to obsolete/

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52971 in the body.
You can then email your comments to 52971 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Tests warn after eieio-compat.el was moved to obsolete/
Date: Sun, 2 Jan 2022 20:29:52 -0500

> branch: master
> commit d65534d254b3965ea82a9300c12c5c07f88818b7
> Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Commit: Stefan Monnier <monnier <at> iro.umontreal.ca>
>
>     * lisp/emacs-list/eieio-compat.el: Really move to obsolete

After this or some other recent and related commit, we get these
warnings:

  In toplevel form:
  lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:58:1:
Warning: Package eieio-compat is deprecated
    GEN      lisp/emacs-lisp/ert-x-tests.log

  In toplevel form:
  lisp/emacs-lisp/eieio-tests/eieio-tests.el:30:1: Warning: Package
eieio-compat is deprecated

I'm not sure about the best way to fix them.  Could we just move those
parts that require eieio-compat.el to a new file eieio-compat-tests.el?

I will silence these warnings using `with-no-warnings' for now, and we
can track progress on this here instead.

Message #8 received at 52971 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52971 <at> debbugs.gnu.org
Subject: Re: bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
Date: Sun, 02 Jan 2022 23:22:21 -0500

> I'm not sure about the best way to fix them.  Could we just move those
> parts that require eieio-compat.el to a new file eieio-compat-tests.el?

That will just move the warnings.

> I will silence these warnings using `with-no-warnings' for now,

Sounds good.

> and we can track progress on this here instead.

Thanks,


        Stefan

Message #11 received at 52971 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 52971 <at> debbugs.gnu.org
Subject: Re: bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
Date: Mon, 3 Jan 2022 11:48:51 -0500

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> I'm not sure about the best way to fix them.  Could we just move those
>> parts that require eieio-compat.el to a new file eieio-compat-tests.el?
>
> That will just move the warnings.

My thinking was that if these tests are only for obsolete code, it would
be better to isolate them all in one file.  But I have no real opinion
either way.

Message #14 received at 52971 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52971 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
Date: Fri, 14 Jan 2022 09:59:32 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>>> I'm not sure about the best way to fix them.  Could we just move those
>>> parts that require eieio-compat.el to a new file eieio-compat-tests.el?
>>
>> That will just move the warnings.
>
> My thinking was that if these tests are only for obsolete code, it would
> be better to isolate them all in one file.  But I have no real opinion
> either way.

I think isolating them in a new test file makes sense -- makes things
clearer.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.