GNU bug report logs - #52978
Add doc string indices to easy-mmode macros

Previous Next

Package: emacs;

Reported by: Ivan Sokolov <ivan-p-sokolov <at> ya.ru>

Date: Mon, 3 Jan 2022 14:34:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52978 in the body.
You can then email your comments to 52978 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#52978; Package emacs. (Mon, 03 Jan 2022 14:34:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ivan Sokolov <ivan-p-sokolov <at> ya.ru>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 03 Jan 2022 14:34:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Sokolov <ivan-p-sokolov <at> ya.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: Add doc string indices to easy-mmode macros
Date: Mon, 03 Jan 2022 17:33:13 +0300
[Message part 1 (text/plain, inline)]
Subj.

[0001-Add-doc-string-indices-to-easy-mmode-defmap-and-easy.patch (text/x-patch, inline)]
From 3004d0b94127e2af023345943c56a36787deabe6 Mon Sep 17 00:00:00 2001
From: Ivan Sokolov <ivan-p-sokolov <at> ya.ru>
Date: Mon, 3 Jan 2022 17:21:55 +0300
Subject: [PATCH] Add doc string indices to easy-mmode-defmap and
 easy-mmode-defsyntax

---
 lisp/emacs-lisp/easy-mmode.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 2d95e91833..cf3ea8c3dd 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -697,7 +697,7 @@ easy-mmode-defmap
   "Define a constant M whose value is the result of `easy-mmode-define-keymap'.
 The M, BS, and ARGS arguments are as per that function.  DOC is
 the constant's documentation."
-  (declare (indent 1))
+  (declare (doc-string 3) (indent 1))
   `(defconst ,m
      (easy-mmode-define-keymap ,bs nil (if (boundp ',m) ,m) ,(cons 'list args))
      ,doc))
@@ -724,7 +724,7 @@ easy-mmode-define-syntax
 (defmacro easy-mmode-defsyntax (st css doc &rest args)
   "Define variable ST as a syntax-table.
 CSS contains a list of syntax specifications of the form (CHAR . SYNTAX)."
-  (declare (indent 1))
+  (declare (doc-string 3) (indent 1))
   `(progn
      (autoload 'easy-mmode-define-syntax "easy-mmode")
      (defconst ,st (easy-mmode-define-syntax ,css ,(cons 'list args)) ,doc)))
-- 
2.34.1


Added tag(s) patch. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 09 Jan 2022 15:32:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#52978; Package emacs. (Sun, 09 Jan 2022 15:46:01 GMT) Full text and rfc822 format available.

Message #10 received at 52978 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Ivan Sokolov <ivan-p-sokolov <at> ya.ru>
Cc: 52978 <at> debbugs.gnu.org
Subject: Re: bug#52978: Add doc string indices to easy-mmode macros
Date: Sun, 9 Jan 2022 09:45:44 -0600
close 52978 29.1
thanks

Ivan Sokolov <ivan-p-sokolov <at> ya.ru> writes:

> From 3004d0b94127e2af023345943c56a36787deabe6 Mon Sep 17 00:00:00 2001
> From: Ivan Sokolov <ivan-p-sokolov <at> ya.ru>
> Date: Mon, 3 Jan 2022 17:21:55 +0300
> Subject: [PATCH] Add doc string indices to easy-mmode-defmap and
>  easy-mmode-defsyntax

Thanks for the patch!  I've fixed up the commit message and pushed it to
master as commit 4509095d79.




bug marked as fixed in version 29.1, send any further explanations to 52978 <at> debbugs.gnu.org and Ivan Sokolov <ivan-p-sokolov <at> ya.ru> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 09 Jan 2022 15:46:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 07 Feb 2022 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 72 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.