GNU bug report logs - #52991
[PATCH] gnu: Add python-astral

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52991 in the body.
You can then email your comments to 52991 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Disseminate Dissent <disseminatedissent <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add python-astral
Date: Mon, 03 Jan 2022 23:22:49 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-Add-python-astral.patch (text/x-patch, attachment)]

Message #8 received at 52991 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Disseminate Dissent <disseminatedissent <at> protonmail.com>, 
 52991 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add python-astral
Date: Tue, 04 Jan 2022 03:08:03 +0000

Hello,

> ;; FIXME The directory '/homeless-shelter/.cache/pip' or its parent
> directory is not owned or is not writable by the current user. The
> cache has been disabled. Check the permissions and owner of that
> directory. If executing pip with sudo, you should use sudo's -H flag.

This can be fixed by overriding the check phase and calling pytest
manually:

>     (arguments
>      `(#:phases
>        (modify-phases %standard-phases
>          (replace 'check
>            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
>              (when tests?
>                (add-installed-pythonpath inputs outputs)
>                (invoke "python" "-m" "pytest")))))))

I also adjusted the inputs as:

>     (native-inputs
>      (list python-freezegun python-setuptools-scm))
>     (propagated-inputs
>      (list python-dataclasses python-pytest python-pytz))

When the package is a module, all runtime inputs should be propagated.
I also removed python-requests since it was not being used.

> +   (description "This is @code{astral} a Python module which
> calculates times
> + for various positions of the sun: dawn, sunrise, solar noon,
> sunset, dusk,
> +solar elevation, solar azimuth, rahukaalam, and the phases of the
> moon.")

I'd reword it starting with "@code{astral} is a Python module ..."

The indentation is also off. If you're using Emacs you can use one of
its indent commands to fix it.

Could you send a v2 with these changes?

Message #11 received at 52991 <at> debbugs.gnu.org (full text, mbox):

From: Disseminate Dissent <disseminatedissent <at> protonmail.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 52991 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add python-astral
Date: Tue, 04 Jan 2022 15:50:51 +0000

[Message part 1 (text/plain, inline)]

Herein are the v2 changes.

Disseminate,
Peace


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, January 4th, 2022 at 3:08 AM, Vinicius Monego <monego <at> posteo.net> wrote:

> Hello,
>
> > ;; FIXME The directory '/homeless-shelter/.cache/pip' or its parent
> >
> > directory is not owned or is not writable by the current user. The
> >
> > cache has been disabled. Check the permissions and owner of that
> >
> > directory. If executing pip with sudo, you should use sudo's -H flag.
>
> This can be fixed by overriding the check phase and calling pytest
>
> manually:
>
> >     (arguments
> >      `(#:phases
> >        (modify-phases %standard-phases
> >          (replace 'check
> >            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> >              (when tests?
> >                (add-installed-pythonpath inputs outputs)
> >                (invoke "python" "-m" "pytest")))))))
> >
>
> I also adjusted the inputs as:
>
> >     (native-inputs
> >      (list python-freezegun python-setuptools-scm))
> >     (propagated-inputs
> >      (list python-dataclasses python-pytest python-pytz))
> >
>
> When the package is a module, all runtime inputs should be propagated.
>
> I also removed python-requests since it was not being used.
>
> > -   (description "This is @code{astral} a Python module which
> >
> >     calculates times
> > -   for various positions of the sun: dawn, sunrise, solar noon,
> >
> >     sunset, dusk,
> >
> >     +solar elevation, solar azimuth, rahukaalam, and the phases of the
> >
> >     moon.")
>
> I'd reword it starting with "@code{astral} is a Python module ..."
>
> The indentation is also off. If you're using Emacs you can use one of
>
> its indent commands to fix it.
>
> Could you send a v2 with these changes?

[0002-gnu-Add-python-astral.patch (text/x-patch, attachment)]

Message #16 received at 52991-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Disseminate Dissent <disseminatedissent <at> protonmail.com>
Cc: 52991-done <at> debbugs.gnu.org, Vinicius Monego <monego <at> posteo.net>
Subject: Re: bug#52991: [PATCH] gnu: Add python-astral
Date: Sat, 08 Jan 2022 23:23:26 +0100

[Message part 1 (text/plain, inline)]

Hi,

Disseminate Dissent <disseminatedissent <at> protonmail.com> skribis:

> From edf40f038e037f891bc3aaede0015da064f4c0bb Mon Sep 17 00:00:00 2001
> From: paladhammika <paladhammika <at> protonmail.com>
> Date: Tue, 4 Jan 2022 10:42:24 -0500
> Subject: [PATCH] gnu: Add python=astral.
>
> ---
>  gnu/packages/astronomy.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)

Applied with the minor tweak below plus a commit log.

Thank you, and thanks Vinicius for reviewing!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 88966d7ecc..a7a07fa3a8 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -730,9 +730,9 @@ (define-public python-astral
      (list python-dataclasses python-pytest python-pytz))
     (home-page "https://github.com/sffjunkie/astral")
     (synopsis "Calculations for the position of the sun and moon")
-   (description "@code{Astral} a Python module which calculates times
- for various positions of the sun: dawn, sunrise, solar noon, sunset, dusk,
-solar elevation, solar azimuth, rahukaalam, and the phases of the moon.")
+    (description "Astral is a Python module that calculates times for various
+positions of the sun: dawn, sunrise, solar noon, sunset, dusk, solar
+elevation, solar azimuth, rahukaalam, and the phases of the moon.")
     (license license:asl2.0)))
 
 (define-public libnova

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.