GNU bug report logs - #53007
[PATCH] gnu: networking: Add arp-scan

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53007 in the body.
You can then email your comments to 53007 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: guix-patches <at> gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: [PATCH] gnu: networking: Add arp-scan
Date: Tue,  4 Jan 2022 17:34:15 +0200

From: Manolis Ragkousis <manolis837 <at> gmail.com>

* gnu/packages/networking.scm (arp-scan): New variable.
---
 gnu/packages/networking.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index cc9cc61164..ac67d58541 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2021 Milkey Mouse <milkeymouse <at> meme.institute>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
+;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4143,3 +4144,32 @@ (define-public putty
 implementations.")
     (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
     (license license:expat)))
+
+(define-public arp-scan
+  (package
+    (name "arp-scan")
+    (version "1.9.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/royhills/arp-scan/"
+                           "archive/refs/tags/" version ".tar.gz"))
+       (sha256
+        (base32 "0ff0c43rw1b4cm52rx7s6q0wsix3ahjjfhd8wk85nr9wjgj3cg70"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'bootstrap
+           (lambda _
+             (invoke "autoreconf" "-vfi"))))))
+    (inputs
+     (list libpcap))
+    (native-inputs
+     (list autoconf automake libtool pkg-config))
+    (propagated-inputs
+     (list perl-libwww))
+    (home-page "https://github.com/royhills/arp-scan")
+    (synopsis "Dscover and fingerprint IP hosts on the local network using ARP")
+    (description "A tool that uses ARP to discover and fingerprint IP hosts on the local network")
+    (license license:gpl3)))
-- 
2.33.1

Message #8 received at 53007 <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: 53007 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: networking: Add arp-scan
Date: Tue, 4 Jan 2022 17:40:12 +0200

[Message part 1 (text/plain, inline)]

This is the correct version. :)

On Tue, 4 Jan 2022, 17:34 , <manolis837 <at> gmail.com> wrote:

> From: Manolis Ragkousis <manolis837 <at> gmail.com>
>
> * gnu/packages/networking.scm (arp-scan): New variable.
> ---
>  gnu/packages/networking.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index cc9cc61164..ac67d58541 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -47,6 +47,7 @@
>  ;;; Copyright © 2021 Milkey Mouse <milkeymouse <at> meme.institute>
>  ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
>  ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
> +;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4143,3 +4144,32 @@ (define-public putty
>  implementations.")
>      (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
>      (license license:expat)))
> +
> +(define-public arp-scan
> +  (package
> +    (name "arp-scan")
> +    (version "1.9.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/royhills/arp-scan/"
> +                           "archive/refs/tags/" version ".tar.gz"))
> +       (sha256
> +        (base32 "0ff0c43rw1b4cm52rx7s6q0wsix3ahjjfhd8wk85nr9wjgj3cg70"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'bootstrap
> +           (lambda _
> +             (invoke "autoreconf" "-vfi"))))))
> +    (inputs
> +     (list libpcap))
> +    (native-inputs
> +     (list autoconf automake libtool pkg-config))
> +    (propagated-inputs
> +     (list perl-libwww))
> +    (home-page "https://github.com/royhills/arp-scan")
> +    (synopsis "Dscover and fingerprint IP hosts on the local network
> using ARP")
> +    (description "A tool that uses ARP to discover and fingerprint IP
> hosts on the local network")
> +    (license license:gpl3)))
> --
> 2.33.1
>
>

[Message part 2 (text/html, inline)]

Message #11 received at 53007 <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: 53007 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: networking: Add arp-scan
Date: Thu, 6 Jan 2022 13:18:23 +0200

Did anyone have some time to check this?

On 1/4/22 17:40, Manolis Ragkousis wrote:
> This is the correct version. :)
> 
> On Tue, 4 Jan 2022, 17:34 , <manolis837 <at> gmail.com 
> <mailto:manolis837 <at> gmail.com>> wrote:
> 
>     From: Manolis Ragkousis <manolis837 <at> gmail.com
>     <mailto:manolis837 <at> gmail.com>>
> 
>     * gnu/packages/networking.scm (arp-scan): New variable.
>     ---
>       gnu/packages/networking.scm | 30 ++++++++++++++++++++++++++++++
>       1 file changed, 30 insertions(+)
> 
>     diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
>     index cc9cc61164..ac67d58541 100644
>     --- a/gnu/packages/networking.scm
>     +++ b/gnu/packages/networking.scm
>     @@ -47,6 +47,7 @@
>       ;;; Copyright © 2021 Milkey Mouse <milkeymouse <at> meme.institute>
>       ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net
>     <mailto:glv <at> posteo.net>>
>       ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be
>     <mailto:maximedevos <at> telenet.be>>
>     +;;; Copyright © 2022 Manolis Fragkiskos Ragkousis
>     <manolis837 <at> gmail.com <mailto:manolis837 <at> gmail.com>>
>       ;;;
>       ;;; This file is part of GNU Guix.
>       ;;;
>     @@ -4143,3 +4144,32 @@ (define-public putty
>       implementations.")
>           (home-page
>     "https://www.chiark.greenend.org.uk/~sgtatham/putty/
>     <https://www.chiark.greenend.org.uk/~sgtatham/putty/>")
>           (license license:expat)))
>     +
>     +(define-public arp-scan
>     +  (package
>     +    (name "arp-scan")
>     +    (version "1.9.7")
>     +    (source
>     +     (origin
>     +       (method url-fetch)
>     +       (uri (string-append "https://github.com/royhills/arp-scan/
>     <https://github.com/royhills/arp-scan/>"
>     +                           "archive/refs/tags/" version ".tar.gz"))
>     +       (sha256
>     +        (base32
>     "0ff0c43rw1b4cm52rx7s6q0wsix3ahjjfhd8wk85nr9wjgj3cg70"))))
>     +    (build-system gnu-build-system)
>     +    (arguments
>     +     `(#:phases
>     +       (modify-phases %standard-phases
>     +         (replace 'bootstrap
>     +           (lambda _
>     +             (invoke "autoreconf" "-vfi"))))))
>     +    (inputs
>     +     (list libpcap))
>     +    (native-inputs
>     +     (list autoconf automake libtool pkg-config))
>     +    (propagated-inputs
>     +     (list perl-libwww))
>     +    (home-page "https://github.com/royhills/arp-scan
>     <https://github.com/royhills/arp-scan>")
>     +    (synopsis "Dscover and fingerprint IP hosts on the local
>     network using ARP")
>     +    (description "A tool that uses ARP to discover and fingerprint
>     IP hosts on the local network")
>     +    (license license:gpl3)))
>     -- 
>     2.33.1
> 

Message #14 received at 53007 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: manolis837 <at> gmail.com
Cc: 53007 <at> debbugs.gnu.org
Subject: Re: [bug#53007] [PATCH] gnu: networking: Add arp-scan
Date: Tue, 11 Jan 2022 13:54:18 -0500

Thanks for the patch!

On Tue, Jan 04, 2022 at 05:34:15PM +0200, manolis837 <at> gmail.com wrote:
> +    (version "1.9.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/royhills/arp-scan/"
> +                           "archive/refs/tags/" version ".tar.gz"))

This type of tarball is automatically generated by Git / Github based on
the Git tag. However, whenever Github updates their software, the
generated tarballs may change, invalidating our hash. [0]

For that reason, we either use tarballs created by the upstream
developers, or the git-fetch method. For this program, the developers
stopped making tarballs after version 1.9, so we have to use git-fetch
to package 1.9.7.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'bootstrap
> +           (lambda _
> +             (invoke "autoreconf" "-vfi"))))))

The bootstrap phase of gnu-build-system runs autoreconf when 'configure'
is missing. I'm guessing this package was written before
gnu-build-system learned to do that, because the package does build
successfully without this replacement.

> +    (inputs
> +     (list libpcap))
> +    (native-inputs
> +     (list autoconf automake libtool pkg-config))
> +    (propagated-inputs
> +     (list perl-libwww))
> +    (home-page "https://github.com/royhills/arp-scan")
> +    (synopsis "Dscover and fingerprint IP hosts on the local network using ARP")
                  ^
Typo here --------|

> +    (description "A tool that uses ARP to discover and fingerprint IP hosts on the local network")

Descriptions should be written in "complete" sentences. How about the
following?

"Arp-scan is a tool that uses ARP to discover and fingerprint IP hosts
on the local network."

> +    (license license:gpl3)))

The source headers of 'arp-scan.c' say that the program can be
distributed "either version 3 of the License, or (at your option) any
later version." So I think it's gpl3+.

Can you send a revised patch?

[0] https://github.com/libgit2/libgit2/issues/4343

Message #19 received at 53007 <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: 53007 <at> debbugs.gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: [PATCH] gnu: networking: Add arp-scan
Date: Tue, 21 Jun 2022 00:41:29 +0300

From: Manolis Ragkousis <manolis837 <at> gmail.com>

* gnu/packages/networking.scm (arp-scan): New variable.
---
 gnu/packages/networking.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 065a190321..cb384f23bb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Simon South <simon <at> simonsouth.net>
 ;;; Copyright © 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
+;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4259,3 +4260,31 @@ (define-public putty
 implementations.")
     (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/")
     (license license:expat)))
+
+(define-public arp-scan
+  (package
+    (name "arp-scan")
+    (version "1.9.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/royhills/arp-scan/")
+         (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1mf7a4f9vzvnkiavc87aqyciswggsb4fpy7j05jxnvjyyxv3l7gp"))))
+    (build-system gnu-build-system)
+    (inputs
+     (list libpcap))
+    (native-inputs
+     (list autoconf automake libtool pkg-config))
+    (propagated-inputs
+     (list perl-libwww))
+    (home-page "https://github.com/royhills/arp-scan")
+    (synopsis "Discover and fingerprint IP hosts on the local network
+ using ARP")
+    (description "Arp-scan is a tool that uses ARP to discover and fingerprint IP hosts
+on the local network.")
+    (license license:gpl3+)))
-- 
2.33.1

Message #24 received at 53007-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: manolis837 <at> gmail.com
Cc: 53007-done <at> debbugs.gnu.org
Subject: Re: [bug#53007] [PATCH] gnu: networking: Add arp-scan
Date: Tue, 21 Jun 2022 12:41:08 +0100

[Message part 1 (text/plain, inline)]

manolis837 <at> gmail.com writes:

> From: Manolis Ragkousis <manolis837 <at> gmail.com>
>
> * gnu/packages/networking.scm (arp-scan): New variable.
> ---
>  gnu/packages/networking.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

I moved this new package off the bottom of the file, and pushed this as
0fe0c739f53bbb635eb5c4a3b172f4be45293c82.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 53007 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: <manolis837 <at> gmail.com>, <53007 <at> debbugs.gnu.org>
Subject: Re: [bug#53007] [PATCH] gnu: networking: Add arp-scan
Date: Sat, 25 Jun 2022 11:37:07 +0100

LGTM. I was going to raise the point that 1.9.7 was in 2019, and the
latest commit at the time of writing was made on 2022-06-16, but it
looks like there's not been too many commits between 7f88dc0 "Increment
version to 1.9.7 in preparation for next release." and 840373f "Updated
changelog and IEEE IAB and OUI files."

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.