GNU bug report logs - #53039
[PATCH] build-system/python: Change let* to let.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53039 in the body.
You can then email your comments to 53039 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] build-system/python: Change let* to let.
Date: Wed,  5 Jan 2022 17:46:00 -0500

* guix/build/python-build-system.scm (site-packages): Change let* to let for
readability and since let* is unused.
---
 guix/build/python-build-system.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 08871f60cd..a9b1c74f63 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2021 Lars-Dominik Braun <lars <at> 6xq.net>
 ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -176,8 +177,8 @@ (define (python-output outputs)
 
 (define (site-packages inputs outputs)
   "Return the path of the current output's Python site-package."
-  (let* ((out (python-output outputs))
-         (python (assoc-ref inputs "python")))
+  (let ((out (python-output outputs))
+        (python (assoc-ref inputs "python")))
     (string-append out "/lib/python" (python-version python) "/site-packages")))
 
 (define (add-installed-pythonpath inputs outputs)
-- 
2.34.1

Message #8 received at 53039 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 53039 <at> debbugs.gnu.org
Subject: Re: [PATCH] build-system/python: Change let* to let.
Date: Sun, 09 Jan 2022 22:03:31 +0100

[Message part 1 (text/plain, inline)]

retitle [PATCH core-updates-frozen] build-system-python: Change let* to let.
thanks

>[python-build-system.scm]
> -  (let* ((out (python-output outputs))
> -         (python (assoc-ref inputs "python")))
> +  (let ((out (python-output outputs))
> +        (python (assoc-ref inputs "python")))

According to "guix refresh -l python-six", this would rebuild a lot
(at least 3122), so this would need to be done on core-updates.  Seems
ok otherwise.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 53039-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 53039-done <at> debbugs.gnu.org
Subject: Re: bug#53039: [PATCH] build-system/python: Change let* to let.
Date: Wed, 18 May 2022 09:06:58 -0400

Hi,

jgart <jgart <at> dismail.de> writes:

> * guix/build/python-build-system.scm (site-packages): Change let* to let for
> readability and since let* is unused.
> ---
>  guix/build/python-build-system.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 08871f60cd..a9b1c74f63 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -11,6 +11,7 @@
>  ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2021 Lars-Dominik Braun <lars <at> 6xq.net>
>  ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
> +;;; Copyright © 2022 jgart <jgart <at> dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -176,8 +177,8 @@ (define (python-output outputs)
>  
>  (define (site-packages inputs outputs)
>    "Return the path of the current output's Python site-package."
> -  (let* ((out (python-output outputs))
> -         (python (assoc-ref inputs "python")))
> +  (let ((out (python-output outputs))
> +        (python (assoc-ref inputs "python")))
>      (string-append out "/lib/python" (python-version python) "/site-packages")))
>  
>  (define (add-installed-pythonpath inputs outputs)

As Maxime mentioned, that should go to core-updates.  It's nice to use
the --subject-prefix option of 'git format-patch' to change it to
"[PATCH core-updates]", so that we don't apply these mistakenly to
master and cause world rebuilds :-)

Another note; only changes of minimally 10 lines are copyrightable, so
you do not need to add a copyright attribution for trivial changes such
as this one.

I've made the change to core-updates and committed as 47fac5dc59; closing.

Thank you!

Maxim

Message #16 received at 53039-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 53039-done <at> debbugs.gnu.org
Subject: Re: bug#53039: [PATCH] build-system/python: Change let* to let.
Date: Wed, 18 May 2022 23:50:56 -0500

On Wed, 18 May 2022 09:06:58 -0400 Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
> I've made the change to core-updates and committed as 47fac5dc59; closing.

Hi Maxim,

Thank you for doing that. Sorry, I couldn't get to it. I've been in the
onboarding process of starting a new job and moving to a new city and
have been really busy.

Hope to get some free time soon to continue contributing to Guix :)

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.