GNU bug report logs - #53046
[PATCH] gnu: python-args: Patch reference to basestring.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Tanguy Le Carrour <tanguy@HIDDEN>; Keywords: patch; dated Thu, 6 Jan 2022 10:22:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 53046 <at> debbugs.gnu.org:


Received: (at 53046) by debbugs.gnu.org; 9 Jan 2022 21:15:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 09 16:15:50 2022
Received: from localhost ([127.0.0.1]:51452 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n6fXa-0003BW-Ip
	for submit <at> debbugs.gnu.org; Sun, 09 Jan 2022 16:15:50 -0500
Received: from xavier.telenet-ops.be ([195.130.132.52]:53712)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1n6fXY-00038D-OB
 for 53046 <at> debbugs.gnu.org; Sun, 09 Jan 2022 16:15:49 -0500
Received: from [172.20.10.5] ([188.188.14.77])
 by xavier.telenet-ops.be with bizsmtp
 id glFm260031flEHY01lFmxe; Sun, 09 Jan 2022 22:15:47 +0100
Message-ID: <afcb97725c297693a58d707f78184a39aa32c433.camel@HIDDEN>
Subject: Re: bug#53046: [PATCH] gnu: python-args: Patch reference to
 basestring.
From: Maxime Devos <maximedevos@HIDDEN>
To: tanguy@HIDDEN
Date: Sun, 09 Jan 2022 22:15:41 +0100
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-3/t5NFJMIbwN/+jghKHM"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1641762947; bh=5KIDN63UKSVApotgiy8NortxQW+n50J7UFVsrtKyGKo=;
 h=Subject:From:To:Cc:Date;
 b=C1F+mcmHJ66S5ndRfoCOIWbF91kCQo9H3rWt2BzR6ko68rwyC/tOv0gCfpEW2ABa2
 laVIEo8PInemU+UJ3XNv9D876kAlbTmYwMMzbRqYujPEzaNCfH1A8du8Jm3Xa4QahU
 szWTLaW5R4Og5+D1555Vsxl3Sx4GtWk4P5nSwJmTJ529+Cj1s7ZjtAYc5x1y44uf9o
 IqafXImei/yENZhVlwNeQfkK3wobA0b3hBwzKwB94iOui+P/4QP2VjqfjenNxmyC2z
 U0kTnNW4UeUgqDw41PgIisHPsbB1P1WPn+dD0jcZD72y9kNnfjZIJCt9mHWE/QiIrz
 1n2go8KNTno2g==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 53046
Cc: 53046 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--=-3/t5NFJMIbwN/+jghKHM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> This fixes a build failure in the 'sanity-check' phase.
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 (substitute* "args.py"
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 (("basestring") "str"))

Does it actually fix the build failure, or is it only suppressed?

Looking at

<https://github.com/kennethreitz-archive/args/blob/master/args.py>,
line 15--18, it appears that basestring should actually be basestring,
at least for Python 2 (python2-args).

Also, returning #true isn't necessary anymore, and this seems better
fit for a snippet.

Greetings,
Maxime.

--=-3/t5NFJMIbwN/+jghKHM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYdtQfRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7o9xAQCohfk76g+CXDBjHwLj3c8y1vAB
5d3zE3aFDRTtAR2PfgEA7mphFe1Zc3Zov6kKjGbBC9oKNeyDynvODvHK1ynG0g4=
=PPCx
-----END PGP SIGNATURE-----

--=-3/t5NFJMIbwN/+jghKHM--





Information forwarded to guix-patches@HIDDEN:
bug#53046; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Jan 2022 10:21:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 06 05:21:56 2022
Received: from localhost ([127.0.0.1]:39713 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n5Pu7-0002IE-Qk
	for submit <at> debbugs.gnu.org; Thu, 06 Jan 2022 05:21:55 -0500
Received: from lists.gnu.org ([209.51.188.17]:45332)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <tanguy@HIDDEN>) id 1n5Pu4-0002I3-Fs
 for submit <at> debbugs.gnu.org; Thu, 06 Jan 2022 05:21:54 -0500
Received: from eggs.gnu.org ([209.51.188.92]:56166)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tanguy@HIDDEN>)
 id 1n5Pu4-00008S-9s
 for guix-patches@HIDDEN; Thu, 06 Jan 2022 05:21:52 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:49213)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <tanguy@HIDDEN>)
 id 1n5Ptn-0000Oy-9S
 for guix-patches@HIDDEN; Thu, 06 Jan 2022 05:21:38 -0500
Received: (Authenticated sender: tanguy@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 0FE3A1BF21B;
 Thu,  6 Jan 2022 10:21:30 +0000 (UTC)
From: Tanguy Le Carrour <tanguy@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: python-args: Patch reference to basestring.
Date: Thu,  6 Jan 2022 11:21:02 +0100
Message-Id: <20220106102102.22512-1-tanguy@HIDDEN>
X-Mailer: git-send-email 2.34.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: none client-ip=217.70.183.201; envelope-from=tanguy@HIDDEN;
 helo=relay8-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: Tanguy Le Carrour <tanguy@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

This fixes a build failure in the 'sanity-check' phase.

* gnu/packages/python-xyz.scm (python-args)[arguments]:
Replace reference to basestring with str.
---
 gnu/packages/python-xyz.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c9a0b7d6bf..0d9bfb1711 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -13013,6 +13013,14 @@ (define-public python-args
                (base32
                 "057qzi46h5dmxdqknsbrssn78lmqjlnm624iqdhrnpk26zcbi1d7"))))
     (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-args.py
+           (lambda _
+             (substitute* "args.py"
+               (("basestring") "str"))
+             #t)))))
     (home-page "https://github.com/kennethreitz/args")
     (synopsis "Command-line argument parser")
     (description
-- 
2.34.0





Acknowledgement sent to Tanguy Le Carrour <tanguy@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#53046; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 9 Jan 2022 21:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.