GNU bug report logs - #53049
[PATCH] gnu: libaio: Fix cross-compilation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53049 in the body.
You can then email your comments to 53049 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libaio: Fix cross-compilation.
Date: Thu, 6 Jan 2022 12:30:30 +0100

[Message part 1 (text/plain, inline)]

Hi Guix!

I saw a message on the unofficial #guix:matrix.org room about libaio
failing to build. Indeed, it uses %output and that doesn't exist in
cross-compilation context anymore. Here's a small patch to fix that. I
had to be careful not to change the package outside of
cross-compilation, since it has >5000 dependents, hence the ,(if ...)
statement.

[0001-gnu-libaio-Fix-cross-compilation.patch (text/x-patch, attachment)]

Message #8 received at 53049 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 53049 <at> debbugs.gnu.org
Subject: Re: bug#53049: [PATCH] gnu: libaio: Fix cross-compilation.
Date: Sat, 08 Jan 2022 22:57:10 +0100

Hi,

Julien Lepiller <julien <at> lepiller.eu> skribis:

>>From 160572309d022b4249cb41296864a0e1c32eae0a Mon Sep 17 00:00:00 2001
> Message-Id: <160572309d022b4249cb41296864a0e1c32eae0a.1641468451.git.julien <at> lepiller.eu>
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Thu, 6 Jan 2022 11:48:16 +0100
> Subject: [PATCH] gnu: libaio: Fix cross-compilation.
>
> * gnu/packages/linux.scm (libaio)[arguments]: Do not use singular
> %output.

LGTM!  (You could add a TODO stating it should be homogenized on the
next rebuild cycle.)

Thanks,
Ludo’.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>, guix-patches <at> gnu.org,
 53049-done <at> debbugs.gnu.org
Subject: Re: [bug#53049] [PATCH] gnu: libaio: Fix cross-compilation.
Date: Sat, 08 Jan 2022 23:14:03 +0100

[Message part 1 (text/plain, inline)]

Hi,

Julien Lepiller wrote:
> Subject: [PATCH] gnu: libaio: Fix cross-compilation.

I pushed a series of cross-compilation fixes yesterday night to 
fix the pinebook-pro image build ASAP.

It was pretty bad: there was no valid CI build, so the 
guix.gnu.org ‘Download’ was just… broken.  I didn't notice your 
patch.

Mine looks slightly different (preferring as I do shiny gexps, and 
trying to move away from %output{s,} :-) but the thrust is the 
same, comment included.

Thanks! and closing,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 53049 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: me <at> tobias.gr
Cc: julien <at> lepiller.eu, 53049 <at> debbugs.gnu.org
Subject: Re: bug#53049: [PATCH] gnu: libaio: Fix cross-compilation.
Date: Sun, 09 Jan 2022 10:43:08 +0100

Hello Tobias,

> It was pretty bad: there was no valid CI build, so the guix.gnu.org ‘Download’
> was just… broken.  I didn't notice your patch.
>
> Mine looks slightly different (preferring as I do shiny gexps, and trying to
> move away from %output{s,} :-) but the thrust is the same, comment included.

We now have 100% coverage on the "images" specifications[1], thanks for
fixing that :).

Mathieu

[1]: https://ci.guix.gnu.org/jobset/images

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.