GNU bug report logs - #53054
[PATCH 0/3] gnu: poetry: Fix package inputs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53054 in the body.
You can then email your comments to 53054 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: guix-patches <at> gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 0/3] gnu: poetry: Fix package inputs.
Date: Thu,  6 Jan 2022 14:59:59 +0100

Tanguy Le Carrour (3):
  gnu: python-os-testr: Add python-testrepository to inputs.
  gnu: poetry: Fix package inputs.
  gnu: python-msgpack-transitional: Remove unused variable.

 gnu/packages/openstack.scm  |  3 ++-
 gnu/packages/python-xyz.scm | 31 +++----------------------------
 2 files changed, 5 insertions(+), 29 deletions(-)

-- 
2.34.0

Message #8 received at 53054 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 53054 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 1/3] gnu: python-os-testr: Add python-testrepository to inputs.
Date: Thu,  6 Jan 2022 15:33:57 +0100

This fixes a build failure in the 'sanity-check' phase.

* gnu/packages/openstack.scm (python-os-testr)[native-inputs]: Add python-testrepository.
---
 gnu/packages/openstack.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index b0395fd7d0..a0322c9914 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2020, 2021 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2022 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -270,7 +271,7 @@ (define-public python-os-testr
     (propagated-inputs
      (list python-subunit))
     (native-inputs
-     (list python-pbr python-testtools python-babel))
+     (list python-pbr python-testtools python-babel python-testrepository))
     (home-page "https://www.openstack.org/")
     (synopsis "Testr wrapper to provide functionality for OpenStack projects")
     (description
-- 
2.34.0

Message #11 received at 53054 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 53054 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 2/3] gnu: python-msgpack-transitional: Fix broken tests.
Date: Thu,  6 Jan 2022 15:33:58 +0100

* gnu/packages/python-xyz.scm (python-msgpack-transitional)[arguments]:
Replace references to deprecated Python methods.
---
 gnu/packages/python-xyz.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index bea33cbf05..40c9e30969 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -10688,6 +10688,11 @@ (define-public python-msgpack-transitional
                (substitute* "setup.py"
                  (("TRANSITIONAL = False")
                    "TRANSITIONAL = 1"))
+               ;; This old version is not compatible with Python 3.9
+               (substitute* '("test/test_buffer.py" "test/test_extension.py")
+                 ((".tostring\\(") ".tobytes("))
+               (substitute* '("test/test_buffer.py" "test/test_extension.py")
+                 ((".fromstring\\(") ".frombytes("))
                #t))))))))
 
 (define-public python2-msgpack
-- 
2.34.0

Message #14 received at 53054 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: 53054 <at> debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH 3/3] gnu: poetry: Fix package inputs.
Date: Thu,  6 Jan 2022 15:33:59 +0100

* gnu/packages/python-xyz.scm (poetry)[propagated-inputs]: Add
python-crashtest and python-entrypoints. Remove python-clikit.

[WIP] re-add python-msgpack-transitional to make poetry work
---
 gnu/packages/python-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 40c9e30969..57f5a4eddd 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15832,7 +15832,8 @@ (define-public poetry
      (list python-cachecontrol
            python-cachy
            python-cleo
-           python-clikit
+           python-crashtest
+           python-entrypoints
            python-html5lib
            python-keyring
            python-msgpack-transitional
-- 
2.34.0

Message #19 received at 53054-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 53054-done <at> debbugs.gnu.org
Subject: Re: bug#53054: [PATCH 0/3] gnu: poetry: Fix package inputs.
Date: Tue, 11 Jan 2022 18:55:28 +0100

Hi,

Tanguy Le Carrour <tanguy <at> bioneland.org> skribis:

>   gnu: python-os-testr: Add python-testrepository to inputs.
>   gnu: poetry: Fix package inputs.
>   gnu: python-msgpack-transitional: Remove unused variable.

Applied, minus the “[WIP]” comment in the last commit log.

Thanks!

Ludo’.

Message #22 received at 53054 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 53054 <at> debbugs.gnu.org
Subject: Re: [bug#53054] [PATCH 2/3] gnu: python-msgpack-transitional: Fix
 broken tests.
Date: Tue, 11 Jan 2022 14:51:15 -0500

On Thu, Jan 06, 2022 at 03:33:58PM +0100, Tanguy Le Carrour wrote:
> * gnu/packages/python-xyz.scm (python-msgpack-transitional)[arguments]:
> Replace references to deprecated Python methods.

Thanks for taking care of this package. I saw that this patch was
applied as commit d07d3ea008d24f8ad5f4f32f86cb1f89226123ae.

Are you using this package? It has no uses within Guix, so we could
remove it.

Message #25 received at 53054-done <at> debbugs.gnu.org (full text, mbox):

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53054-done <at> debbugs.gnu.org
Subject: Re: bug#53054: [PATCH 0/3] gnu: poetry: Fix package inputs.
Date: Wed, 12 Jan 2022 08:53:25 +0100

Hi Ludo’,


Quoting Ludovic Courtès (2022-01-11 18:55:28)
> Hi,
> 
> Tanguy Le Carrour <tanguy <at> bioneland.org> skribis:
> 
> >   gnu: python-os-testr: Add python-testrepository to inputs.
> >   gnu: poetry: Fix package inputs.
> >   gnu: python-msgpack-transitional: Remove unused variable.
> 
> Applied, minus the “[WIP]” comment in the last commit log.

*ERF*… my bad! Thanks for watching out! :-)


-- 
Tanguy

Message #28 received at 53054 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53054 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#53054] [PATCH 2/3] gnu: python-msgpack-transitional: Fix
 broken tests.
Date: Wed, 12 Jan 2022 09:10:28 +0100

Hi Leo,


Quoting Leo Famulari (2022-01-11 20:51:15)
> On Thu, Jan 06, 2022 at 03:33:58PM +0100, Tanguy Le Carrour wrote:
> > * gnu/packages/python-xyz.scm (python-msgpack-transitional)[arguments]:
> > Replace references to deprecated Python methods.
> 
> Thanks for taking care of this package. I saw that this patch was
> applied as commit d07d3ea008d24f8ad5f4f32f86cb1f89226123ae.
> 
> Are you using this package? It has no uses within Guix, so we could
> remove it.

I was supposed to removed it, indeed!
But, apparently, I messed up the patch set! :-(

The thing is, in the bug report, there's a mention to the patch set I
was supposed to push as a v2, but I don't know where it comes from if
the v2 was not actually sent?!

```
>   gnu: python-os-testr: Add python-testrepository to inputs.
>   gnu: poetry: Fix package inputs.
>   gnu: python-msgpack-transitional: Remove unused variable.
```

Unfortunatly, Ludo applied it already! My bad!

… I'll fix my mess and push the fix. Sorry guys! :-(


-- 
Tanguy

Message #31 received at 53054-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Tanguy LE CARROUR <tanguy <at> bioneland.org>
Cc: 53054-done <at> debbugs.gnu.org,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#53054] [PATCH 2/3] gnu: python-msgpack-transitional: Fix
 broken tests.
Date: Wed, 12 Jan 2022 13:35:51 -0500

On Wed, Jan 12, 2022 at 09:10:28AM +0100, Tanguy LE CARROUR wrote:
> … I'll fix my mess and push the fix. Sorry guys! :-(

No worries, I removed it in commit d5ae6739fdb4786c49d33de3fec9872c73d2e311

And I removed python2-msgpack in the subsequent commit.

Message #34 received at 53054-done <at> debbugs.gnu.org (full text, mbox):

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53054-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#53054] [PATCH 2/3] gnu: python-msgpack-transitional: Fix
 broken tests.
Date: Thu, 13 Jan 2022 09:02:41 +0100

Hi Leo,


Quoting Leo Famulari (2022-01-12 19:35:51)
> On Wed, Jan 12, 2022 at 09:10:28AM +0100, Tanguy LE CARROUR wrote:
> > … I'll fix my mess and push the fix. Sorry guys! :-(
> 
> No worries, I removed it in commit d5ae6739fdb4786c49d33de3fec9872c73d2e311
> 
> And I removed python2-msgpack in the subsequent commit.

Thanks!


-- 
Tanguy

Message #37 received at 53054-done <at> debbugs.gnu.org (full text, mbox):

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53054-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#53054] [PATCH 2/3] gnu: python-msgpack-transitional: Fix
 broken tests.
Date: Thu, 13 Jan 2022 10:51:25 +0100

Hi Leo,


Quoting Tanguy LE CARROUR (2022-01-12 09:10:28)
> Quoting Leo Famulari (2022-01-11 20:51:15)
> > On Thu, Jan 06, 2022 at 03:33:58PM +0100, Tanguy Le Carrour wrote:
> > > * gnu/packages/python-xyz.scm (python-msgpack-transitional)[arguments]:
> > > Replace references to deprecated Python methods.
> > 
> > Thanks for taking care of this package. I saw that this patch was
> > applied as commit d07d3ea008d24f8ad5f4f32f86cb1f89226123ae.
> > 
> > Are you using this package? It has no uses within Guix, so we could
> > remove it.
> 
> I was supposed to removed it, indeed!
> But, apparently, I messed up the patch set! :-(
> 
> The thing is, in the bug report, there's a mention to the patch set I
> was supposed to push as a v2, but I don't know where it comes from if
> the v2 was not actually sent?!
> 
> ```
> >   gnu: python-os-testr: Add python-testrepository to inputs.
> >   gnu: poetry: Fix package inputs.
> >   gnu: python-msgpack-transitional: Remove unused variable.
> ```
> 
> Unfortunatly, Ludo applied it already! My bad!
> 
> … I'll fix my mess and push the fix. Sorry guys! :-(

I've submitted a patch set (#53228) to, I hope, fix my mess!

I'm closing this one.

Regards,

-- 
Tanguy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.