GNU logs - #53133, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected
Resent-From: Shingo Tanaka <shingo.fg8@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 09 Jan 2022 02:04:01 +0000
Resent-Message-ID: <handler.53133.B.16416938246348 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 53133 <at> debbugs.gnu.org
Date: Sun, 09 Jan 2022 11:03:27 +0900
Message-ID: <87k0f9is28.wl-shingo.fg8@HIDDEN>
From: Shingo Tanaka <shingo.fg8@HIDDEN>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0
 Emacs/28.0.90 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Received-SPF: pass client-ip=2607:f8b0:4864:20::1036;
 envelope-from=shingo.fg8@HIDDEN; helo=mail-pj1-x1036.google.com
X-Spam_score_int: -10
X-Spam_score: -1.1
X-Spam_bar: -
X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.6 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi, tabulated-list-sort sometimes doesn't work as expected
 due to the change between 28.0.90 and 28.0.50. Here is how to reproduce:
 1. Open Emacs from terminal with `emacs --no-init-file' 2. Type M-x
 list-buffers
 3. Type C-x o (go to Buffer Menu) 4. Type C-M-Right 5 times to move on to
 "Fundamental" in "M [...] 
 Content analysis details:   (1.6 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,
 medium trust [209.51.188.17 listed in list.dnswl.org]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (shingo.fg8[at]gmail.com)
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (shingo.fg8[at]gmail.com)
 0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
 [209.51.188.17 listed in wl.mailspike.net]
 0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 1.3 SPOOFED_FREEMAIL       No description available.
 1.5 SPOOF_GMAIL_MID        From Gmail but it doesn't seem to be...
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

Hi,

tabulated-list-sort sometimes doesn't work as expected due to the change between
28.0.90 and 28.0.50.

Here is how to reproduce:
1. Open Emacs from terminal with `emacs --no-init-file'
2. Type M-x list-buffers
3. Type C-x o (go to Buffer Menu)
4. Type C-M-Right 5 times to move on to "Fundamental" in "Mode" column
5. Type S 2 times or more to toggle sorting order
6. You will be able to see that "Size" column is selected as the sorting column
   unexpectedly

Looks like below change from 28.0.50 is releated to this issue, because it
disappears when I just rewind this change.

--- tabulated-list.el.org	2022-01-06 22:32:13.936852142 +0900
+++ tabulated-list.el	2022-01-07 15:15:42.000000000 +0900
@@ -574,7 +581,8 @@
       (when not-last-col
         (when (> pad-right 0) (insert (make-string pad-right ?\s)))
         (insert (propertize
-                 (make-string (- width (min width label-width)) ?\s)
+                 ;; We need at least one space to align correctly.
+                 (make-string (- width (min 1 width label-width)) ?\s)
                  'display `(space :align-to ,next-x))))
       (put-text-property opoint (point) 'tabulated-list-column-name name)
       next-x)))

Hope this will be fixed appropriately in the coming major release.

Regards,
Shingo

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Shingo Tanaka <shingo.fg8@HIDDEN>
Subject: bug#53133: Acknowledgement (28.0.90; tabulated-list-sort doesn't
 work as expected)
Message-ID: <handler.53133.B.16416938246348.ack <at> debbugs.gnu.org>
References: <87k0f9is28.wl-shingo.fg8@HIDDEN>
X-Gnu-PR-Message: ack 53133
X-Gnu-PR-Package: emacs
Reply-To: 53133 <at> debbugs.gnu.org
Date: Sun, 09 Jan 2022 02:04:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 53133 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
53133: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53133
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 09 Jan 2022 10:45:01 +0000
Resent-Message-ID: <handler.53133.B53133.164172507612213 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Shingo Tanaka <shingo.fg8@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Cc: 53133 <at> debbugs.gnu.org
Date: Sun, 09 Jan 2022 12:44:15 +0200
Message-Id: <8335lx2npc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87k0f9is28.wl-shingo.fg8@HIDDEN> (message from Shingo Tanaka
 on Sun, 09 Jan 2022 11:03:27 +0900)
References: <87k0f9is28.wl-shingo.fg8@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

unarchive 48639
reopen 48639
thanks

> Date: Sun, 09 Jan 2022 11:03:27 +0900
> From: Shingo Tanaka <shingo.fg8@HIDDEN>
> 
> Here is how to reproduce:
> 1. Open Emacs from terminal with `emacs --no-init-file'
> 2. Type M-x list-buffers
> 3. Type C-x o (go to Buffer Menu)
> 4. Type C-M-Right 5 times to move on to "Fundamental" in "Mode" column
> 5. Type S 2 times or more to toggle sorting order
> 6. You will be able to see that "Size" column is selected as the sorting column
>    unexpectedly
> 
> Looks like below change from 28.0.50 is releated to this issue, because it
> disappears when I just rewind this change.
> 
> --- tabulated-list.el.org	2022-01-06 22:32:13.936852142 +0900
> +++ tabulated-list.el	2022-01-07 15:15:42.000000000 +0900
> @@ -574,7 +581,8 @@
>        (when not-last-col
>          (when (> pad-right 0) (insert (make-string pad-right ?\s)))
>          (insert (propertize
> -                 (make-string (- width (min width label-width)) ?\s)
> +                 ;; We need at least one space to align correctly.
> +                 (make-string (- width (min 1 width label-width)) ?\s)
>                   'display `(space :align-to ,next-x))))
>        (put-text-property opoint (point) 'tabulated-list-column-name name)
>        next-x)))

You are right.

Stefan, I reverted that change and I'm reopening bug#48639.  This
problem is a much more serious regression than what happens sometimes
when text-size is scaled.  We will need to find another fix for that
bug, most probably in one of the hooks used by tabulated-list.el, by
adding the display property only when actually needed.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 09 Jan 2022 11:31:02 +0000
Resent-Message-ID: <handler.53133.B53133.164172785025786 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: shingo.fg8@HIDDEN, stefankangas@HIDDEN
Cc: 53133 <at> debbugs.gnu.org
Date: Sun, 09 Jan 2022 13:30:28 +0200
Message-Id: <83zgo516zv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <8335lx2npc.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 09
 Jan 2022 12:44:15 +0200)
References: <87k0f9is28.wl-shingo.fg8@HIDDEN> <8335lx2npc.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Sun, 09 Jan 2022 12:44:15 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
> Cc: 53133 <at> debbugs.gnu.org
> 
> > --- tabulated-list.el.org	2022-01-06 22:32:13.936852142 +0900
> > +++ tabulated-list.el	2022-01-07 15:15:42.000000000 +0900
> > @@ -574,7 +581,8 @@
> >        (when not-last-col
> >          (when (> pad-right 0) (insert (make-string pad-right ?\s)))
> >          (insert (propertize
> > -                 (make-string (- width (min width label-width)) ?\s)
> > +                 ;; We need at least one space to align correctly.
> > +                 (make-string (- width (min 1 width label-width)) ?\s)
> >                   'display `(space :align-to ,next-x))))
> >        (put-text-property opoint (point) 'tabulated-list-column-name name)
> >        next-x)))
> 
> You are right.
> 
> Stefan, I reverted that change and I'm reopening bug#48639.  This
> problem is a much more serious regression than what happens sometimes
> when text-size is scaled.  We will need to find another fix for that
> bug, most probably in one of the hooks used by tabulated-list.el, by
> adding the display property only when actually needed.

To help debugging the original problem: the 'display' property that
was always present caused move-to-column in tabulated-list-print to
stop at the wrong position, where the tabulated-list-column-name
property had the wrong value.  So either the 'display' property should
be used only when actually needed, or the tabulated-list-column-name
property should be also put on the text covered by the 'display'
property.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 10 Jan 2022 01:06:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 09 20:06:31 2022
Received: from localhost ([127.0.0.1]:51569 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n6j8p-0001bH-A2
	for submit <at> debbugs.gnu.org; Sun, 09 Jan 2022 20:06:31 -0500
Received: from mail-pg1-f180.google.com ([209.85.215.180]:35374)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1n6j8l-0001b2-NW
 for control <at> debbugs.gnu.org; Sun, 09 Jan 2022 20:06:30 -0500
Received: by mail-pg1-f180.google.com with SMTP id v25so9819337pge.2
 for <control <at> debbugs.gnu.org>; Sun, 09 Jan 2022 17:06:27 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:mime-version:date:message-id:subject:to;
 bh=YtFUZEoPFmtyrk4cjynDYLfAcnu14xVEobdaRVG2FVk=;
 b=b+U2Xz4AWAcMTm/Qw/NG0hJ+9MYY3+3e8mJvnB4h1mLrOi+sgwuMoF+cmjOCSoLnmp
 Abpmwl3j+2TSrYj6hP2xpWMKHWiVwl9Hsxc11B+QL9L/fKlaw+a8YaTVIQtfxo+OALjM
 uXH1wMY/qkmeCasCU+bWTu/BA7IykAk3bAz4LrZDOORmg0ZCXXC8rdWAFdieSBM6aWrA
 o853ERWq8/ZHpCrHH//XtsfyODoNA6uVUCTU+dd7qXpNvcUAyh8fGeaZkXau7jbMbrK2
 M++4MBR4rIZnx9LTLu0hZQm616QYj0gLIql5GZ1uS/bUWKDTMfr5einHMOxs9tTbvP2R
 1Qxg==
X-Gm-Message-State: AOAM5337usoHmYp6fejTrZsOepQAyuSzhco51MyX2Im3sPPRHM3UwdSd
 aLD7udj7/VyeZ4wKb1dcorbu5IScNGdNzz2oVU4dwN39oG0=
X-Google-Smtp-Source: ABdhPJxL9yzqnuRuM5OG21m2d0B12KfNP0s/0sd+hpQi4E+R0fi//4xQ15LsP+4SHVRE90et1PpmgCXeQsiHOEm/ciQ=
X-Received: by 2002:a05:6a00:2444:b0:4ab:15b9:20e5 with SMTP id
 d4-20020a056a00244400b004ab15b920e5mr73125467pfj.0.1641776782028; Sun, 09 Jan
 2022 17:06:22 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 9 Jan 2022 19:06:21 -0600
From: Stefan Kangas <stefan@HIDDEN>
MIME-Version: 1.0
Date: Sun, 9 Jan 2022 19:06:21 -0600
Message-ID: <CADwFkmnKJcphXiCB4qWxNk21G=bjz0_A=bupQ29uHSAgTe91sg@HIDDEN>
Subject: control message for bug #53133
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

forcemerge 53133 48639
quit

Last modified: Mon, 10 Jan 2022 01:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.