GNU bug report logs - #53154
[PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53154 in the body.
You can then email your comments to 53154 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>,
 Christopher Baines <mail <at> cbaines.net>
Subject: [PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.
Date: Mon, 10 Jan 2022 11:28:12 +0530

Earlier, the bind-rpc field of <laminar-configuration> was not used at
all. This was a bug.

* gnu/services/ci.scm (laminar-shepherd-service): Use bind-rpc to set
LAMINAR_BIND_RPC environment variable.
---
 gnu/services/ci.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/ci.scm b/gnu/services/ci.scm
index 0c3566bcaf..172f85fe8e 100644
--- a/gnu/services/ci.scm
+++ b/gnu/services/ci.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018, 2019, 2020, 2021 Christopher Baines <mail <at> cbaines.net>
-;;; Copyright © 2021 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2021, 2022 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -84,6 +84,8 @@ (define laminar-shepherd-service
                                         #$home-directory)
                         ,(string-append "LAMINAR_BIND_HTTP="
                                         #$bind-http)
+                        ,(string-append "LAMINAR_BIND_RPC="
+                                        #$bind-rpc)
                         ,(string-append "LAMINAR_TITLE="
                                         #$title)
                         ,(string-append "LAMINAR_KEEP_RUNDIRS="
-- 
2.34.0

Message #8 received at 53154 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Christopher Baines  <mail <at> cbaines.net>
Cc: 53154 <at> debbugs.gnu.org
Subject: Re: bug#53154: Acknowledgement ([PATCH] services: laminar: Set
 LAMINAR_BIND_RPC environment variable.)
Date: Mon, 10 Jan 2022 11:31:09 +0530

[Message part 1 (text/plain, inline)]

Hi Chris,

I have CCed you on this issue, since you wrote the laminar service and
might be able to review this patch easily.

Thank you!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53154 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 53154 <at> debbugs.gnu.org
Subject: Re: bug#53154: Acknowledgement ([PATCH] services: laminar: Set
 LAMINAR_BIND_RPC environment variable.)
Date: Mon, 10 Jan 2022 08:57:25 +0000

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Hi Chris,
>
> I have CCed you on this issue, since you wrote the laminar service and
> might be able to review this patch easily.
>
> Thank you!

It looks like a good change to me, please push!

Chris

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 53154-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 53154-done <at> debbugs.gnu.org
Subject: Re: bug#53154: Acknowledgement ([PATCH] services: laminar: Set
 LAMINAR_BIND_RPC environment variable.)
Date: Tue, 11 Jan 2022 12:26:34 +0530

[Message part 1 (text/plain, inline)]

Pushed, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.