GNU bug report logs - #53169
[PATCH 1/8] gnu: Add rust-svgtypes-0.5.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53169 in the body.
You can then email your comments to 53169 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/8] gnu: Add rust-svgtypes-0.5.
Date: Tue, 11 Jan 2022 00:31:31 +0000

[Message part 1 (text/plain, inline)]

Hi,

this patch set updates and adds additional Lyon crates.

----
Petr

[Message part 2 (text/html, inline)]

[0003-gnu-rust-lyon-geom-0.17-Update-to-0.17.6.patch (text/x-patch, attachment)]

[0002-gnu-rust-euclid-0.22-Update-to-0.22.6.patch (text/x-patch, attachment)]

[0004-gnu-rust-lyon-path-0.17-Update-to-0.17.7.patch (text/x-patch, attachment)]

[0007-gnu-Add-rust-lyon-extra-0.17.patch (text/x-patch, attachment)]

[0005-gnu-Add-rust-lyon-svg-0.17.patch (text/x-patch, attachment)]

[0006-gnu-Add-rust-float-next-after-0.1.patch (text/x-patch, attachment)]

[0008-gnu-Add-rust-lyon-tessellation-0.17.patch (text/x-patch, attachment)]

[0001-gnu-Add-rust-svgtypes-0.5.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Cc: phodina <phodina <at> protonmail.com>, 53169-done <at> debbugs.gnu.org
Subject: Re: [bug#53169] [PATCH 1/8] gnu: Add rust-svgtypes-0.5.
Date: Fri, 21 Jan 2022 01:21:35 +0100

Hello,

phodina via Guix-patches via <guix-patches <at> gnu.org> writes:

> this patch set updates and adds additional Lyon crates.

Thank you.

Note that some of your commit messages were misleading. E.g., when you
write "gnu: rust-euclid-0.22: Update to 0.22.6.", you actually create
a new variable `rust-euclid-0.22' and remove `rust-euclid-0.20'. As
a consequence it broke old revisions of `plotters' and `font-kit'
crates, which I had to remove.

Also, indentation from imported packages is a bit off. You may want to
re-indent packages.

In any case, all applied!

Regards,
-- 
Nicolas Goaziou

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: phodina via Guix-patches via <guix-patches <at> gnu.org>,
 53169-done <at> debbugs.gnu.org
Subject: Re: [bug#53169] [PATCH 1/8] gnu: Add rust-svgtypes-0.5.
Date: Fri, 21 Jan 2022 05:08:21 +0000

Hi Nicolas,

> Note that some of your commit messages were misleading. E.g., when you
>
> write "gnu: rust-euclid-0.22: Update to 0.22.6.", you actually create
>
> a new variable `rust-euclid-0.22' and remove` rust-euclid-0.20'. As
>
> a consequence it broke old revisions of `plotters' and` font-kit'
>
> crates, which I had to remove.
>
> Also, indentation from imported packages is a bit off. You may want to
>
> re-indent packages.
>
> In any case, all applied!

Thanks for the note. You're right that in case "gnu: rust-euclid-0.22" it's new variable as there are dependencies on the old one.

I'll keep that in mind next time :-)


----
Petr

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.