GNU bug report logs - #53185
[PATCH 1/3] gnu: Add python-geojson.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53185 in the body.
You can then email your comments to 53185 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/3] gnu: Add python-geojson.
Date: Tue, 11 Jan 2022 10:45:39 +0000

[Message part 1 (text/plain, inline)]

Hi,

this patch series adds command line tool to show weather in your preferred location.

----
Petr

[Message part 2 (text/html, inline)]

[0002-gnu-Add-python-pyowm.patch (text/x-patch, attachment)]

[0001-gnu-Add-python-geojson.patch (text/x-patch, attachment)]

[0003-gnu-Add-wfetch.patch (text/x-patch, attachment)]

Message #10 received at 53185-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 53185-done <at> debbugs.gnu.org
Subject: Re: bug#53185: [PATCH 1/3] gnu: Add python-geojson.
Date: Fri, 28 Jan 2022 23:55:28 +0100

Hi,

phodina <phodina <at> protonmail.com> skribis:

> From e7995f7904fa6c51c8ef24e19cd5bb8396abe13d Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Tue, 11 Jan 2022 11:28:57 +0100
> Subject: [PATCH 2/3] gnu: Add python-pyowm.
>
> * gnu/packages/python-web.scm (python-pyowm): New variable.

[...]

> From d3287c48bb665ac08e95b9e65bc21c79c4207894 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Tue, 11 Jan 2022 11:28:17 +0100
> Subject: [PATCH 1/3] gnu: Add python-geojson.
>
> * gnu/packages/python-xyz.scm (python-geojson): New variable.

[...]

> From 1cb1ea2208e1575b3cdf5539644c9e4e435c0fab Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Tue, 11 Jan 2022 11:29:23 +0100
> Subject: [PATCH 3/3] gnu: Add wfetch.
>
> * gnu/packages/admin.scm (wfetch): New variable.

Applied, after tweaking synopses/descriptions, moving wfetch to
python-xyz.scm (since it has nothing to do with system administration)
and fixing its ‘home-page’.

Please pay attention to these things for subsequent patches and you may
benefit from faster review in return.  :-)

Thanks,
Ludo’.

Message #13 received at 53185-done <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53185-done <at> debbugs.gnu.org
Subject: Re: bug#53185: [PATCH 1/3] gnu: Add python-geojson.
Date: Sat, 29 Jan 2022 05:11:01 +0000

Thanks Ludo’,

> Hi,
>
> phodina phodina <at> protonmail.com skribis:
>
> > From e7995f7904fa6c51c8ef24e19cd5bb8396abe13d Mon Sep 17 00:00:00 2001
> >
> > From: Petr Hodina phodina <at> protonmail.com
> >
> > Date: Tue, 11 Jan 2022 11:28:57 +0100
> >
> > Subject: [PATCH 2/3] gnu: Add python-pyowm.
> >
> > -   gnu/packages/python-web.scm (python-pyowm): New variable.
>
> [...]
>
> > From d3287c48bb665ac08e95b9e65bc21c79c4207894 Mon Sep 17 00:00:00 2001
> >
> > From: Petr Hodina phodina <at> protonmail.com
> >
> > Date: Tue, 11 Jan 2022 11:28:17 +0100
> >
> > Subject: [PATCH 1/3] gnu: Add python-geojson.
> >
> > -   gnu/packages/python-xyz.scm (python-geojson): New variable.
>
> [...]
>
> > From 1cb1ea2208e1575b3cdf5539644c9e4e435c0fab Mon Sep 17 00:00:00 2001
> >
> > From: Petr Hodina phodina <at> protonmail.com
> >
> > Date: Tue, 11 Jan 2022 11:29:23 +0100
> >
> > Subject: [PATCH 3/3] gnu: Add wfetch.
> >
> > -   gnu/packages/admin.scm (wfetch): New variable.
>
> Applied, after tweaking synopses/descriptions, moving wfetch to
>
> python-xyz.scm (since it has nothing to do with system administration)
>
> and fixing its ‘home-page’.
>
> Please pay attention to these things for subsequent patches and you may
>
> benefit from faster review in return. :-)
>
> Thanks,
>
> Ludo’.

I've checked the diffs and your synopsis as well as description are more appropriate.

I agree that the package wfetch belongs into python-xyz.scm as it does nothing special. The reason why I placed it in admin.scm was that I found about it due to pfetch and thought it's "smiliar". Then again it does not gather data from the system just fetches some weather info.

Thanks for catching the wrong homepage, as both projects were on github and had the same name it went unnoticed.

I'll be more vigilant next time :-)

----
Petr

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.