GNU bug report logs - #53189
29.0.50; Avoid window split in project-shell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53189 in the body.
You can then email your comments to 53189 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Uberti <manuel.uberti <at> inventati.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Avoid window split in project-shell
Date: Tue, 11 Jan 2022 16:56:25 +0100

In order to avoid splitting the current window when I open a shell-mode buffer 
with `project-shell' I have this in my init.el:

(setq-default display-buffer-alist '((".+shell*"
                                      (display-buffer-same-window)
                                      (reusable-frames . nil))))

The first time I use `C-x p s` I am getting the behaviour I want. But if I do this:

- `C-x p s`
- `C-x b RET`
- `C-x p s`

The current window is split and the shell-mode buffer appears on the
side.

How can I avoid the window splitting?

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.18, cairo 
version 1.16.0)
 of 2022-01-11 built on hathaway
Repository revision: ecea3f2c8322ca43cbde9976fa6e658100cc2b99
Repository branch: master
System Description: Ubuntu 20.04 LTS

Configured using:
 'configure --with-harfbuzz --with-native-compilation --with-pgtk
 --with-xinput2'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP
NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB

Important settings:
  value of $LC_MESSAGES: en_GB.UTF-8
  value of $LC_MONETARY: it_IT.UTF-8
  value of $LC_NUMERIC: it_IT.UTF-8
  value of $LC_TIME: it_IT.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: ELisp/l

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media rmc puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils pp cl-print
cl-extra time-date pulse color jka-compr help-fns radix-tree help-mode
find-func xref misearch multi-isearch shell pcomplete comint ansi-color
ring thingatpt vc-mtn vc-hg vc-git diff-mode easy-mmode vc-bzr vc-src
vc-sccs vc-svn vc-cvs vc-rcs vc cl-loaddefs cl-lib vc-dispatcher project
seq gv subr-x byte-opt bytecomp byte-compile cconv iso-transl tooltip
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/pgtk-win pgtk-win term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget keymap hashtable-print-readable backquote threads
dbusbind inotify dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit pgtk lcms2 multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 83345 8434)
 (symbols 48 8175 1)
 (strings 32 26707 2619)
 (string-bytes 1 871504)
 (vectors 16 16203)
 (vector-slots 8 278464 10156)
 (floats 8 129 54)
 (intervals 56 809 0)
 (buffers 992 14))

-- 
Manuel Uberti
www.manueluberti.eu

Message #8 received at 53189 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Manuel Uberti <manuel.uberti <at> inventati.org>, 53189 <at> debbugs.gnu.org
Subject: Re: bug#53189: 29.0.50; Avoid window split in project-shell
Date: Tue, 11 Jan 2022 18:07:58 +0100

> In order to avoid splitting the current window when I open a shell-mode buffer with `project-shell' I have this in my init.el:
>
> (setq-default display-buffer-alist '((".+shell*"
>                                        (display-buffer-same-window)
>                                        (reusable-frames . nil))))
>
> The first time I use `C-x p s` I am getting the behaviour I want. But if I do this:
>
> - `C-x p s`
> - `C-x b RET`
> - `C-x p s`
>
> The current window is split and the shell-mode buffer appears on the
> side.
>
> How can I avoid the window splitting?

This should be Bug#52878.  Can you try with


diff --git a/lisp/window.el b/lisp/window.el
index 3f61d53128..068d76c87f 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7474,9 +7474,10 @@ display-buffer-base-action
   :version "24.1"
   :group 'windows)

-(defcustom display-comint-buffer-action 'display-buffer-same-window
+(defcustom display-comint-buffer-action
+  '(display-buffer-same-window . ((inhibit-same-window . nil)))
   "The action to display a comint buffer."
-  :type display-buffer--action-function-custom-type
+  :type display-buffer--action-custom-type
   :risky t
   :version "29.1"
   :group 'windows


Which also means that your customization is no more necessary.

martin

Message #11 received at 53189 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Uberti <manuel.uberti <at> inventati.org>
To: martin rudalics <rudalics <at> gmx.at>, 53189 <at> debbugs.gnu.org
Subject: Re: bug#53189: 29.0.50; Avoid window split in project-shell
Date: Tue, 11 Jan 2022 19:24:26 +0100

On 11/01/22 18:07, martin rudalics wrote:
> This should be Bug#52878.  Can you try with
> 
> 
> diff --git a/lisp/window.el b/lisp/window.el
> index 3f61d53128..068d76c87f 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -7474,9 +7474,10 @@ display-buffer-base-action
>     :version "24.1"
>     :group 'windows)
> 
> -(defcustom display-comint-buffer-action 'display-buffer-same-window
> +(defcustom display-comint-buffer-action
> +  '(display-buffer-same-window . ((inhibit-same-window . nil)))
>     "The action to display a comint buffer."
> -  :type display-buffer--action-function-custom-type
> +  :type display-buffer--action-custom-type
>     :risky t
>     :version "29.1"
>     :group 'windows
> 
> 
> Which also means that your customization is no more necessary.

I built master on commit c8ea3f09e09b18b909f5a6c5434185b8dbf2fa63 (which comes 
after 4765487d5d24fc8a2a06c329dc9cc3bed9803391, on which I see a similar change 
to what you proposed), removed my customization, but the problem remains.

-- 
Manuel Uberti
www.manueluberti.eu

Message #14 received at 53189 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Uberti <manuel.uberti <at> inventati.org>
To: martin rudalics <rudalics <at> gmx.at>, 53189 <at> debbugs.gnu.org
Subject: Re: bug#53189: 29.0.50; Avoid window split in project-shell
Date: Wed, 12 Jan 2022 08:31:50 +0100

On 11/01/22 19:24, Manuel Uberti wrote:
> I built master on commit c8ea3f09e09b18b909f5a6c5434185b8dbf2fa63 (which comes 
> after 4765487d5d24fc8a2a06c329dc9cc3bed9803391, on which I see a similar change 
> to what you proposed), removed my customization, but the problem remains.

Forget about this. It is working, and my display-buffer-alist setting is redundant.

This ticket can be closed. Thanks for the support and the quick fix.

-- 
Manuel Uberti
www.manueluberti.eu

Message #19 received at 53189 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Manuel Uberti <manuel.uberti <at> inventati.org>
Cc: martin rudalics <rudalics <at> gmx.at>, 53189 <at> debbugs.gnu.org,
 Morgan.J.Smith <at> outlook.com
Subject: Re: bug#53189: 29.0.50; Avoid window split in project-shell
Date: Thu, 08 Sep 2022 15:59:15 +0200

Manuel Uberti <manuel.uberti <at> inventati.org> writes:

> This ticket can be closed. Thanks for the support and the quick fix.

This was half a year ago, but the bug report was left open, so I'm
closing it now.

I only lightly skimmed the other messages, so if this is a mistake,
please respond to the debbugs address and we'll reopen.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.