GNU bug report logs - #53239
[PATCH] gnu: openocd: Fix udev rules.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53239 in the body.
You can then email your comments to 53239 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jorge Acereda <jacereda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Jorge Acereda <jacereda <at> gmail.com>
Subject: [PATCH] gnu: openocd: Fix udev rules.
Date: Thu, 13 Jan 2022 21:53:14 +0100

* gnu/packages/embedded.scm (openocd)[arguments]<#:phases>[change-udev-group]:
Fix plugdev->dialout group replacement.
---
 gnu/packages/embedded.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
index ea1a585f0f..b33a23e9cb 100644
--- a/gnu/packages/embedded.scm
+++ b/gnu/packages/embedded.scm
@@ -618,7 +618,7 @@ (define-public openocd
                (("-DPKGBLDDATE=") "-DDISABLED_PKGBLDDATE="))
              (patch-shebang "bootstrap")
              (invoke "./bootstrap" "nosubmodule")))
-         (add-after 'autoreconf 'change-udev-group
+         (add-after 'unpack 'change-udev-group
            (lambda _
              (substitute* "contrib/60-openocd.rules"
                (("plugdev") "dialout"))
2.34.0

Message #10 received at 53239-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jorge Acereda <jacereda <at> gmail.com>
Cc: 53239-done <at> debbugs.gnu.org
Subject: Re: bug#53239: [PATCH] gnu: openocd: Fix udev rules.
Date: Thu, 13 Jan 2022 22:23:40 -0500

Hi Jorge!

Jorge Acereda <jacereda <at> gmail.com> writes:

> * gnu/packages/embedded.scm (openocd)[arguments]<#:phases>[change-udev-group]:
> Fix plugdev->dialout group replacement.
> ---
>  gnu/packages/embedded.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index ea1a585f0f..b33a23e9cb 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -618,7 +618,7 @@ (define-public openocd
>                 (("-DPKGBLDDATE=") "-DDISABLED_PKGBLDDATE="))
>               (patch-shebang "bootstrap")
>               (invoke "./bootstrap" "nosubmodule")))
> -         (add-after 'autoreconf 'change-udev-group
> +         (add-after 'unpack 'change-udev-group
>             (lambda _
>               (substitute* "contrib/60-openocd.rules"
>                 (("plugdev") "dialout"))
> 2.34.0

Good catch!  I've deleted the phases trailing #t, normalized the commit
message a bit, and pushed as 1e8b999717.

Thank you!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.