GNU bug report logs - #53284
28.0.91; TRAMP SSHFS: process-file with remote input file doesn't work

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53284 in the body.
You can then email your comments to 53284 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.91; TRAMP SSHFS: process-file with remote input file doesn't work
Date: Sat, 15 Jan 2022 13:51:31 +0100

Compare:

$ mkdir -p /tmp/tramptest && emacs -Q -batch -l tramp-sshfs -l tramp -eval '(let ((default-directory "/ssh:localhost:/tmp/tramptest/"))
  (write-region "hello" nil "input")
  (with-temp-buffer
    (print (list (process-file "cat" "input" t)
                 (buffer-string)))))'
Tramp: Sending command ‘exec ssh -e none localhost’
Tramp: Found remote shell prompt on ‘localhost’

(0 "hello")

with

$ mkdir -p /tmp/tramptest && emacs -Q -batch -l tramp-sshfs -l tramp -eval '(let ((default-directory "/sshfs:localhost:/tmp/tramptest/"))
  (write-region "hello" nil "input")
  (with-temp-buffer
    (print (list (process-file "cat" "input" t)
                 (buffer-string)))))'

(1 "")

I think the problem is that tramp-sshfs-handle-process-file doesn't pass
the correct input file to tramp-call-process; it should first expand the
input file against the remote default directory and then copy it locally
to pass it to the SSH process.

Relevant TRAMP debug logs:

13:47:51.375836 tramp-call-process (6) # ‘ssh -q -e none localhost cd /tmp/tramptest/ && exec cat’ input  *temp*
13:47:51.376756 tramp-call-process (1) # File is missing: Opening process input file No such file or directory /tmp/input
13:47:51.377255 tramp-call-process (6) # 1



In GNU Emacs 28.0.91 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
 of 2022-01-15
Repository revision: 7f36aca99dc1387cfeb599c9f2bb781036f79cf1
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP
SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: en_DK.utf8
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail phst skeleton edmacro kmacro
pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rx
message rmc dired dired-loaddefs rfc822 mml mml-sec epa derived epg
rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json map
time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047
rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils
mailheader gnutls puny elp dbus xml subr-x seq byte-opt gv bytecomp
byte-compile cconv compile text-property-search comint ansi-color ring
cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 69559 7104)
 (symbols 48 8543 3)
 (strings 32 24824 2332)
 (string-bytes 1 802103)
 (vectors 16 15669)
 (vector-slots 8 207480 18124)
 (floats 8 29 46)
 (intervals 56 228 0)
 (buffers 992 11))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

Message #8 received at 53284 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 53284 <at> debbugs.gnu.org
Subject: Re: bug#53284: 28.0.91; TRAMP SSHFS: process-file with remote input
 file doesn't work
Date: Sat, 15 Jan 2022 20:42:09 +0100

[Message part 1 (text/plain, inline)]

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

Hi Philipp,

> $ mkdir -p /tmp/tramptest && emacs -Q -batch -l tramp-sshfs -l tramp -eval '(let ((default-directory "/sshfs:localhost:/tmp/tramptest/"))
>   (write-region "hello" nil "input")
>   (with-temp-buffer
>     (print (list (process-file "cat" "input" t)
>                  (buffer-string)))))'
>
> (1 "")
>
> I think the problem is that tramp-sshfs-handle-process-file doesn't pass
> the correct input file to tramp-call-process; it should first expand the
> input file against the remote default directory and then copy it locally
> to pass it to the SSH process.

Could you pls try the appended patch?

Best regards, Michael.

[Message part 2 (text/x-patch, attachment)]

Message #11 received at 53284 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 53284 <at> debbugs.gnu.org
Subject: Re: bug#53284: 28.0.91; TRAMP SSHFS: process-file with remote input
 file doesn't work
Date: Sat, 15 Jan 2022 21:30:58 +0100

Am Sa., 15. Jan. 2022 um 20:42 Uhr schrieb Michael Albinus
<michael.albinus <at> gmx.de>:
>
> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
> Hi Philipp,
>
> > $ mkdir -p /tmp/tramptest && emacs -Q -batch -l tramp-sshfs -l tramp -eval '(let ((default-directory "/sshfs:localhost:/tmp/tramptest/"))
> >   (write-region "hello" nil "input")
> >   (with-temp-buffer
> >     (print (list (process-file "cat" "input" t)
> >                  (buffer-string)))))'
> >
> > (1 "")
> >
> > I think the problem is that tramp-sshfs-handle-process-file doesn't pass
> > the correct input file to tramp-call-process; it should first expand the
> > input file against the remote default directory and then copy it locally
> > to pass it to the SSH process.
>
> Could you pls try the appended patch?

That appears to fix it for me, thanks.

Message #16 received at 53284-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 53284-done <at> debbugs.gnu.org
Subject: Re: bug#53284: 28.0.91; TRAMP SSHFS: process-file with remote input
 file doesn't work
Date: Mon, 17 Jan 2022 10:53:04 +0100

Version: 29.1

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

Hi Philipp,

>> Could you pls try the appended patch?
>
> That appears to fix it for me, thanks.

Thanks for feedback. During my regression tests I've found some further
oddities in this area, so I have pushed an extended patch to
master. This will also be available with the next GNU ELPA Tramp
release, 2.5.2.1, end of this month. Closing the bug.

Best regards, Michael.

Message #19 received at 53284-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 53284-done <at> debbugs.gnu.org
Subject: Re: bug#53284: 28.0.91; TRAMP SSHFS: process-file with remote input
 file doesn't work
Date: Mon, 17 Jan 2022 11:07:04 +0100

Am Mo., 17. Jan. 2022 um 10:53 Uhr schrieb Michael Albinus
<michael.albinus <at> gmx.de>:
>
> Version: 29.1
>
> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
> Hi Philipp,
>
> >> Could you pls try the appended patch?
> >
> > That appears to fix it for me, thanks.
>
> Thanks for feedback. During my regression tests I've found some further
> oddities in this area, so I have pushed an extended patch to
> master. This will also be available with the next GNU ELPA Tramp
> release, 2.5.2.1, end of this month. Closing the bug.

Thanks. Any objections to backporting the fixes to the release branch?
The bug is rather annoying, and the fixes can't break anything (since
SSHFS wasn't supported in Emacs 27).

Message #22 received at 53284 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 53284 <at> debbugs.gnu.org
Subject: Re: bug#53284: 28.0.91; TRAMP SSHFS: process-file with remote input
 file doesn't work
Date: Mon, 17 Jan 2022 11:38:58 +0100

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

Hi Philipp,

> Thanks. Any objections to backporting the fixes to the release branch?
> The bug is rather annoying, and the fixes can't break anything (since
> SSHFS wasn't supported in Emacs 27).

The patch is not only about tramp-sshfs.el, it covers all
tramp*-process-file implementations. Therefore, we shouldn't merge it
into the release branch prior the release of Emacs 28.1.

After that, all changes in Tramp 2.5.2.x, including this patch, will be
merged in preparation of Emacs 28.2. In the meantime, you could use the
GNU ELPA version of Tramp.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.