GNU bug report logs - #53290
[PATCH] gnu: Add emacs-fennel-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53290 in the body.
You can then email your comments to 53290 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brandon Lucas <br <at> ndon.dk>
To: guix-patches <at> gnu.org
Cc: Brandon Lucas <br <at> ndon.dk>
Subject: [PATCH] gnu: Add emacs-fennel-mode.
Date: Sat, 15 Jan 2022 22:00:02 +0000

* gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c5cb07e16e..8175c48478 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -106,6 +106,7 @@
 ;;; Copyright © 2021 la snesne <lasnesne <at> lagunposprasihopre.org>
 ;;; Copyright © 2021 Brian Kubisiak <brian <at> kubisiak.com>
 ;;; Copyright © 2021, 2022 Taiju HIGASHI <higashi <at> taiju.info>
+;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29754,3 +29755,25 @@ (define-public emacs-global-tags
 wraps GNU Global calls and integration to editor using this API with
 project.el and xref.el.")
       (license license:gpl3+))))
+
+(define-public emacs-fennel-mode
+  (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419")
+        (revision "0"))
+    (package
+      (name "emacs-fennel-mode")
+      (version (git-version "0.4.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/technomancy/fennel-mode.git")
+               (commit commit)))
+         (sha256
+          (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w"))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/technomancy/fennel-mode")
+      (synopsis "Emacs major-mode for editing Fennel code")
+      (description
+       "Provides font-lock, indentation, navigation, and repl for Fennel code
+ within Emacs.")
+      (license license:gpl3+))))
--
2.34.0

Message #8 received at 53290 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brandon Lucas <br <at> ndon.dk>
Cc: 53290 <at> debbugs.gnu.org
Subject: Re: [bug#53290] [PATCH] gnu: Add emacs-fennel-mode.
Date: Sun, 16 Jan 2022 10:17:16 +0100

Hello,

Brandon Lucas <br <at> ndon.dk> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable.

Thank you for this. Some comments follow.

> +(define-public emacs-fennel-mode
> +  (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419")
> +        (revision "0"))
> +    (package
> +      (name "emacs-fennel-mode")
> +      (version (git-version "0.4.1" revision commit))

The commit hash you use matches the "0.4.1" version bump. Therefore you
can drop commit and revision binding, and use "0.4.1" in the version
field.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://gitlab.com/technomancy/fennel-mode.git")

You can drop the ".git" suffix here. I think "./pre-inst-env guix lint
emacs-fennel-mode" should warn you about it.

> +               (commit commit)))

Since you dropped commit binding, this should be (commit version)

> +      (description
> +       "Provides font-lock, indentation, navigation, and repl for Fennel code
> + within Emacs.")

Descriptions are expected to be full sentences. I suggest:

  Fennel mode provides font-lock, indentation, navigation and REPL for
  Fennel code within Emacs.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 53290 <at> debbugs.gnu.org (full text, mbox):

From: Brandon Lucas <br <at> ndon.dk>
To: 53290 <at> debbugs.gnu.org
Cc: Brandon Lucas <br <at> ndon.dk>
Subject: [PATCH v2] gnu: Add emacs-fennel-mode.
Date: Sun, 16 Jan 2022 10:50:33 +0000

* gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable.
---

Thanks for the review. :) Here's a better commit.

 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c5cb07e16e..27b5c14fc5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -106,6 +106,7 @@
 ;;; Copyright © 2021 la snesne <lasnesne <at> lagunposprasihopre.org>
 ;;; Copyright © 2021 Brian Kubisiak <brian <at> kubisiak.com>
 ;;; Copyright © 2021, 2022 Taiju HIGASHI <higashi <at> taiju.info>
+;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29754,3 +29755,23 @@ (define-public emacs-global-tags
 wraps GNU Global calls and integration to editor using this API with
 project.el and xref.el.")
       (license license:gpl3+))))
+
+(define-public emacs-fennel-mode
+  (package
+    (name "emacs-fennel-mode")
+    (version "0.4.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/technomancy/fennel-mode")
+             (commit version)))
+       (sha256
+        (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w"))))
+    (build-system emacs-build-system)
+    (home-page "https://gitlab.com/technomancy/fennel-mode")
+    (synopsis "Emacs major-mode for editing Fennel code")
+    (description
+     "Fennel mode provides font-lock, indentation, navigation, and REPL for
+ Fennel code within Emacs.")
+    (license license:gpl3+)))
--
2.34.0

Message #16 received at 53290-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brandon Lucas <br <at> ndon.dk>
Cc: 53290-done <at> debbugs.gnu.org
Subject: Re: [bug#53290] [PATCH v2] gnu: Add emacs-fennel-mode.
Date: Sun, 16 Jan 2022 23:37:09 +0100

Hello,

Brandon Lucas <br <at> ndon.dk> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable.

Applied, thank you!

As a side note, it is usually a bad idea to add a new package at the end
of a file, because this location is likely to introduce merge conflicts.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.