GNU bug report logs - #53291
[PATCH] build: clojure-build-system: Exit with non-zero if tests fail.

Previous Next

Package: guix-patches;

Reported by: Reily Siegel <mail <at> reilysiegel.com>

Date: Sun, 16 Jan 2022 01:05:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53291 in the body.
You can then email your comments to 53291 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#53291; Package guix-patches. (Sun, 16 Jan 2022 01:05:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Reily Siegel <mail <at> reilysiegel.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 16 Jan 2022 01:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reily Siegel <mail <at> reilysiegel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] build: clojure-build-system: Exit with non-zero if tests fail.
Date: Sat, 15 Jan 2022 20:03:25 -0500
* guix/build/clojure-build-system.scm (check): Exit test process with a
non-zero exit code if tests fail.
---
 guix/build/clojure-build-system.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/guix/build/clojure-build-system.scm b/guix/build/clojure-build-system.scm
index 91d6122afe..22e90581a5 100644
--- a/guix/build/clojure-build-system.scm
+++ b/guix/build/clojure-build-system.scm
@@ -99,8 +99,11 @@ (define* (check #:key
         (for-each (lambda (jar)
                     (eval-with-clojure `(do (apply require
                                                    '(clojure.test ,@libs*))
-                                            (apply clojure.test/run-tests
-                                                   ',libs*))
+                                            (if (clojure.test/successful?
+                                                 (apply clojure.test/run-tests
+                                                        ',libs*))
+                                                (System/exit 0)
+                                                (System/exit 1)))
                                        (cons jar test-dirs)))
                   jar-names)))
   #t)
-- 
2.34.0




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 24 Jan 2022 09:12:02 GMT) Full text and rfc822 format available.

Notification sent to Reily Siegel <mail <at> reilysiegel.com>:
bug acknowledged by developer. (Mon, 24 Jan 2022 09:12:02 GMT) Full text and rfc822 format available.

Message #10 received at 53291-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reily Siegel <mail <at> reilysiegel.com>
Cc: 53291-done <at> debbugs.gnu.org
Subject: Re: bug#53291: [PATCH] build: clojure-build-system: Exit with
 non-zero if tests fail.
Date: Mon, 24 Jan 2022 10:11:21 +0100
Hi,

Reily Siegel <mail <at> reilysiegel.com> skribis:

> * guix/build/clojure-build-system.scm (check): Exit test process with a
> non-zero exit code if tests fail.

Applied, thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 21 Feb 2022 12:24:17 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 36 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.