GNU bug report logs - #53318
[PATCH] gnu: Add go-github-com-go-chi-chi-v5.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53318 in the body.
You can then email your comments to 53318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 路辉 <luhux76 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
Date: Mon, 17 Jan 2022 14:45:26 +0000

From 30907bd26956ab6e0983eeca6b69aee935ebe155 Mon Sep 17 00:00:00 2001
From: Lu Hui <luhux76 <at> gmail.com>
Date: Mon, 17 Jan 2022 22:40:51 +0800
Subject: [PATCH] gnu: Add go-github-com-go-chi-chi-v5.

* gnu/packages/golang.scm (go-github-com-go-chi-chi-v5): New variable.
---
 gnu/packages/golang.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index db95ef1309..587357f6ba 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9370,3 +9370,27 @@ (define-public go-github-com-dreamacro-go-shadowsocks2
 @item TCP tunneling (e.g. benchmark with iperf3)
 @end itemize")
     (license license:asl2.0)))
+
+(define-public go-github-com-go-chi-chi-v5
+  (package
+    (name "go-github-com-go-chi-chi-v5")
+    (version "5.0.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/go-chi/chi")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0rzrsxz4xj0973c6nxklvq2vmg2m795snhk25836i0gnd1jnx79k"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/go-chi/chi/v5"))
+    (home-page "https://github.com/go-chi/chi")
+    (synopsis "Lightweight, idiomatic and composable router for building
+Go HTTP services")
+    (description
+     "@code{go-github-com-go-chi-chi-v5} is just a http router that
+lets you decompose request handling into many smaller layers.")
+    (license license:expat)))
-- 
2.34.0

Message #8 received at 53318 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>, 53318 <at> debbugs.gnu.org
Subject: Re: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
Date: Mon, 17 Jan 2022 20:13:23 +0100

[Message part 1 (text/plain, inline)]

Hi,

路辉 schreef op ma 17-01-2022 om 14:45 [+0000]:
> +    (synopsis "Lightweight, idiomatic and composable router for building
> +Go HTTP services")

Everything tries to be lightweight, idiomatic, etc. nowadays, so these
descriptions aren't helpful to the user.  From ‘17.4.4 Synopses and
Descriptions’:

  Please avoid marketing phrases such as “world-leading”,
  “industrial-strength”, and “next-generation”, and avoid superlatives
  like “the most advanced”—they are not helpful to users looking for a
  package and may even sound suspicious.  Instead, try to be factual,
  mentioning use cases and features.

How about:

  ‘Composable router for HTTP services written in Go’

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53318 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 53318 <at> debbugs.gnu.org
Cc: Lu Hui <luhux76 <at> gmail.com>, jgart <jgart <at> dismail.de>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: [PATCH v2] gnu: Add go-github-com-go-chi-chi-v5.
Date: Mon, 17 Jan 2022 22:06:12 -0500

* gnu/packages/golang.scm (go-github-com-go-chi-chi-v5): New variable.

---

Hi Lu and Maxime,

Here's a version two with Maxime's suggestion and a few nitpick fixes in the
description.

all best,

jgart

 gnu/packages/golang.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e808d8ebf6..f7a1e16c8c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9341,3 +9341,26 @@ (define-public go-github-com-dreamacro-go-shadowsocks2
 @item TCP tunneling (e.g. benchmark with iperf3)
 @end itemize")
     (license license:asl2.0)))
+
+(define-public go-github-com-go-chi-chi-v5
+  (package
+    (name "go-github-com-go-chi-chi-v5")
+    (version "5.0.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/go-chi/chi")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0rzrsxz4xj0973c6nxklvq2vmg2m795snhk25836i0gnd1jnx79k"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/go-chi/chi/v5"))
+    (home-page "https://github.com/go-chi/chi")
+    (synopsis "Composable router for HTTP services written in Go")
+    (description
+     "@code{go-github-com-go-chi-chi-v5} is an http router that
+lets the user decompose request handling into many smaller layers.")
+    (license license:expat)))
-- 
2.34.1

Message #14 received at 53318 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 53318 <at> debbugs.gnu.org
Subject: Re: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
Date: Tue, 18 Jan 2022 18:51:29 +0100

[Message part 1 (text/plain, inline)]

Hi,

Please keep debbugs in CC: or To: so other people know how the patch is
progressing.

路辉 schreef op di 18-01-2022 om 15:26 [+0000]:
> OK, new patch: [...]

I did the following checks:

  1. [x] it builds
  2. [x] "guix lint" shows no problems
  3. [x] there doesn't appear to be any malware in the source code

While doing (3), I noticed that the test code has a certificate
‘certs.pem’ and ‘key.pem’, which will expire eventually, which isn't
good for long-term reproducibility
(cf. https://issues.guix.gnu.org/44559).

So in the adjusted package definition, I deleted the affected test
‘middleware/middleware_test.go’, 'testdata/cert.pem' and
'testdata/key.pem', see attachement.

I also capitalised 'http' to 'HTTP' in the description.
The description is a bit short but I don't have much of an idea
how to improve it.

Aside from that, it LGTM.

Greetings,
Maxime.

[chi.scm (text/x-scheme, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 53318 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 路辉 <luhux76 <at> gmail.com>, 53318 <at> debbugs.gnu.org
Subject: Re: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
Date: Wed, 19 Jan 2022 13:04:11 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jan 18, 2022 at 06:51:29PM +0100, Maxime Devos wrote:
> Hi,
> 
> Please keep debbugs in CC: or To: so other people know how the patch is
> progressing.
> 
> 路辉 schreef op di 18-01-2022 om 15:26 [+0000]:
> > OK, new patch: [...]
> 
> I did the following checks:
> 
>   1. [x] it builds
>   2. [x] "guix lint" shows no problems
>   3. [x] there doesn't appear to be any malware in the source code
> 
> While doing (3), I noticed that the test code has a certificate
> ‘certs.pem’ and ‘key.pem’, which will expire eventually, which isn't
> good for long-term reproducibility
> (cf. https://issues.guix.gnu.org/44559).
> 
> So in the adjusted package definition, I deleted the affected test
> ‘middleware/middleware_test.go’, 'testdata/cert.pem' and
> 'testdata/key.pem', see attachement.
> 
> I also capitalised 'http' to 'HTTP' in the description.
> The description is a bit short but I don't have much of an idea
> how to improve it.
> 
> Aside from that, it LGTM.

FWIW when I imported this package I got the following description:

Package chi is a small, idiomatic and composable router for building HTTP services.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: Lu Hui <luhux76 <at> gmail.com>, jgart <jgart <at> dismail.de>,
 53318-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: [bug#53318] [PATCH v2] gnu: Add go-github-com-go-chi-chi-v5.
Date: Fri, 28 Jan 2022 10:53:15 +0100

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/golang.scm (go-github-com-go-chi-chi-v5): New variable.
>
> ---
>
> Hi Lu and Maxime,
>
> Here's a version two with Maxime's suggestion and a few nitpick fixes in the
> description.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.