GNU logs - #53327, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#53327] [PATCH] gnu: Add mold.
Resent-From: Andreas Rottmann <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 17 Jan 2022 20:31:01 +0000
Resent-Message-ID: <handler.53327.B.164245144713004 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 53327 <at> debbugs.gnu.org
User-agent: mu4e 1.6.10; emacs 27.2
From: Andreas Rottmann <mail@HIDDEN>
Date: Mon, 17 Jan 2022 20:56:49 +0100
Message-ID: <87fspmyuji.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: inline; filename=0001-gnu-Add-mold.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: Patch
Received-SPF: pass client-ip=185.33.11.101; envelope-from=mail@HIDDEN;
 helo=ghost.xx.vu
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

From ec3a1c3c0a742f5a98c3a6d2e86da663f993958e Mon Sep 17 00:00:00 2001
From: Andreas Rottmann <rotty@HIDDEN>
Date: Mon, 17 Jan 2022 21:03:10 +0100
Subject: [PATCH] gnu: Add mold.

* gnu/packages/mold.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk          |  1 +
 gnu/packages/mold.scm | 56 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 gnu/packages/mold.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index eac8652056..91da63703a 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -403,6 +403,7 @@ GNU_SYSTEM_MODULES =3D				\
   %D%/packages/mingw.scm			\
   %D%/packages/microcom.scm			\
   %D%/packages/moe.scm				\
+  %D%/packages/mold.scm				\
   %D%/packages/motti.scm			\
   %D%/packages/monitoring.scm			\
   %D%/packages/mono.scm				\
diff --git a/gnu/packages/mold.scm b/gnu/packages/mold.scm
new file mode 100644
index 0000000000..87c106c069
--- /dev/null
+++ b/gnu/packages/mold.scm
@@ -0,0 +1,56 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright =C2=A9 2022 Andreas Rottmann <rotty@HIDDEN>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages mold)
+  #:use-module ((guix licenses) #:select (agpl3+))
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix utils)
+  #:use-module (gnu packages cmake)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages digest)
+  #:use-module (gnu packages tls))
+
+(define-public mold
+  (package
+    (name "mold")
+    (version "1.0.1")
+    (home-page "https://github.com/rui314/mold")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0ydgcx6vycg7jv4pksv4875cwqdysfm0cpscsdfy0inr5mjrbs8v"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; TODO: Tests require clang and hardcode `cc`
+       #:make-flags (list (string-append "CC=3D" ,(cc-for-target))
+                          (string-append "CXX=3D" ,(cxx-for-target))
+                          (string-append "PREFIX=3D" %output))
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure))))
+    (native-inputs (list cmake))
+    (inputs (list openssl zlib xxhash))
+    (synopsis "Modern Linker")
+    (description "mold is a faster drop-in replacement for existing Unix l=
inkers.")
+    (license agpl3+)))
--=20
2.30.2

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Andreas Rottmann <mail@HIDDEN>
Subject: bug#53327: Acknowledgement ([PATCH] gnu: Add mold.)
Message-ID: <handler.53327.B.164245144713004.ack <at> debbugs.gnu.org>
References: <87fspmyuji.fsf@HIDDEN>
X-Gnu-PR-Message: ack 53327
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 53327 <at> debbugs.gnu.org
Date: Mon, 17 Jan 2022 20:31:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 53327 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
53327: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53327
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#53327] [PATCH] gnu: Add mold.
References: <87fspmyuji.fsf@HIDDEN>
In-Reply-To: <87fspmyuji.fsf@HIDDEN>
Resent-From: zamfofex <zamfofex@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 18 Jan 2022 16:04:02 +0000
Resent-Message-ID: <handler.53327.B53327.164252183521060 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "53327 <at> debbugs.gnu.org" <53327 <at> debbugs.gnu.org>
Date: Tue, 18 Jan 2022 03:47:23 -0300 (BRT)
From: zamfofex <zamfofex@HIDDEN>
Message-ID: <1962407340.961605.1642488443687@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Importance: Normal
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello! I=E2=80=99m not a Guix maintainer, but wouldn=E2=80=99t it make sens=
e to use the mold dependencies from their own packages instead of letting t=
hem be built (statically) from their copies in the mold repository?

Fairly coincidentally, I have actually packaged mold myself before, but I h=
ave not yet sent it as a patch here. You might be able to reuse some of my =
work. See: https://github.com/zamfofex/packages/blob/main/zamfofex/compiler=
s/mold.scm

Message sent to guix-patches@HIDDEN:

Subject: [bug#53327] [PATCH] gnu: Add mold.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 20 Jan 2022 20:17:01 +0000
Resent-Message-ID: <handler.53327.B53327.164270977828551 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Andreas Rottmann <mail@HIDDEN>, 53327 <at> debbugs.gnu.org
Message-ID: <93ded3273884b0afcd5ae9b654351b3568e334c2.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Thu, 20 Jan 2022 21:16:09 +0100
In-Reply-To: <87fspmyuji.fsf@HIDDEN>
References: <87fspmyuji.fsf@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-6pMduGfiApTMnAj5/dJE"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-6pMduGfiApTMnAj5/dJE
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

(*partial* review)

There's a directory 'third_party' with bundled code, can it be removed
(in an origin snippet)?

Andreas Rottmann schreef op ma 17-01-2022 om 20:56 [+0100]:
> +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #f ; TODO: Tests require clang and h=
ardcode `cc`

'clang' =C2=A0can be added to native-inputs and hardcoded =E2=80=98cc=E2=80=
=99 can be
replaced with 'clang' or 'gcc' with 'substitute*'.

> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:make-flags (list (string-append "=
CC=3D" ,(cc-for-target))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 (string-append "CXX=3D" ,(cxx-for-target))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 (string-append "PREFIX=3D" %output))

%output is being phased out, instead use #$output (make sure to add ,#~
before (list ...)).

> +    (inputs (list openssl zlib xxhash))

Why does mold need openssl here?  I don't see the relation between
linking and TLS.

> +=C2=A0=C2=A0=C2=A0 (synopsis "Modern Linker")

Why is =E2=80=98Linker=E2=80=99 capitalised?  Also, as I understand it, the=
 point
of=C2=A0mold is not chasing whatever is considered =E2=80=98modern=E2=80=99=
, but rather
being fast and requiring little memory, albeit at the cost of
supporting less (less targets, no linker scripts, ...).

> +    (description "mold is a faster drop-in replacement for existing
Unix linkers.")

It's a bit short, maybe you could write a bit about memory usage,
limitations

Since 'mold' is said to be very efficient, it might be interesting to
determine if Guix could use 'mold' instead of the linker from
'binutils' by default (with some exceptions like GRUB and Linux which
might actually need GNU ld linker scripts) ... that's more something
for guix-devel and future patches though.

Greetings,
Maxime.

--=-6pMduGfiApTMnAj5/dJE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYenDCRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hoOAP4ib7b0crtdm9UD6bQHntVTtbmd
wL8f31BCJZIKExyEPgD7BKNbo6Y1hUT+FZejwo0o2jA/+HysHEtJw2opcphY1gU=
=HjET
-----END PGP SIGNATURE-----

--=-6pMduGfiApTMnAj5/dJE--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#53327] [PATCH] gnu: Add mold.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 07 Mar 2022 20:55:02 +0000
Resent-Message-ID: <handler.53327.B53327.164668644215351 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 53327
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Andreas Rottmann <mail@HIDDEN>
Cc: Maxime Devos <maximedevos@HIDDEN>, 53327 <at> debbugs.gnu.org
Received: via spool by 53327-submit <at> debbugs.gnu.org id=B53327.164668644215351
          (code B ref 53327); Mon, 07 Mar 2022 20:55:02 +0000
Received: (at 53327) by debbugs.gnu.org; 7 Mar 2022 20:54:02 +0000
Received: from localhost ([127.0.0.1]:54702 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nRKMk-0003zX-Ji
	for submit <at> debbugs.gnu.org; Mon, 07 Mar 2022 15:54:02 -0500
Received: from eggs.gnu.org ([209.51.188.92]:52928)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1nRKMi-0003z2-Ju
 for 53327 <at> debbugs.gnu.org; Mon, 07 Mar 2022 15:54:01 -0500
Received: from [2001:470:142:3::e] (port=51718 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1nRKMc-0004yC-Ga; Mon, 07 Mar 2022 15:53:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=rEmn+Stan4SFW6bss/j31SnP3kQgfEvzMS/aC0ynbo0=; b=JoyUhW/uJxF23HXFob/y
 y1dGAQXaah7CaXws01AGznyORaqUyFy4xfJqgPUEmwrAEt5rnQwFJtfEvIxgiBgjLUrR4cytZMpEW
 PItJYrCWE48kSLxDNeoTM+oMjzn6ZUWx3Q/OTr547E7Xovz05BOKWRxSDvjSG5Fo7EMIAuHPZrAK8
 8fRIOwKIW328Y2uVi0H5yDwLoyfc7hAzjot+PJOfQMFCUHo7+cn94iIdxJXv7wGbu8mReWfIL8/Xe
 7OI8lfqD4V/Cna74m53blsoYt6pAs6IKdOykixIsbTKvdvJ1oYoAns/FSfhluXSMiStQrTVEoC/PZ
 XeNZj82ypnplIg==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61289
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1nRKMc-0000hN-0b; Mon, 07 Mar 2022 15:53:54 -0500
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <87fspmyuji.fsf@HIDDEN>
 <93ded3273884b0afcd5ae9b654351b3568e334c2.camel@HIDDEN>
Date: Mon, 07 Mar 2022 21:53:52 +0100
In-Reply-To: <93ded3273884b0afcd5ae9b654351b3568e334c2.camel@HIDDEN>
 (Maxime Devos's message of "Thu, 20 Jan 2022 21:16:09 +0100")
Message-ID: <87v8wpa3hb.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi Andreas,

Long time no see!  ;-)

Did you have a chance to look into Maxime=E2=80=99s suggestions?

  https://issues.guix.gnu.org/53327

(I have nothing to add to what Maxime wrote.)

TIA,
Ludo=E2=80=99.

Maxime Devos <maximedevos@HIDDEN> skribis:

> Hi,
>
> (*partial* review)
>
> There's a directory 'third_party' with bundled code, can it be removed
> (in an origin snippet)?
>
> Andreas Rottmann schreef op ma 17-01-2022 om 20:56 [+0100]:
>> +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #f ; TODO: Tests require clang and =
hardcode `cc`
>
> 'clang' =C2=A0can be added to native-inputs and hardcoded =E2=80=98cc=E2=
=80=99 can be
> replaced with 'clang' or 'gcc' with 'substitute*'.
>
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:make-flags (list (string-append =
"CC=3D" ,(cc-for-target))
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 (string-append "CXX=3D" ,(cxx-for-target))
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 (string-append "PREFIX=3D" %output))
>
> %output is being phased out, instead use #$output (make sure to add ,#~
> before (list ...)).
>
>> +    (inputs (list openssl zlib xxhash))
>
> Why does mold need openssl here?  I don't see the relation between
> linking and TLS.
>
>> +=C2=A0=C2=A0=C2=A0 (synopsis "Modern Linker")
>
> Why is =E2=80=98Linker=E2=80=99 capitalised?  Also, as I understand it, t=
he point
> of=C2=A0mold is not chasing whatever is considered =E2=80=98modern=E2=80=
=99, but rather
> being fast and requiring little memory, albeit at the cost of
> supporting less (less targets, no linker scripts, ...).
>
>> +    (description "mold is a faster drop-in replacement for existing
> Unix linkers.")
>
> It's a bit short, maybe you could write a bit about memory usage,
> limitations
>
> Since 'mold' is said to be very efficient, it might be interesting to
> determine if Guix could use 'mold' instead of the linker from
> 'binutils' by default (with some exceptions like GRUB and Linux which
> might actually need GNU ld linker scripts) ... that's more something
> for guix-devel and future patches though.
>
> Greetings,
> Maxime.

Last modified: Mon, 7 Mar 2022 21:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.