GNU bug report logs - #53329
Integrated keyboard doesn't work (Lenovo N22)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53329 in the body.
You can then email your comments to 53329 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Ridehalgh <jack <at> ridehalgh.uk>
To: bug-guix <at> gnu.org
Subject: Integrated keyboard doesn't work (Lenovo N22)
Date: Mon, 17 Jan 2022 21:36:55 +0000

Hello,

Due to the bug mentioned here on the Nix tracker
(https://github.com/NixOS/nixpkgs/issues/143223) and elsewhere it is not
possible to use the integrated keyboard on some Braswell laptops.

Would it be possible to include CONFIG_PINCTRL_CHERRYVIEW=y in the kernel
configuration so the keyboard functions correctly on these machines?
Sadly the kernel module does not work when trying to load via modprobe
and these machines are so low powered it's difficult to compile my own kernel.

Many thanks,
Jack

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jack Ridehalgh via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 53329 <at> debbugs.gnu.org
Subject: Re: bug#53329: Integrated keyboard doesn't work (Lenovo N22)
Date: Mon, 17 Jan 2022 18:15:50 -0500

On Mon, Jan 17, 2022 at 09:36:55PM +0000, Jack Ridehalgh via Bug reports for GNU Guix wrote:
> Due to the bug mentioned here on the Nix tracker
> (https://github.com/NixOS/nixpkgs/issues/143223) and elsewhere it is not
> possible to use the integrated keyboard on some Braswell laptops.

Thanks for bringing this report to Guix. There is also this discussion
upstream:

https://bugzilla.kernel.org/show_bug.cgi?id=194945

The upstream bug report suggests that this functionality worked until
Linux 4.9. Could you try with linux-libre-4.4? We have it packaged. I
don't recommend planning to stick with 4.4, but it would be interesting
as a test.

> Would it be possible to include CONFIG_PINCTRL_CHERRYVIEW=y in the kernel
> configuration so the keyboard functions correctly on these machines?

Yes, we can do that.

As shown here, this model is currently built as a module, although the
Bay Trail pinctrl stuff is built-in:

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/linux-libre/5.15-x86_64.conf?id=2c7f2b40e2dbee48075147a87c6cd9b611dc5ba9#n4704

It's been like that for several years.

> Sadly the kernel module does not work when trying to load via modprobe
> and these machines are so low powered it's difficult to compile my own kernel.

As the upstream discussion says, it would be great to understand why
this stuff doesn't work when built as a module. But, Debian builds all
of them into the kernel, and there must be a reason for that.

I'll make a Git branch in our repo that you can pull from to test the
fix.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jack Ridehalgh via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 53329 <at> debbugs.gnu.org
Subject: Re: bug#53329: Integrated keyboard doesn't work (Lenovo N22)
Date: Mon, 17 Jan 2022 21:29:08 -0500

On Mon, Jan 17, 2022 at 06:15:50PM -0500, Leo Famulari wrote:
> I'll make a Git branch in our repo that you can pull from to test the
> fix.

Try pulling from the wip-fix-53329 branch and reconfiguring your system
based on that. I've arranged to have a substitute for the x86_64 kernel
on that branch.

`guix pull --branch=wip-fix-53329 && guix system reconfigure ...`

https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-fix-53329 

Message #20 received at 53329 <at> debbugs.gnu.org (full text, mbox):

From: Jack Ridehalgh <jack <at> ridehalgh.uk>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53329 <at> debbugs.gnu.org
Subject: Re: bug#53329: Integrated keyboard doesn't work (Lenovo N22)
Date: Tue, 18 Jan 2022 23:39:14 +0000

[Message part 1 (text/html, inline)]

Message #25 received at 53329-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jack Ridehalgh <jack <at> ridehalgh.uk>
Cc: 53329-done <at> debbugs.gnu.org
Subject: Re: bug#53329: Integrated keyboard doesn't work (Lenovo N22)
Date: Tue, 18 Jan 2022 20:34:28 -0500

[Message part 1 (text/plain, inline)]

On Tue, Jan 18, 2022 at 11:39:14PM +0000, Jack Ridehalgh wrote:
> 
> I can confirm the built-in kernel module in branch wip-fix-53329 has fixed the
> keyboard issue on my laptop. With regards to trying 4.4-lts, I would get a
> black screen on boot so I couldn't test that.

Great! I've deployed the fix on the "master branch", so you should get
it by default the next time you pull and reconfigure.

You might get a warning from `guix pull` about "downgrades" the next
time you pull, since the wip-fix-53329 branch forked off the main
branch... not sure. Anyways, it's safe to use --allow-downgrades this
time, if necessary. Check here for a reference on the subject:

https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-pull.html

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.