GNU bug report logs - #53351
[PATCH] gnu: Add flamegraph.

Previous Next

Package: guix-patches;

Reported by: Olivier Dion <olivier.dion <at> polymtl.ca>

Date: Tue, 18 Jan 2022 19:22:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53351 in the body.
You can then email your comments to 53351 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#53351; Package guix-patches. (Tue, 18 Jan 2022 19:22:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Olivier Dion <olivier.dion <at> polymtl.ca>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 18 Jan 2022 19:22:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: guix-patches <at> gnu.org
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>
Subject: [PATCH] gnu: Add flamegraph.
Date: Tue, 18 Jan 2022 14:20:15 -0500
* gnu/packages/instrumentation.scm: (flamegraph): New variable.
---
 gnu/packages/instrumentation.scm | 44 +++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm
index 86b80d65ec..49c58ec382 100644
--- a/gnu/packages/instrumentation.scm
+++ b/gnu/packages/instrumentation.scm
@@ -38,12 +38,14 @@ (define-module (gnu packages instrumentation)
   #:use-module (gnu packages tbb)
   #:use-module (gnu packages xml)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
-  #:use-module (guix packages))
+  #:use-module (guix packages)
+  #:use-module (srfi srfi-26))
 
 (define-public babeltrace
   (package
@@ -153,6 +155,46 @@ (define-public dyninst
 with a handful of C++ libraries.")
     (license license:lgpl2.1+)))
 
+(define-public flamegraph
+  (package
+    (name "flamegraph")
+    (version "1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/brendangregg/FlameGraph")
+                    ;; No new version since 2019, but there's still some new
+                    ;; important commits.
+                    (commit "810687f180f3c4929b5d965f54817a5218c9d89b")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1lg02mxzdsm9szn4vcmx76c1bw9gqmxqk8n6v63v03036sc83s22"))))
+
+    (build-system copy-build-system)
+    (arguments
+     `(#:install-plan
+       ',(map (cut list <> "bin/")
+              '("flamegraph.pl"
+                "stackcollapse.pl"
+                "stackcollapse-perf.pl"
+                "stackcollapse-pmc.pl"
+                "stackcollapse-stap.pl"
+                "stackcollapse-instruments.pl"
+                "stackcollapse-vtune.pl"
+                "stackcollapse-jstack.pl"
+                "stackcollapse-gdb.pl"
+                "stackcollapse-go.pl"
+                "stackcollapse-vsprof.pl"
+                "stackcollapse-wcp.pl"))))
+    (inputs (list perl))
+    (home-page "http://www.brendangregg.com/flamegraphs.html")
+    (synopsis "Stack trace visualizer")
+    (description "Flamegraph is a collection of scripts that generate
+interactive SVGs out of traces genated from various tracing tools.  It comes
+with the script @command{flamegraph.pl} and many stackcollapse scripts.")
+    (license license:cddl1.0)))
+
 (define-public lttng-ust
   (package
     (name "lttng-ust")
-- 
2.34.0





Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Thu, 20 Jan 2022 14:03:01 GMT) Full text and rfc822 format available.

Notification sent to Olivier Dion <olivier.dion <at> polymtl.ca>:
bug acknowledged by developer. (Thu, 20 Jan 2022 14:03:01 GMT) Full text and rfc822 format available.

Message #10 received at 53351-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 53351-done <at> debbugs.gnu.org
Subject: Re: bug#53351: [PATCH] gnu: Add flamegraph.
Date: Thu, 20 Jan 2022 15:02:46 +0100
Hello Olivier,

Something went wrong with the patch export format as the commit message
appears as a separate MIME part here. Did you use "git send-email"?

> +    (version "1.0")

I modified the version to: 1.0-1.810687f so that it takes the selected
commit into account.

Pushed as 410211c42388f99c22a7b4140553be35e696400e.

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#53351; Package guix-patches. (Thu, 20 Jan 2022 14:28:02 GMT) Full text and rfc822 format available.

Message #13 received at 53351-done <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 53351-done <at> debbugs.gnu.org
Subject: Re: bug#53351: [PATCH] gnu: Add flamegraph.
Date: Thu, 20 Jan 2022 09:27:30 -0500
On Thu, 20 Jan 2022, Mathieu Othacehe <othacehe <at> gnu.org> wrote:
> Hello Olivier,
>
> Something went wrong with the patch export format as the commit message
> appears as a separate MIME part here. Did you use "git send-email"?

Yes as I always I use git-send-email.  Weird.


>> +    (version "1.0")
>
> I modified the version to: 1.0-1.810687f so that it takes the selected
> commit into account.
>
> Pushed as 410211c42388f99c22a7b4140553be35e696400e.

Thank you!

-- 
Olivier Dion
Polymtl




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 18 Feb 2022 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 68 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.