GNU bug report logs - #53417
reftex-change-label behavior

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53417 in the body.
You can then email your comments to 53417 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph Helfer <joseph.helfer <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: reftex-change-label behavior
Date: Fri, 21 Jan 2022 10:03:41 -0800

[Message part 1 (text/plain, inline)]

Hello,

I apologize if I am not following the usual protocols for bug reports.

This is somewhere between a bug report and a feature request.

The function `reftex-change-label' defined in
`lisp/textmodes/reftex-global.el' asks for the label you want to
change (`from') and what you want to change it to (`to'). The default
value for `from' is the label under point, which is good. I think the
initial input for `to' should be this as well (or rather, whatever was
entered for `from'), since usually, one just wants to make a small
change.

This is a trivial edit. I have attached an appropriate patch for the file
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/textmodes/reftex-global.el?h=emacs-28.0.91

It could be better to add a customizable variable to control this
behavior, but I am not familiar enough with the reftex code to provide
a patch for that now. However, I think the new proposed behavior is
better, and I doubt that any existing code depends on the old
behavior.

Best,
Joj

[reftex-global.el.patch (text/x-patch, attachment)]

Message #8 received at 53417 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Joseph Helfer <joseph.helfer <at> gmail.com>
Cc: 53417 <at> debbugs.gnu.org
Subject: Re: bug#53417: reftex-change-label behavior
Date: Sat, 22 Jan 2022 13:02:02 +0100

Joseph Helfer <joseph.helfer <at> gmail.com> writes:

> The function `reftex-change-label' defined in
> `lisp/textmodes/reftex-global.el' asks for the label you want to
> change (`from') and what you want to change it to (`to'). The default
> value for `from' is the label under point, which is good. I think the
> initial input for `to' should be this as well (or rather, whatever was
> entered for `from'), since usually, one just wants to make a small
> change.

Makes sense to me.  However, we're moving away from using INITIAL-INPUT
for these functions, and instead putting things like this into
DEFAULT-VALUE, which means that the user can hit `M-n' to edit it.  So
I've now done that in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.