GNU bug report logs - #53434
Patches to unbreak many i686 packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53434 in the body.
You can then email your comments to 53434 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: guix-patches <at> gnu.org
Subject: Patches to unbreak many i686 packages
Date: Sat, 22 Jan 2022 03:54:11 +0100

[Message part 1 (text/plain, inline)]

Hi,

This is a patch serie to unbreak many i686 packages.

In it, there is a patch to disable tests for Guix. This is necessary
until the bug #52752 [1] is fixed. Part of it was fixed, but then some
new tests failed and I'm unsure if I've managed to re-open the
bug, or if I should bugreport in a new bug.

I've tested this patch serie by building a system (I've attached the
system.scm) with the following command:
> ./pre-inst-env guix system build -M 1 -c 1 --save-provenance \
> system.scm

I use that system.scm as it worked before as my guix system
installation used that (with gdm enabled and without (debug? #t) and
(wayland? #t) in the gdm configuration).

The big issue I had when doing that work is that at the time I managed
to verify that everything was ok with guix system build, but at that
point new commits are merged into the Guix repository, and after
rebasing, the build takes ages again (usually one day or more) due to
missing substitutes but also because building Guix also hangs with
messages like that:
> GC Warning: Failed to expand heap by 1335296 bytes
> GC Warning: Out of Memory! Heap size: 2617 MiB. Returning NULL!
> Warning: Unwind-only out of memory exception; skipping pre-unwind
> handler.
> Warning: Unwind-only out of memory exception; skipping pre-unwind
> handler.
That is not an issue when building it with 'make' as you restart at the
same point, but when running guix system build you need to restart from
scratch.

So I've tested all that on top of commit
4d7a997ee147acf82c8ca510c0ecd3f520ea74f4 (gnu: Add nhooks.), and right
now I'm still in the process of testing the rebase on top of commit
cadcbbaf655953b28df9466c07b4b5c63d29b00b (gnu: r-bigmelon: Add r-knitr.

I've sent patches for the rebased version.

References:
-----------
[1]http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52752

Denis.

[system.scm (text/x-scheme, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 01/11] gnu: gtk-vnc: Remove dependency on GJS on non-x86_64.
Date: Sat, 22 Jan 2022 03:59:16 +0100

* gnu/packages/gnome.scm (gtk-vnc)[native-inputs]: Provide GJS
only when 'target-x86-64?'.
---
 gnu/packages/gnome.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 088c368054..1ed3acf8ae 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -67,6 +67,7 @@
 ;;; Copyright © 2021 Mathieu Othacehe <othacehe <at> gnu.org>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
 ;;; Copyright © 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -8828,7 +8829,11 @@ (define-public gtk-vnc
     (arguments
      `(#:glib-or-gtk? #t))   ; To wrap binaries and/or compile schemas
     (native-inputs
-     `(("gjs" ,gjs)
+     `(;; GJS depends on Rust, which is x86_64-only so far, so remove the GJS
+       ;; dependency on other platforms (FIXME).
+       ,@(if (target-x86-64?)
+             `(("gjs" ,gjs))
+             '())
        ("glib:bin" ,glib "bin")
        ("gobject-introspection" ,gobject-introspection)
        ("intltool" ,intltool)

base-commit: cadcbbaf655953b28df9466c07b4b5c63d29b00b
-- 
2.34.0

Message #11 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 02/11] gnu: gtk-vnc: Build with correct librsvg.
Date: Sat, 22 Jan 2022 03:59:17 +0100

* gnu/packages/gnome.scm (gtk-vnc)[inputs]: Replace librsvg with
  librsvg-for-system.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1ed3acf8ae..9a88ad556a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8844,7 +8844,7 @@ (define-public gtk-vnc
        ("vala" ,vala)))
     (inputs
      `(("cairo" ,cairo)
-       ("librsvg" ,librsvg)
+       ("librsvg" ,(librsvg-for-system))
        ("glib" ,glib)
        ("gnutls" ,gnutls)
        ("libgcrypt" ,libgcrypt)
-- 
2.34.0

Message #14 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 03/11] gnu: gnome-settings-daemon: Build with correct librsvg.
Date: Sat, 22 Jan 2022 03:59:18 +0100

* gnu/packages/gnome.scm (gnome-settings-daemon)[inputs]:
Replace librsvg with librsvg-for-system.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9a88ad556a..a727ef6f23 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5628,7 +5628,7 @@ (define-public gnome-settings-daemon
            cups
            gsettings-desktop-schemas
            libwacom
-           librsvg
+           (librsvg-for-system)
            xf86-input-wacom
            wayland
            network-manager
-- 
2.34.0

Message #17 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 04/11] gnu: vlc: Build with correct librsvg.
Date: Sat, 22 Jan 2022 03:59:19 +0100

* gnu/packages/video.scm (vlc)[inputs]: Replace librsvg
with librsvg-for-system.
---
 gnu/packages/video.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 461ccbb950..3c105e9b57 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -57,6 +57,7 @@
 ;;; Copyright © 2021 Robin Templeton <robin <at> terpri.org>
 ;;; Copyright © 2021 Aleksandr Vityazev <avityazev <at> posteo.org>
 ;;; Copyright © 2021 Pradana Aumars <paumars <at> courrier.dev>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1910,7 +1911,7 @@ (define-public vlc
        ("libogg" ,libogg)
        ("libpng" ,libpng)
        ("libraw1394" ,libraw1394)
-       ("librsvg" ,librsvg)
+       ("librsvg" ,(librsvg-for-system))
        ("libsamplerate" ,libsamplerate)
        ("libsecret" ,libsecret)
        ("libssh2" ,libssh2)
-- 
2.34.0

Message #20 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 05/11] gnu: python-dbusmock: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:20 +0100

* gnu/packages/python-xyz.scm (python-dbusmock)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/python-xyz.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index eff1c4259b..de73ea2f5b 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -116,6 +116,7 @@
 ;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Aleksandr Vityazev <avityazev <at> posteo.org>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24152,7 +24153,8 @@ (define-public python-dbusmock
                     ((_ . status)
                      (unless (zero? status)
                        (error "`pytest' exited with status"
-                              status))))))))))))
+                              status))))))))))
+       #:tests? ,(not (target-x86-32?))))
     (native-inputs
      (list dbus python-pytest tini which))
     (inputs
-- 
2.34.0

Message #23 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 06/11] gnu: node: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:21 +0100

* gnu/packages/node.scm (node)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/node.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index ce94557a8c..1cccfe9263 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2021, 2022 Philip McGrath <philip <at> philipmcgrath.com>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -101,6 +102,7 @@ (define-public node
                            "--shared-zlib"
                            "--without-snapshot"
                            "--with-intl=system-icu")
+       #:tests? ,(not (target-x86-32?))
        ;; Run only the CI tests.  The default test target requires additional
        ;; add-ons from NPM that are not distributed with the source.
        #:test-target "test-ci-js"
-- 
2.34.0

Message #26 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 07/11] gnu: guix: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:22 +0100

* gnu/packages/package-management.scm (guix)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/package-management.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 05795824b5..bdf58448cf 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Zhu Zihao <all_but_last <at> 163.com>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -202,6 +203,7 @@ (define-public guix
                             ;; for tests.
                             "ac_cv_guix_test_root=/tmp/guix-tests"
                             ,@(if (hurd-target?) '("--with-courage") '()))
+         #:tests? ,(not (target-x86-32?))
          #:parallel-tests? #f         ;work around <http://bugs.gnu.org/21097>
 
          #:modules ((guix build gnu-build-system)
-- 
2.34.0

Message #29 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 08/11] gnu: mesa: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:23 +0100

* gnu/packages/gl.scm (mesa)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/gl.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/gl.scm b/gnu/packages/gl.scm
index fa49679870..fd21e8b7f6 100644
--- a/gnu/packages/gl.scm
+++ b/gnu/packages/gl.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2020 Kei Kebreau <kkebreau <at> posteo.net>
 ;;; Copyright © 2021 Ivan Gankevich <i.gankevich <at> spbu.ru>
 ;;; Copyright © 2021 John Kehayias <john.kehayias <at> protonmail.com>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -348,6 +349,7 @@ (define-public mesa
                   (srfi srfi-1)
                   (guix build utils)
                   (guix build meson-build-system))
+       #:tests? ,(not (target-x86-32?))
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'disable-failing-test
-- 
2.34.0

Message #32 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 09/11] gnu: imath: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:24 +0100

* gnu/packages/graphjics.scm (imath)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/graphics.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index b69ab52aec..6bf42d69d1 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -27,6 +27,7 @@
 ;;; Copyright © 2021 Andy Tai <atai <at> atai.org>
 ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;; Copyright © 2021 Vinicius Monego <monego <at> posteo.net>
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -690,6 +691,8 @@ (define-public imath
        (sha256
         (base32 "1nyld18mf220ghm1vidnfnn0rdns9z5i4l9s66xgd0kfdgarb31f"))))
     (build-system cmake-build-system)
+    (arguments
+     `(#:tests? ,(not (target-x86-32?))))
     (home-page "https://github.com/AcademySoftwareFoundation/Imath")
     (synopsis "Library of math operations for computer graphics")
     (description
-- 
2.34.0

Message #35 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 10/11] gnu: openexr: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:25 +0100

* gnu/packages/graphics.scm (openexr)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/graphics.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 6bf42d69d1..77811402bf 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -1018,7 +1018,8 @@ (define-public openexr
         (base32 "0c9vla0kbsbbhkk42jlbf94nzfb1anqh7dy9b0b3nna1qr6v4bh6"))))
     (build-system cmake-build-system)
     (arguments
-     '(#:phases
+     '(#:tests? ,(not (target-x86-32?))
+       #:phases
        (modify-phases %standard-phases
          ;; /var/tmp does not exist in the Guix build environment
          (add-after 'unpack 'patch-test-directory
-- 
2.34.0

Message #38 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH 11/11] gnu: upower: Disable tests on i686.
Date: Sat, 22 Jan 2022 03:59:26 +0100

* gnu/packages/gnome.scm (upower)[arguments]<#:tests?>:
Conditionally disable tests.
---
 gnu/packages/gnome.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index a727ef6f23..f0024824c9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5469,7 +5469,7 @@ (define-public upower
               "dbusconfdir = $(sysconfdir)/dbus-1/system.d\n"))))))
     (build-system glib-or-gtk-build-system)
     (arguments
-     '(#:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'pre-check
            (lambda* (#:key inputs #:allow-other-keys)
@@ -5479,7 +5479,8 @@ (define-public upower
        #:configure-flags (list "--localstatedir=/var"
                                (string-append "--with-udevrulesdir="
                                               (assoc-ref %outputs "out")
-                                              "/lib/udev/rules.d"))))
+                                              "/lib/udev/rules.d"))
+       #:tests? ,(not (target-x86-32?))))
     (native-inputs
      (list autoconf
            automake
-- 
2.34.0

Message #41 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>, 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] Patches to unbreak many i686 packages
Date: Sat, 22 Jan 2022 13:38:18 +0100

[Message part 1 (text/plain, inline)]

Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 03:54 [+0100]:
> Hi,
> 
> This is a patch serie to unbreak many i686 packages.
> [...]

I noticed that for quite a few packages, tests are disabled.
That might allow builds to ‘succeed’, but presumably these test
failures indicate real problems (otherwise, why have a test suite?),
so this only ignores potential brokenness without addressing it.

Before ignoring tests, it would be necessary to investigate the cause
of the test failures.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #44 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] Patches to unbreak many i686 packages
Date: Sat, 22 Jan 2022 17:49:37 +0100

[Message part 1 (text/plain, inline)]

On Sat, 22 Jan 2022 13:38:18 +0100
Maxime Devos <maximedevos <at> telenet.be> wrote:

> Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 03:54 [+0100]:
> > Hi,
> > 
> > This is a patch serie to unbreak many i686 packages.
> > [...]
> 
> I noticed that for quite a few packages, tests are disabled.
> That might allow builds to ‘succeed’, but presumably these test
> failures indicate real problems (otherwise, why have a test suite?),
> so this only ignores potential brokenness without addressing it.
> 
> Before ignoring tests, it would be necessary to investigate the cause
> of the test failures.
As I see it, we have a bit of chicken and egg issue here: If the
test fails, we have no substitutes, and because of that, fixing packages
where test fails become extremely time consuming, and so way less
likely to happen. 

And even if that work to fix tests is not done, if tests are disabled
we end up with a somewhat working i686 system, whereas if tests are not
disabled we end up with a more and more broken i686 probably with less
and less people willing to fix it.

So my idea here was to first get the tests disabled and then to fix the
root causes. And that can takes some time to do too, as not only we
need to understand why they are failing and fix them, but also need to
upstream the patches and backport them in Guix or update the packages to
the new versions where this is fixed.

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #47 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] Patches to unbreak many i686 packages
Date: Sat, 22 Jan 2022 20:19:45 +0100

[Message part 1 (text/plain, inline)]

On Sat, 22 Jan 2022 17:49:37 +0100
Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> wrote:

> On Sat, 22 Jan 2022 13:38:18 +0100
> Maxime Devos <maximedevos <at> telenet.be> wrote:
> 
> > Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 03:54 [+0100]:
> > > Hi,
> > > 
> > > This is a patch serie to unbreak many i686 packages.
> > > [...]
> > 
> > I noticed that for quite a few packages, tests are disabled.
> > That might allow builds to ‘succeed’, but presumably these test
> > failures indicate real problems (otherwise, why have a test suite?),
> > so this only ignores potential brokenness without addressing it.
> > 
> > Before ignoring tests, it would be necessary to investigate the
> > cause of the test failures.
> As I see it, we have a bit of chicken and egg issue here: If the
> test fails, we have no substitutes, and because of that, fixing
> packages where test fails become extremely time consuming, and so way
> less likely to happen. 
Would it make sense if in parallel, if they don't exist yet, I open
new bugs for each package that fails test or fail to compile on i686?

This way we would at least have the log of the failing tests or
builds and we could also manage to coordinate work on fixing these
better.

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #50 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] Patches to unbreak many i686 packages
Date: Sat, 22 Jan 2022 20:32:37 +0100

[Message part 1 (text/plain, inline)]

Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 20:19 [+0100]:
> This way we would at least have the log of the failing tests or

I cannot spend much time building every package, 
but if you provide the build logs, I can try to
determine what the cause is.

E.g.,  I built upower of i686-linux today, and the build log
contained:

> # UPower-DEBUG: deferring as others queued
> # UPower-DEBUG: limiting data to last 10 seconds
> # UPower-DEBUG: length of array (before) 3
> # UPower-DEBUG: limiting data to last 10 seconds
> # UPower-DEBUG: length of array (before) 3
> # UPower-DEBUG: Using a x division of 2.000000
> (first=1642875457,last=1642875453)
> # UPower-DEBUG: length of array (after) 3
> **
> UPower:ERROR:up-self-test.c:218:up_test_history_func: assertion
> failed (array->len == 2): (3 == 2)
> Bail out! UPower:ERROR:up-self-test.c:218:up_test_history_func:
> assertion failed (array->len == 2): (3 == 2)
> FAIL up-self-test (exit status: 134)


1642875457 > 1642875453, so first > last, which is suspect.

Would this be a 32-bit/64-bit issue?

(expt 2 32) is 4294967296 which is as long as 1642875457 and
1642875453, so this seems like an overflow issue, so maybe?
To be investigated ... (I'll look at the source code later).

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #53 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] Patches to unbreak many i686 packages
Date: Sat, 22 Jan 2022 20:34:42 +0100

[Message part 1 (text/plain, inline)]

Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 20:19 [+0100]:
> Would it make sense if in parallel, if they don't exist yet, I open
> new bugs for each package that fails test or fail to compile on i686?
> 
> This way we would at least have the log of the failing tests or
> builds and we could also manage to coordinate work on fixing these
> better.

Seems like a plan to me, though I would add comments like

#:tests? ,(not (target-x86-32?)) ; see <https://issues.guix.gnu.org/....>

to avoid giving the impression that simply ignoring test failures
is acceptable.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #56 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Sun, 23 Jan 2022 22:32:36 +0100

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> E.g.,  I built upower of i686-linux today, and the build log
> contained:
>
>> # UPower-DEBUG: deferring as others queued
>> # UPower-DEBUG: limiting data to last 10 seconds
>> # UPower-DEBUG: length of array (before) 3
>> # UPower-DEBUG: limiting data to last 10 seconds
>> # UPower-DEBUG: length of array (before) 3
>> # UPower-DEBUG: Using a x division of 2.000000
>> (first=1642875457,last=1642875453)
>> # UPower-DEBUG: length of array (after) 3
>> **
>> UPower:ERROR:up-self-test.c:218:up_test_history_func: assertion
>> failed (array->len == 2): (3 == 2)
>> Bail out! UPower:ERROR:up-self-test.c:218:up_test_history_func:
>> assertion failed (array->len == 2): (3 == 2)
>> FAIL up-self-test (exit status: 134)
>
>
> 1642875457 > 1642875453, so first > last, which is suspect.
>
> Would this be a 32-bit/64-bit issue?
>
> (expt 2 32) is 4294967296 which is as long as 1642875457 and
> 1642875453, so this seems like an overflow issue, so maybe?
> To be investigated ... (I'll look at the source code later).

I remember investigating it while on ‘core-updates-frozen’… and
eventually forgetting about it.  :-/

I think the pragmatic approach in such situations is to:

  1. Report the test failure upstream, including the test log;

  2. Skip tests (ideally selectively) for i686-linux, adding a link to
     the upstream bug report.

That makes sure we move forward while not just sweeping issues under the
carpet.

Ludo’.

Message #59 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Sun, 23 Jan 2022 22:35:41 +0100

Hi,

Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> skribis:

> * gnu/packages/package-management.scm (guix)[arguments]<#:tests?>:
> Conditionally disable tests.

There are no test failures as of
ee6bf00b2d89f6acab55b7a82896d99e39c1229b:

  https://ci.guix.gnu.org/log/gmmri6v3vhzwngwshk9y5h57xkpkj2yk-guix-1.3.0-23.a27e47f

If there were test failures, surely we could discuss it with upstream.
;-)

Ludo’.

Message #62 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Sun, 23 Jan 2022 23:39:16 +0100

Hi,

I’ve applied the librsvg/GJS-related ones as
b45bbe561a18fffa226f36d0e8cfb9b3fddbe9d0.

Let’s look at the other issues in the coming days.

Thanks,
Ludo’.

Message #65 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>, 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] [PATCH 11/11] gnu: upower: Disable tests on i686.
Date: Mon, 24 Jan 2022 11:43:25 +0100

[Message part 1 (text/plain, inline)]

Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 03:59 [+0100]:
> * gnu/packages/gnome.scm (upower)[arguments]<#:tests?>:

Reported upstream at
<https://gitlab.freedesktop.org/upower/upower/-/issues/167>.

[signature.asc (application/pgp-signature, inline)]

Message #68 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Subject: Re: [PATCH 09/11] gnu: imath: Disable tests on i686.
Date: Wed, 26 Jan 2022 02:06:34 +0100

[Message part 1 (text/plain, inline)]

On Sat, 22 Jan 2022 03:59:24 +0100
Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> wrote:

> * gnu/packages/graphjics.scm (imath)[arguments]<#:tests?>:
> Conditionally disable tests.
This one still fails without this patch. I've attached the build log
for now.

Denis.

[fgm9h86nqk6xmwhbcc7f042jqawnyf-imath-3.1.3.drv.bz2 (application/x-bzip, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #71 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] [PATCH 09/11] gnu: imath: Disable tests on i686.
Date: Tue, 25 Jan 2022 22:17:30 -0500

On Wed, Jan 26, 2022 at 02:06:34AM +0100, Denis 'GNUtoo' Carikli wrote:
> On Sat, 22 Jan 2022 03:59:24 +0100
> Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> wrote:
> 
> > * gnu/packages/graphjics.scm (imath)[arguments]<#:tests?>:
> > Conditionally disable tests.
> This one still fails without this patch. I've attached the build log
> for now.

We should find out if imath is supposed to work on 32-bit hardware.

Considering its use case, I wouldn't be surprised if it's 64-bit only.

Message #74 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 53434 <at> debbugs.gnu.org
Subject: Re: [PATCH 08/11] gnu: mesa: Disable tests on i686.
Date: Wed, 26 Jan 2022 04:27:18 +0100

[Message part 1 (text/plain, inline)]

On Sat, 22 Jan 2022 03:59:23 +0100
Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> wrote:

> * gnu/packages/gl.scm (mesa)[arguments]<#:tests?>:
> Conditionally disable tests.
Without that patch mesa now seems to build fine.

When trying to build it I have:
$ ./pre-inst-env guix build --check --no-substitutes --rounds=2 mesa
The following graft will be made:
   /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv
applying 3 grafts for /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv ...
grafting '/gnu/store/0kg54299yqzv9p1yfhph871qqpin1rkp-mesa-21.3.2-bin' -> '/gnu/store/hvhc1k2aks02zhjzw6s76m7lq3s8qnz5-mesa-21.3.2-bin'...
grafting '/gnu/store/q8fsnspfd3ajwrrjhnsznjp2wmm4f6bc-mesa-21.3.2' -> '/gnu/store/i8jghxbpzp2vf3rk0wd4pks0pc9qbjd3-mesa-21.3.2'...
successfully built /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv
successfully built /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv
applying 3 grafts for /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv ...
grafting '/gnu/store/0kg54299yqzv9p1yfhph871qqpin1rkp-mesa-21.3.2-bin' -> '/gnu/store/hvhc1k2aks02zhjzw6s76m7lq3s8qnz5-mesa-21.3.2-bin'...
grafting '/gnu/store/q8fsnspfd3ajwrrjhnsznjp2wmm4f6bc-mesa-21.3.2' -> '/gnu/store/i8jghxbpzp2vf3rk0wd4pks0pc9qbjd3-mesa-21.3.2'...
successfully built /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv
successfully built /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv
successfully built /gnu/store/gaf97xclvim3x4iak44hrwrj1hr2sczv-mesa-21.3.2.drv
/gnu/store/hvhc1k2aks02zhjzw6s76m7lq3s8qnz5-mesa-21.3.2-bin
/gnu/store/i8jghxbpzp2vf3rk0wd4pks0pc9qbjd3-mesa-21.3.2

But using --no-grafts make it really builds:
$ ./pre-inst-env guix build --check --no-substitutes --rounds=2 --no-grafts mesa
The following derivation will be built:
   /gnu/store/f9inawjwgjrb56d3i823ph558iqvc9z9-mesa-21.3.2.drv
building /gnu/store/f9inawjwgjrb56d3i823ph558iqvc9z9-mesa-21.3.2.drv...
starting phase `set-SOURCE-DATE-EPOCH'
phase `set-SOURCE-DATE-EPOCH' succeeded after 0.0 seconds
[...]

And the first build succeeded (I aborted after that as it takes a long
time to build).

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #77 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434 <at> debbugs.gnu.org
Subject: Re: [bug#53434] [PATCH 09/11] gnu: imath: Disable tests on i686.
Date: Tue, 25 Jan 2022 22:44:46 -0500

On Wed, Jan 26, 2022 at 02:06:34AM +0100, Denis 'GNUtoo' Carikli wrote:
> > * gnu/packages/graphjics.scm (imath)[arguments]<#:tests?>:
> > Conditionally disable tests.
> This one still fails without this patch. I've attached the build log
> for now.

The salient parts of the log

------
    dir ~ (0 0 -1), result = 0
  transform box by matrix
ImathTest: /tmp/guix-build-imath-3.1.3.drv-0/source/src/ImathTest/testBoxAlgo.cpp:816: void {anonymous}::boxMatrixTransform(): Assertion `b21 == b2' failed.

      Start 31: Imath.testBox
------

... and ...

------
    extendBy() point for type V2i64
    extendBy() point for type V2f 
ImathTest: /tmp/guix-build-imath-3.1.3.drv-0/source/src/ImathTest/testBox.cpp:257: void {anonymous}::testExtendByPoint(const char*) [with T = Imath_3_1::Vec2<float>]: Assertion `b.min == min && b.max == max' failed. 

      Start 32: Imath.testProcrustes
32/36 Test #32: Imath.testProcrustes ....................   Passed    0.01 sec 
      Start 33: Imath.testTinySVD
------

Upstream report:

https://github.com/AcademySoftwareFoundation/Imath/issues/226

Message #80 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Wed, 16 Feb 2022 14:53:53 +0100

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 03:59 [+0100]:
>> * gnu/packages/gnome.scm (upower)[arguments]<#:tests?>:
>
> Reported upstream at
> <https://gitlab.freedesktop.org/upower/upower/-/issues/167>.

This reminds me that we had to build with ‘-fexcess-precision=standard’
many packages on i686 since the switch to GCC 10.  Would it help?

However, it turns out there upower builds fine currently:

--8<---------------cut here---------------start------------->8---
$ guix describe
Generacio 204   Feb 15 2022 10:48:52    (nuna)
  guix 8d472e9
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8d472e9314052403ad548f92ca6c10f9c961a087
$ guix weather upower -s i686-linux
computing 1 package derivations for i686-linux...
looking for 1 store items on https://ci.guix.gnu.org...
https://ci.guix.gnu.org
  100.0% substitutes available (1 out of 1)
  at least 0.7 MiB of nars (compressed)
  1.1 MiB on disk (uncompressed)
  0.168 seconds per request (0.2 seconds in total)
  5.9 requests per second

  4 queued builds
      aarch64-linux: 2 (50.0%)
      powerpc64le-linux: 2 (50.0%)
  build rate: 56.46 builds per hour
      aarch64-linux: 19.60 builds per hour
      x86_64-linux: 18.75 builds per hour
      powerpc64le-linux: 8.86 builds per hour
      i686-linux: 9.33 builds per hour
looking for 1 store items on https://bordeaux.guix.gnu.org...
https://bordeaux.guix.gnu.org
  100.0% substitutes available (1 out of 1)
  0.2 MiB of nars (compressed)
  1.1 MiB on disk (uncompressed)
  0.126 seconds per request (0.1 seconds in total)
  7.9 requests per second
  (continuous integration information unavailable)
$ guix build upower -s i686-linux --no-grafts
/gnu/store/dcddizvvl599s6zgwk951gz7frk2g2gh-upower-0.99.13
$ guix build upower -s i686-linux --no-grafts -d
/gnu/store/x78bb68amwgb7znvbbmhg5pxrlnj9p53-upower-0.99.13.drv
--8<---------------cut here---------------end--------------->8---

Did the problem sort itself?

Thanks,
Ludo’.

Message #83 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Wed, 16 Feb 2022 17:38:33 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op wo 16-02-2022 om 14:53 [+0100]:
> Hi,
> 
> Maxime Devos <maximedevos <at> telenet.be> skribis:
> 
> > Denis 'GNUtoo' Carikli schreef op za 22-01-2022 om 03:59 [+0100]:
> > > * gnu/packages/gnome.scm (upower)[arguments]<#:tests?>:
> > 
> > Reported upstream at
> > <https://gitlab.freedesktop.org/upower/upower/-/issues/167>.

> However, it turns out there upower builds fine currently:
> [...]
> Did the problem sort itself?

The test failure was somewhat non-deterministic.

> This reminds me that we had to build with ‘-fexcess-
> precision=standard’
> many packages on i686 since the switch to GCC 10.  Would it help?

Possibly, but perhaps backporting the upstream fix that largely avoids
floating-point arithmetic would be better?
(See
<https://gitlab.freedesktop.org/upower/upower/-/merge_requests/101>.)

Also, looks like there's a '0.99.15' release now
(https://gitlab.freedesktop.org/upower/upower/-/tree/v0.99.15),
so perhaps we could just update upower?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #86 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Thu, 17 Feb 2022 11:40:29 +0100

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Possibly, but perhaps backporting the upstream fix that largely avoids
> floating-point arithmetic would be better?
> (See
> <https://gitlab.freedesktop.org/upower/upower/-/merge_requests/101>.)

Yes, that’s even better.

> Also, looks like there's a '0.99.15' release now
> (https://gitlab.freedesktop.org/upower/upower/-/tree/v0.99.15),
> so perhaps we could just update upower?

Yes, we can do that on master.  Do you want to give it a try?

Thanks,
Ludo’.

Message #89 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Thu, 17 Feb 2022 21:30:09 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op do 17-02-2022 om 11:40 [+0100]:
> Yes, we can do that on master.  Do you want to give it a try?

Done.  I'll send the patches once building the dependencies again (as a
test) succeeds.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #92 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Fri, 18 Feb 2022 08:50:45 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op do 17-02-2022 om 11:40 [+0100]:
> Yes, we can do that on master.  Do you want to give it a try?

See attachment! I verified that:

* upower builds: ./pre-inst-env guix build upower
* upower builds on i686:
 ./pre-inst-env guix build upower --system=i686-linux
* linting (almost) succeeds:

  ./pre-inst-env guix lint upower umockdev
  [...] upower <at> 0.99.15: label 'glib' does not match package name 'glib:bin'

  I just did `(,glib "bin") (new-input style), so this seems more a problem
  of the linter or whatever code is reponsible for constructing labels to me.

  [...]: upower <at> 0.99.15: line 5457 is way too long (101 characters)

  It contains a long URL, so not much that can be done here.

* the dependents of upower and umockdev build:

  ./pre-inst-env guix refresh -l upower umockdev
  [...]: thermald <at> 2.4.7 gnome-power-manager <at> 3.32.0 rhythmbox <at> 3.4.4 eiciel <at> 0.9.13.1 gnome-tweaks <at> 40.0 gpaste <at> 3.42.2 gnome-shell-extension-gsconnect <at> 33 arc-theme <at> 20210412 numix-gtk-theme <at> 2.6.7 gnome <at> 41.0 eolie <at> 0.9.101 wmbattery <at> 2.54 mate <at> 1.24.1 mixxx <at> 2.3.2 xfce <at> 4.16.0 usbguard <at> 0.7.8
  ./pre-inst-env guix build thermald <at> 2.4.7 gnome-power-manager <at> 3.32.0 rhythmbox <at> 3.4.4 eiciel <at> 0.9.13.1 gnome-tweaks <at> 40.0 gpaste <at> 3.42.2 gnome-shell-extension-gsconnect <at> 33 arc-theme <at> 20210412 numix-gtk-theme <at> 2.6.7 gnome <at> 41.0 eolie <at> 0.9.101 wmbattery <at> 2.54 mate <at> 1.24.1 mixxx <at> 2.3.2 xfce <at> 4.16.0 usbguard <at> 0.7.8

  This took to long to run it to the end, but no build failures so far

It has _not_ been verified whether this upower is usable for system services!

Some remarks:

* "guix refresh -u upower" did not work completely because the 'commit' field
  was

 (string-append "UPOWER_" (string-map (match-lambda (#\. #\_)
                                        (chr chr))
                                      version))

  before the update and (string-append "v" version) after the update,
  which (guix upstream) does not not how to change.

  If the tag was replaced by the commit it referred to, this would not
  have been necessary.

Greetings,
Maxime.

[0001-gnu-upower-Make-it-auto-updatable.patch (text/x-patch, attachment)]

[0002-gnu-upower-Update-to-0.99.15.patch (text/x-patch, attachment)]

[0003-gnu-umockdev-Use-G-expressions.patch (text/x-patch, attachment)]

[0004-gnu-umockdev-Reference-env-and-sh-by-absolute-path.patch (text/x-patch, attachment)]

[0005-gnu-umockdev-Reference-libumockdev-by-absolute-path.patch (text/x-patch, attachment)]

[0006-gnu-upower-Remove-obsolete-phase.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #95 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53434 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Fri, 18 Feb 2022 14:43:57 +0100

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op do 17-02-2022 om 11:40 [+0100]:
>> Yes, we can do that on master.  Do you want to give it a try?
>
> See attachment! I verified that:

Wonderful.  I pushed the whole series:

  0d1a6cffaf gnu: upower: Remove obsolete phase
  4262919ea9 gnu: umockdev: Reference libumockdev by absolute path.
  569d7ba38c gnu: umockdev: Reference 'env' and 'sh' by absolute path.
  33f2e862c7 gnu: umockdev: Use G-expressions.
  b3d7eae08e gnu: upower: Update to 0.99.15.
  7168148abe gnu: upower: Make it auto-updatable.

Thank you!

Ludo’.

Message #98 received at 53434 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53434 <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Sat, 23 Apr 2022 21:54:49 +0200

[Message part 1 (text/plain, inline)]

On Wed, 16 Feb 2022 14:53:53 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Did the problem sort itself?
I think so. Beside gdm that started to really depend on rust, all the
other packages I mentioned now build fine.

Should I send a mail to close the bug?

PS: In case this mail is somehow duplicated I already sent a similar
    mail months ago but it seems to have never arrived so there might
    have been an issue with my mail client.

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #103 received at 53434-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 53434-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#53434: Patches to unbreak many i686 packages
Date: Thu, 28 Apr 2022 23:35:34 +0200

Hi,

Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> skribis:

> On Wed, 16 Feb 2022 14:53:53 +0100
> Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> Did the problem sort itself?
> I think so. Beside gdm that started to really depend on rust, all the
> other packages I mentioned now build fine.
>
> Should I send a mail to close the bug?

Doing it right now.  :-)

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.