GNU bug report logs - #53472
[PATCH] gnu: Add emacs-nim-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53472 in the body.
You can then email your comments to 53472 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "(unmatched-parenthesis" <paren <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: "\(unmatched-parenthesis" <paren <at> disroot.org>
Subject: [PATCH] gnu: Add emacs-nim-mode
Date: Sun, 23 Jan 2022 13:38:37 +0000

* gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8edbfc5a3d..d2508748a9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -107,6 +107,7 @@
 ;;; Copyright © 2021 Brian Kubisiak <brian <at> kubisiak.com>
 ;;; Copyright © 2021, 2022 Taiju HIGASHI <higashi <at> taiju.info>
 ;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
+;;; Copyright © 2022 (unmatched parenthesis <paren <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29837,3 +29838,31 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-nim-mode
+  ;; The last tag was 0.4.1 in 2017. There have been many more commits since then.
+  (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
+        (revision "0"))
+    (package
+      (name "emacs-nim-mode")
+      (version (git-version "0.4.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/nim-lang/nim-mode")
+               (commit version)))
+         (sha256
+          (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/nim-lang/nim-mode")
+      (synopsis "Major mode for editing Nim source code")
+      (description "This package provides major modes for Nim:
+@itemize
+@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
+@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
+@item File outline by procedures
+@item Indentation and line breaking (alpha)
+@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
+@end itemize")
+      (license license:gpl3+))))
-- 
2.34.0

Message #8 received at 53472 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "(unmatched-parenthesis" <paren <at> disroot.org>, 53472 <at> debbugs.gnu.org
Subject: Re: [bug#53472] [PATCH] gnu: Add emacs-nim-mode
Date: Sun, 23 Jan 2022 17:21:11 +0100

[Message part 1 (text/plain, inline)]

(unmatched-parenthesis via Guix-patches via schreef op zo 23-01-2022 om
13:38 [+0000]:
> +      (version (git-version "0.4.1" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/nim-lang/nim-mode")
> +               (commit version)))

I don't think there's a tag by the name "0.4.1-23.744e076"
in the git repo.  Try (git-reference ... (commit commit)) instead.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53472 <at> debbugs.gnu.org (full text, mbox):

From: paren <at> disroot.org
To: "Maxime Devos" <maximedevos <at> telenet.be>
Cc: 53472 <at> debbugs.gnu.org
Subject: Re: [bug#53472] [PATCH] gnu: Add emacs-nim-mode
Date: Mon, 24 Jan 2022 18:30:12 +0000

> I don't think there's a tag by the name "0.4.1-23.744e076"
> in the git repo. Try (git-reference ... (commit commit)) instead.

Oops! I automatically wrote (commit version) out of habit :)
One moment...

Message #14 received at 53472 <at> debbugs.gnu.org (full text, mbox):

From: "(unmatched-parenthesis" <paren <at> disroot.org>
To: 53472 <at> debbugs.gnu.org
Cc: "\(unmatched-parenthesis" <paren <at> disroot.org>
Subject: [PATCH v2] gnu: Add emacs-nim-mode
Date: Mon, 24 Jan 2022 18:40:37 +0000

Sorry about that!

* gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8edbfc5a3d..34ac0d4dae 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -107,6 +107,7 @@
 ;;; Copyright © 2021 Brian Kubisiak <brian <at> kubisiak.com>
 ;;; Copyright © 2021, 2022 Taiju HIGASHI <higashi <at> taiju.info>
 ;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
+;;; Copyright © 2022 (unmatched parenthesis <paren <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29837,3 +29838,30 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-nim-mode
+  (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
+        (revision "0"))
+    (package
+      (name "emacs-nim-mode")
+      (version (git-version "0.4.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/nim-lang/nim-mode")
+               (commit commit)))
+         (sha256
+          (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w"))))
+      (build-system emacs-build-system)
+      (home-pace "https://github.com/nim-lang/nim-mode")
+      (synosis "Major mode for editing Nim source code")
+      (description "This package provides major modes for Nim:
++@itemize
++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
++@item File outline by procedures
++@item Indentation and line breaking (alpha)
++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
++@end itemize")
+      (license license:gpl3+))))
-- 
2.34.0

Message #17 received at 53472 <at> debbugs.gnu.org (full text, mbox):

From: "(unmatched-parenthesis" <paren <at> disroot.org>
To: 53472 <at> debbugs.gnu.org
Cc: "\(unmatched-parenthesis" <paren <at> disroot.org>
Subject: [PATCH v3] gnu: Add emacs-nim-mode
Date: Mon, 24 Jan 2022 19:00:58 +0000

Aren't typos fun.

* gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8edbfc5a3d..e7a7edbd14 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -107,6 +107,7 @@
 ;;; Copyright © 2021 Brian Kubisiak <brian <at> kubisiak.com>
 ;;; Copyright © 2021, 2022 Taiju HIGASHI <higashi <at> taiju.info>
 ;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
+;;; Copyright © 2022 (unmatched parenthesis <paren <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29837,3 +29838,30 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-nim-mode
+  (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
+        (revision "0"))
+    (package
+      (name "emacs-nim-mode")
+      (version (git-version "0.4.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/nim-lang/nim-mode")
+               (commit commit)))
+         (sha256
+          (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/nim-lang/nim-mode")
+      (synopsis "Major mode for editing Nim source code")
+      (description "This package provides major modes for Nim:
++@itemize
++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
++@item File outline by procedures
++@item Indentation and line breaking (alpha)
++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
++@end itemize")
+      (license license:gpl3+))))
-- 
2.34.0

Message #20 received at 53472 <at> debbugs.gnu.org (full text, mbox):

From: "(unmatched-parenthesis" <paren <at> disroot.org>
To: 53472 <at> debbugs.gnu.org
Cc: "\(unmatched-parenthesis" <paren <at> disroot.org>
Subject: [PATCH v4] gnu: Add emacs-nim-mode
Date: Mon, 24 Jan 2022 20:12:47 +0000

Well, that was embarrassing... the package was completely wrong and `guix package -i emacs-nim-mode` would have actually installed `emacs-fennel-mode`... Always test things, I guess.

* gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 46 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8edbfc5a3d..78650d0c52 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -107,6 +107,7 @@
 ;;; Copyright © 2021 Brian Kubisiak <brian <at> kubisiak.com>
 ;;; Copyright © 2021, 2022 Taiju HIGASHI <higashi <at> taiju.info>
 ;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
+;;; Copyright © 2022 (unmatched parenthesis <paren <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -29837,3 +29838,48 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-commenter
+  (package
+    (name "emacs-commenter")
+    (version "0.5.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/yuutayamada/commenter/archive/refs/tags/v" version ".tar.gz"))
+       (sha256
+        (base32 "1n9m8f4gflb0c3nh98nkmsqzscyf5d1p1gcz8apskkmf7z0z0q2j"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/yuutayamada/commenter")
+    (synopsis "Allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")
+    (description "This package allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")
+    (license license:gpl3+)))
+
+(define-public emacs-nim-mode
+  (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
+        (revision "0"))
+    (package
+      (name "emacs-nim-mode")
+      (version (git-version "0.4.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/nim-lang/nim-mode")
+               (commit commit)))
+         (sha256
+          (base32 "0jjrjsks3q8qpipxcqdkm8pi3pjnkcxcydspbf0rkvy3x6i5mwkv"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-commenter emacs-epc))
+      (home-page "https://github.com/nim-lang/nim-mode")
+      (synopsis "Major mode for editing Nim source code")
+      (description "This package provides major modes for Nim:
++@itemize
++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
++@item File outline by procedures
++@item Indentation and line breaking (alpha)
++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
++@end itemize")
+      (license license:gpl3+))))
-- 
2.34.0

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "(unmatched-parenthesis via Guix-patches" via <guix-patches <at> gnu.org>
Cc: 53472 <at> debbugs.gnu.org, "\(unmatched-parenthesis" <paren <at> disroot.org>
Subject: Re: [bug#53472] [PATCH v4] gnu: Add emacs-nim-mode
Date: Fri, 28 Jan 2022 08:55:26 +0100

Hello,

"(unmatched-parenthesis via Guix-patches" via <guix-patches <at> gnu.org>
writes:

> * gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.

Thank you.

You add both emacs-nim-mode and emacs-commenter. Could you split the
patch into two parts?
> +       (uri (string-append "https://github.com/yuutayamada/commenter/archive/refs/tags/v" version ".tar.gz"))

These URI are not stable. You should use git-fetch with commit
(string-append "v" version) instead.

> +       (sha256
> +        (base32 "1n9m8f4gflb0c3nh98nkmsqzscyf5d1p1gcz8apskkmf7z0z0q2j"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/yuutayamada/commenter")
> +    (synopsis "Allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")

The synopsis is too long:

  "Set both single- and multi-line comment variables in Emacs"

> +    (description "This package allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")

I suggest to drop the "etc." since there is "like" before.

  "This Emacs package sets both single- and multi-line comment variables like @code{comment-start} or @code{comment-end}."

> +(define-public emacs-nim-mode
> +  (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
> +        (revision "0"))

Since you're not using a tagged commit, could you put a comment above
the let binding explaining why?

> +      (synopsis "Major mode for editing Nim source code")

I would add "Emacs": "Emacs major mode for editing Nim source code"

> +      (description "This package provides major modes for Nim:
> ++@itemize
> ++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
> ++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
> ++@item File outline by procedures
> ++@item Indentation and line breaking (alpha)
> ++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
> ++@end itemize")

I suggest:

  This package includes major modes for Nim. In particular, it provides
  syntax highlighting for Nim code, Nimble configuration files, and
  @file{nim.cfg}, outlining features, a dedicated compilation command,
  indentation and line breaking.

  It also implements integration with @code{nimsuggest}, the Nim linting
  and completion server, although this is currently unstable.
 
> +      (license license:gpl3+))))

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #29 received at 53472 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: paren <at> disroot.org
Cc: 53472 <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: bug#53472: [PATCH] gnu: Add emacs-nim-mode
Date: Mon, 07 Mar 2022 21:51:23 +0100

Hi unmatched-parenthesis,

I know it’s been a while already, but did you have a chance to look into
making the changes Nicolas suggested?

  https://issues.guix.gnu.org/53472

TIA,
Ludo’.

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

> Hello,
>
> "(unmatched-parenthesis via Guix-patches" via <guix-patches <at> gnu.org>
> writes:
>
>> * gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable.
>
> Thank you.
>
> You add both emacs-nim-mode and emacs-commenter. Could you split the
> patch into two parts?
>> +       (uri (string-append "https://github.com/yuutayamada/commenter/archive/refs/tags/v" version ".tar.gz"))
>
> These URI are not stable. You should use git-fetch with commit
> (string-append "v" version) instead.
>
>> +       (sha256
>> +        (base32 "1n9m8f4gflb0c3nh98nkmsqzscyf5d1p1gcz8apskkmf7z0z0q2j"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/yuutayamada/commenter")
>> +    (synopsis "Allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")
>
> The synopsis is too long:
>
>   "Set both single- and multi-line comment variables in Emacs"
>
>> +    (description "This package allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.")
>
> I suggest to drop the "etc." since there is "like" before.
>
>   "This Emacs package sets both single- and multi-line comment variables like @code{comment-start} or @code{comment-end}."
>
>> +(define-public emacs-nim-mode
>> +  (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8")
>> +        (revision "0"))
>
> Since you're not using a tagged commit, could you put a comment above
> the let binding explaining why?
>
>> +      (synopsis "Major mode for editing Nim source code")
>
> I would add "Emacs": "Emacs major mode for editing Nim source code"
>
>> +      (description "This package provides major modes for Nim:
>> ++@itemize
>> ++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg
>> ++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file
>> ++@item File outline by procedures
>> ++@item Indentation and line breaking (alpha)
>> ++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive)
>> ++@end itemize")
>
> I suggest:
>
>   This package includes major modes for Nim. In particular, it provides
>   syntax highlighting for Nim code, Nimble configuration files, and
>   @file{nim.cfg}, outlining features, a dedicated compilation command,
>   indentation and line breaking.
>
>   It also implements integration with @code{nimsuggest}, the Nim linting
>   and completion server, although this is currently unstable.
>  
>> +      (license license:gpl3+))))
>
> Could you send an updated patch?
>
> Regards,

Message #34 received at 53472-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 53472-done <at> debbugs.gnu.org, paren <at> disroot.org,
 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#53472] [PATCH] gnu: Add emacs-nim-mode
Date: Sun, 25 Sep 2022 23:03:41 +0200

[Message part 1 (text/plain, inline)]

On Mon, 07 Mar 2022 21:51:23 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi unmatched-parenthesis,
> 
> I know it’s been a while already, but did you have a chance to look
> into making the changes Nicolas suggested?
> 
>   https://issues.guix.gnu.org/53472

Closing, because this patchset has unresolved issues, and original
reporter has no longer interest in it, as stated here:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54310#11

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #37 received at 53472-done <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 Ludovic Courtès <ludo <at> gnu.org>
Cc: 53472-done <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#53472] [PATCH] gnu: Add emacs-nim-mode
Date: Mon, 26 Sep 2022 07:33:18 +0100

On Sun Sep 25, 2022 at 10:03 PM BST, Björn Höfling wrote:
> Closing, because this patchset has unresolved issues

Thank you :)

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.