GNU bug report logs -
#53638
[PATCH] newsticker better path handling and data storage
Previous Next
Reported by: mailj2 <at> protonmail.com
Date: Sun, 30 Jan 2022 20:20:01 UTC
Severity: normal
Tags: patch
Fixed in version 29.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53638 in the body.
You can then email your comments to 53638 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Sun, 30 Jan 2022 20:20:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
mailj2 <at> protonmail.com
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Sun, 30 Jan 2022 20:20:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
The way newsticker currently handles paths involves directly concating
"/", which only works for UNIX systems.
Additionally, since newsticker uses `prin1-to-string' for storing
groups and cache, it should be enforced that `print-level' and
`print-length' are set to nil for the operation just as a precaution (it
happened to me that I manually set these once, which resulted in the
newsticker cache being corrupted).
This patch should fix both of these issues.
[newsticker-patch.diff (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Mon, 31 Jan 2022 10:24:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 53638 <at> debbugs.gnu.org (full text, mbox):
>>>>> On Sun, 30 Jan 2022 19:47:03 +0000, mailj2--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> said:
mailj2> The way newsticker currently handles paths involves directly concating
mailj2> "/", which only works for UNIX systems.
emacs-28 has `file-name-concat' for this very purpose, perhaps you
could respin to use that instead.
mailj2> Additionally, since newsticker uses `prin1-to-string' for storing
mailj2> groups and cache, it should be enforced that `print-level' and
mailj2> `print-length' are set to nil for the operation just as a precaution (it
mailj2> happened to me that I manually set these once, which resulted in the
mailj2> newsticker cache being corrupted).
OK. It would be good to have a ChangeLog style commit message as well,
see CONTRIBUTE for details. 'C-x 4 a' can help with writing it.
Robert
--
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Mon, 31 Jan 2022 12:20:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 53638 <at> debbugs.gnu.org (full text, mbox):
> Date: Sun, 30 Jan 2022 19:47:03 +0000
> From: mailj2--- via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>
> The way newsticker currently handles paths involves directly concating
> "/", which only works for UNIX systems.
The canonical way of doing that is to use expand-file-name.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Mon, 31 Jan 2022 15:48:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 53638 <at> debbugs.gnu.org (full text, mbox):
mailj2 <at> protonmail.com writes:
> The way newsticker currently handles paths involves directly concating
> "/", which only works for UNIX systems.
Can you rework the patch to use `expand-file-name', which is how
file names are supposed to be constructed?
> Additionally, since newsticker uses `prin1-to-string' for storing
> groups and cache, it should be enforced that `print-level' and
> `print-length' are set to nil for the operation just as a precaution (it
> happened to me that I manually set these once, which resulted in the
> newsticker cache being corrupted).
That part of the patch looks good.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Mon, 31 Jan 2022 20:11:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 53638 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
"Lars Ingebrigtsen" <larsi <at> gnus.org> writes:
> Can you rework the patch to use
> `expand-file-name', which is how file names are supposed to be constructed?
I've refactored it to use `expand-file-name' and `file-name-concat'. It
appears the current convention (correct me if I'm wrong) is to use
`expand-file-name' for joining only one path and one directory, and
`file-name-concat' for multiple together.
[newsticker-patch-2.diff (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Tue, 01 Feb 2022 03:27:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 53638 <at> debbugs.gnu.org (full text, mbox):
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Mon, 31 Jan 2022 20:09:58 +0000
> From: mailj2--- via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>
> "Lars Ingebrigtsen" <larsi <at> gnus.org> writes:
>
> > Can you rework the patch to use
> > `expand-file-name', which is how file names are supposed to be constructed?
>
> I've refactored it to use `expand-file-name' and `file-name-concat'. It
> appears the current convention (correct me if I'm wrong) is to use
> `expand-file-name' for joining only one path and one directory, and
> `file-name-concat' for multiple together.
No, you can chain calls to expand-file-name as you need:
(expand-file-name "foo" (expand-file-name "bar" my-directory))
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Mon, 16 May 2022 04:37:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 53638 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Not sure if this bug report/patch is blocked but I faced the
`prin1-to-string` issue which is fixed by the patch here. I've attached
an updated patch that uses chained calls to `expand-file-name` instead
of `file-name-concat` since that was the last issue mentioned with the
patch.
[newsticker-patch-3.diff (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#53638
; Package
emacs
.
(Mon, 16 May 2022 12:06:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 53638 <at> debbugs.gnu.org (full text, mbox):
Xavier Capaldi <xcapaldi <at> scribo.biz> writes:
> Not sure if this bug report/patch is blocked but I faced the
> `prin1-to-string` issue which is fixed by the patch here. I've attached
> an updated patch that uses chained calls to `expand-file-name` instead
> of `file-name-concat` since that was the last issue mentioned with the
> patch.
Thanks. I've now applied the patch (with a number of changes) and
pushed to Emacs 29.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 29.1, send any further explanations to
53638 <at> debbugs.gnu.org and mailj2 <at> protonmail.com
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Mon, 16 May 2022 12:06:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 14 Jun 2022 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 288 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.