GNU bug report logs - #53717
[PATCH] gnu: Add rofi-wayland.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53717 in the body.
You can then email your comments to 53717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add rofi-wayland.
Date: Tue, 1 Feb 2022 11:40:08 +0300

[Message part 1 (text/plain, inline)]

Tested on sway session.

* gnu/packages/xdisorg.scm (rofi-wayland): New variable.
---
 gnu/packages/xdisorg.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index ec995c3496..c2bd1d1d5c 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -53,6 +53,7 @@
 ;;; Copyright © 2021 Felix Gruber <felgru <at> posteo.net>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
+;;; Copyright © 2022 Andrew Tropin <andrew <at> trop.in>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1742,6 +1743,40 @@ (define-public rofi
 by name.")
     (license license:expat)))
 
+(define-public rofi-wayland
+  (package
+   (inherit rofi)
+   (name "rofi-wayland")
+   (version "1.7.2+wayland1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://github.com/lbonn/rofi"
+                                "/releases/download/"
+                                version "/rofi-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1smrxjq693z48c7n5pcfrvb0m0vsn6pxn7qpn8bm68j942n8rg3x"))))
+   (build-system meson-build-system)
+   (arguments
+    (substitute-keyword-arguments (package-arguments rofi)
+      ((#:configure-flags flags '())
+       #~(list "-Dxcb=disabled"))))
+    (inputs
+     (list cairo
+           glib
+           libjpeg-turbo
+           librsvg
+           libxkbcommon
+           wayland
+           wayland-protocols
+           pango
+           startup-notification))
+    (description "Rofi is a minimalist application launcher.  It memorizes which
+applications you regularly use and also allows you to search for an application
+by name.
+
+This is a fork with added support for Wayland via layer shell protocol.")))
+
 (define-public rofi-calc
   (package
     (name "rofi-calc")
-- 
2.34.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 53717 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Andrew Tropin <andrew <at> trop.in>, 53717 <at> debbugs.gnu.org
Subject: Re: [bug#53717] [PATCH] gnu: Add rofi-wayland.
Date: Thu, 10 Feb 2022 17:20:03 +0100

[Message part 1 (text/plain, inline)]

Andrew schrieb am Dienstag der 01. Februar 2022 um 11:40 +03:

> Tested on sway session.
>
> * gnu/packages/xdisorg.scm (rofi-wayland): New variable.
> ---
>  gnu/packages/xdisorg.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index ec995c3496..c2bd1d1d5c 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -53,6 +53,7 @@
>  ;;; Copyright © 2021 Felix Gruber <felgru <at> posteo.net>
>  ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
>  ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
> +;;; Copyright © 2022 Andrew Tropin <andrew <at> trop.in>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1742,6 +1743,40 @@ (define-public rofi
>  by name.")
>      (license license:expat)))
>  
> +(define-public rofi-wayland
> +  (package
> +   (inherit rofi)
> +   (name "rofi-wayland")
> +   (version "1.7.2+wayland1")

We usually strip away prefixes and suffixes.  FWIW, version 1.7.3 seems
to be available as well.

> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "https://github.com/lbonn/rofi"
> +                                "/releases/download/"
> +                                version "/rofi-" version ".tar.xz"))
> +            (sha256
> +             (base32
> +              "1smrxjq693z48c7n5pcfrvb0m0vsn6pxn7qpn8bm68j942n8rg3x"))))
> +   (build-system meson-build-system)
> +   (arguments
> +    (substitute-keyword-arguments (package-arguments rofi)
> +      ((#:configure-flags flags '())
> +       #~(list "-Dxcb=disabled"))))
> +    (inputs
> +     (list cairo
> +           glib
> +           libjpeg-turbo
> +           librsvg
> +           libxkbcommon
> +           wayland
> +           wayland-protocols
> +           pango
> +           startup-notification))
> +    (description "Rofi is a minimalist application launcher.  It memorizes which
> +applications you regularly use and also allows you to search for an application
> +by name.
> +
> +This is a fork with added support for Wayland via layer shell protocol.")))

The home-page should also be changed to point to the fork.

Otherwise, LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 53717 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Xinglu Chen <public <at> yoctocell.xyz>, 53717 <at> debbugs.gnu.org
Subject: Re: [bug#53717] [PATCH] gnu: Add rofi-wayland.
Date: Sat, 26 Feb 2022 10:56:22 +0300

[Message part 1 (text/plain, inline)]

On 2022-02-10 17:20, Xinglu Chen wrote:

> Andrew schrieb am Dienstag der 01. Februar 2022 um 11:40 +03:
>
>> Tested on sway session.
>>
>> * gnu/packages/xdisorg.scm (rofi-wayland): New variable.
>> ---
>>  gnu/packages/xdisorg.scm | 35 +++++++++++++++++++++++++++++++++++
>>  1 file changed, 35 insertions(+)
>>
>> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
>> index ec995c3496..c2bd1d1d5c 100644
>> --- a/gnu/packages/xdisorg.scm
>> +++ b/gnu/packages/xdisorg.scm
>> @@ -53,6 +53,7 @@
>>  ;;; Copyright © 2021 Felix Gruber <felgru <at> posteo.net>
>>  ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
>>  ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
>> +;;; Copyright © 2022 Andrew Tropin <andrew <at> trop.in>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -1742,6 +1743,40 @@ (define-public rofi
>>  by name.")
>>      (license license:expat)))
>>  
>> +(define-public rofi-wayland
>> +  (package
>> +   (inherit rofi)
>> +   (name "rofi-wayland")
>> +   (version "1.7.2+wayland1")
>
> We usually strip away prefixes and suffixes.  FWIW, version 1.7.3 seems
> to be available as well.

AFAIU, it's a part of a version, it can potentially be +wayland2,
+wayland3 if it will be necessary to make another intermediate release,
which is related to wayland/wlroots changes, while upstream version
still the same (1.7.3 for example).

>> +   (source (origin
>> +            (method url-fetch)
>> +            (uri (string-append "https://github.com/lbonn/rofi"
>> +                                "/releases/download/"
>> +                                version "/rofi-" version ".tar.xz"))
>> +            (sha256
>> +             (base32
>> +              "1smrxjq693z48c7n5pcfrvb0m0vsn6pxn7qpn8bm68j942n8rg3x"))))
>> +   (build-system meson-build-system)
>> +   (arguments
>> +    (substitute-keyword-arguments (package-arguments rofi)
>> +      ((#:configure-flags flags '())
>> +       #~(list "-Dxcb=disabled"))))
>> +    (inputs
>> +     (list cairo
>> +           glib
>> +           libjpeg-turbo
>> +           librsvg
>> +           libxkbcommon
>> +           wayland
>> +           wayland-protocols
>> +           pango
>> +           startup-notification))
>> +    (description "Rofi is a minimalist application launcher.  It memorizes which
>> +applications you regularly use and also allows you to search for an application
>> +by name.
>> +
>> +This is a fork with added support for Wayland via layer shell protocol.")))
>
> The home-page should also be changed to point to the fork.
>
> Otherwise, LGTM!

Thank you for the pointing out, updated version, home-page.

[0001-gnu-Add-rofi-wayland.patch (text/x-patch, inline)]

From f470b6f6a6b4ec1ef789a302af3ee98d562462d8 Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew <at> trop.in>
Date: Tue, 1 Feb 2022 11:40:08 +0300
Subject: [PATCH] gnu: Add rofi-wayland.

Tested on sway session.

* gnu/packages/xdisorg.scm (rofi-wayland): New variable.
---
 gnu/packages/xdisorg.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 42452d0721..c43a5fbd44 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -54,6 +54,7 @@
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 Andrew Tropin <andrew <at> trop.in>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1743,6 +1744,41 @@ (define-public rofi
 by name.")
     (license license:expat)))
 
+(define-public rofi-wayland
+  (package
+   (inherit rofi)
+   (name "rofi-wayland")
+   (version "1.7.3+wayland1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://github.com/lbonn/rofi"
+                                "/releases/download/"
+                                version "/rofi-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1gfs13zfqg9f4prx8yylxvv93yr6j74nmhlm3wabr6jljbbr7jc8"))))
+   (build-system meson-build-system)
+   (arguments
+    (substitute-keyword-arguments (package-arguments rofi)
+      ((#:configure-flags flags '())
+       #~(list "-Dxcb=disabled"))))
+    (inputs
+     (list cairo
+           glib
+           libjpeg-turbo
+           librsvg
+           libxkbcommon
+           wayland
+           wayland-protocols
+           pango
+           startup-notification))
+    (home-page "https://github.com/lbonn/rofi")
+    (description "Rofi is a minimalist application launcher.  It memorizes which
+applications you regularly use and also allows you to search for an application
+by name.
+
+This is a fork with added support for Wayland via layer shell protocol.")))
+
 (define-public rofi-calc
   (package
     (name "rofi-calc")
-- 
2.34.0

[Message part 3 (text/plain, inline)]

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: [PATCH v2] gnu: Add rofi-wayland.
Date: Mon, 18 Apr 2022 11:26:49 +0300

[Message part 1 (text/plain, inline)]

* gnu/packages/xdisorg.scm (rofi-wayland): New variable.
---
Tested on sway session.

 gnu/packages/xdisorg.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index d2caee85ec..3ba79e178b 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -54,6 +54,7 @@
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 Andrew Tropin <andrew <at> trop.in>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1742,6 +1743,41 @@ (define-public rofi
 by name.")
     (license license:expat)))
 
+(define-public rofi-wayland
+  (package
+   (inherit rofi)
+   (name "rofi-wayland")
+   (version "1.7.3+wayland1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://github.com/lbonn/rofi"
+                                "/releases/download/"
+                                version "/rofi-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1gfs13zfqg9f4prx8yylxvv93yr6j74nmhlm3wabr6jljbbr7jc8"))))
+   (build-system meson-build-system)
+   (arguments
+    (substitute-keyword-arguments (package-arguments rofi)
+      ((#:configure-flags flags '())
+       #~(list "-Dxcb=disabled"))))
+    (inputs
+     (list cairo
+           glib
+           libjpeg-turbo
+           librsvg
+           libxkbcommon
+           wayland
+           wayland-protocols
+           pango
+           startup-notification))
+    (home-page "https://github.com/lbonn/rofi")
+    (description "Rofi is a minimalist application launcher.  It memorizes which
+applications you regularly use and also allows you to search for an application
+by name.
+
+This is a fork with added support for Wayland via layer shell protocol.")))
+
 (define-public rofi-calc
   (package
     (name "rofi-calc")
-- 
2.35.1

[signature.asc (application/pgp-signature, inline)]

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add rofi-wayland.
Date: Thu, 04 Aug 2022 14:50:16 +0300

[Message part 1 (text/plain, inline)]

Just a gentle reminder.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 53717-done <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Andrew Tropin <andrew <at> trop.in>, 53717-done <at> debbugs.gnu.org
Subject: Re: [bug#53717] [PATCH] gnu: Add rofi-wayland.
Date: Fri, 01 Sep 2023 15:28:58 -0700

[Message part 1 (text/plain, inline)]

On 2022-02-01, Andrew Tropin wrote:
> * gnu/packages/xdisorg.scm (rofi-wayland): New variable.

rofi-wayland was added in:

04b5450ad852735dfa50961d3afc789b2e52b407 gnu: Add rofi-wayland.

And updated to a newer version in:

19c042ddf80533ba7a615b424dedf9647ca65b0f gnu: rofi-wayland: Update to 1.7.5+wayland2.

Marking as done.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.