GNU bug report logs - #53790
Audacity has extraneous binary at directory root

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53790 in the body.
You can then email your comments to 53790 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Subject: Audacity has extraneous binary at directory root
Date: Fri, 4 Feb 2022 17:03:15 -0500

Our Audacity package creates an extraneous "audacity" binary in the root
of the store item:

------
$ git describe                                   
v1.3.0-15695-gba60aede97 
$ ls -la $(./pre-inst-env guix build audacity)    
total 49012                
dr-xr-xr-x    6 root root          4096 Dec 31  1969 .
drwxrwxr-t 3440 root guixbuild 50139136 Feb  4 17:00 ..
-r-xr-xr-x    1 root root           337 Dec 31  1969 audacity
dr-xr-xr-x    2 root root          4096 Dec 31  1969 bin
dr-xr-xr-x    2 root root          4096 Dec 31  1969 etc
dr-xr-xr-x    3 root root          4096 Dec 31  1969 lib
dr-xr-xr-x   11 root root          4096 Dec 31  1969 share
$ ls -la $(./pre-inst-env guix build audacity)/bin
total 18404
dr-xr-xr-x 2 root root     4096 Dec 31  1969 .
dr-xr-xr-x 6 root root     4096 Dec 31  1969 ..
-r-xr-xr-x 1 root root      600 Dec 31  1969 audacity
-r-xr-xr-x 2 root root 18827912 Dec 31  1969 .audacity-real
------

This didn't occur before the update from Audacity 2.4.2 to 3.1.3.

Message #8 received at 53790 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>, 53790 <at> debbugs.gnu.org
Subject: Re: Audacity has extraneous binary at directory root
Date: Sat, 05 Feb 2022 08:22:32 +0100

Hi Leo,

Am Freitag, dem 04.02.2022 um 17:03 -0500 schrieb Leo Famulari:
> Our Audacity package creates an extraneous "audacity" binary in the
> root of the store item:
> 
> ------
> $ git describe                                   
> v1.3.0-15695-gba60aede97 
> $ ls -la $(./pre-inst-env guix build audacity)    
> total 49012                
> dr-xr-xr-x    6 root root          4096 Dec 31  1969 .
> drwxrwxr-t 3440 root guixbuild 50139136 Feb  4 17:00 ..
> -r-xr-xr-x    1 root root           337 Dec 31  1969 audacity
> dr-xr-xr-x    2 root root          4096 Dec 31  1969 bin
> dr-xr-xr-x    2 root root          4096 Dec 31  1969 etc
> dr-xr-xr-x    3 root root          4096 Dec 31  1969 lib
> dr-xr-xr-x   11 root root          4096 Dec 31  1969 share
> $ ls -la $(./pre-inst-env guix build audacity)/bin
> total 18404
> dr-xr-xr-x 2 root root     4096 Dec 31  1969 .
> dr-xr-xr-x 6 root root     4096 Dec 31  1969 ..
> -r-xr-xr-x 1 root root      600 Dec 31  1969 audacity
> -r-xr-xr-x 2 root root 18827912 Dec 31  1969 .audacity-real
> ------
Looking at the size of this thing compared to our audacity, I thought
to myself "hmm, that's a shell script" and sure enough

--8<---------------cut here---------------start------------->8---
#!/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/sh

lib="${0%/*}/lib/audacity"
share="${0%/*}/share/audacity"

export LD_LIBRARY_PATH="${lib}:${LD_LIBRARY_PATH}"
export AUDACITY_MODULES_PATH="${AUDACITY_MODULES_PATH}:${lib}/modules"
export AUDACITY_PATH="${AUDACITY_PATH}:${share}"

exec "${0%/*}/bin/audacity" "$@"
--8<---------------cut here---------------end--------------->8---
At the time of writing none of these appear particularly needed, though
if the time comes we might just port over the 'wrap-emacs-paths phase.

We can try searching for the bits in CMakeLists that install this
wrapper or we can simply drop the file.  WDYT?

Message #11 received at 53790 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 53790 <at> debbugs.gnu.org
Subject: Re: Audacity has extraneous binary at directory root
Date: Sat, 5 Feb 2022 13:52:21 -0500

On Sat, Feb 05, 2022 at 08:22:32AM +0100, Liliana Marie Prikler wrote:
> Looking at the size of this thing compared to our audacity, I thought
> to myself "hmm, that's a shell script" and sure enough
> 
> --8<---------------cut here---------------start------------->8---
> #!/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/sh
> 
> lib="${0%/*}/lib/audacity"
> share="${0%/*}/share/audacity"
> 
> export LD_LIBRARY_PATH="${lib}:${LD_LIBRARY_PATH}"
> export AUDACITY_MODULES_PATH="${AUDACITY_MODULES_PATH}:${lib}/modules"
> export AUDACITY_PATH="${AUDACITY_PATH}:${share}"
> 
> exec "${0%/*}/bin/audacity" "$@"
> --8<---------------cut here---------------end--------------->8---

Interesting...

> At the time of writing none of these appear particularly needed, though
> if the time comes we might just port over the 'wrap-emacs-paths phase.

I figure it's there for a reason. Maybe we just need to make sure it
ends up in 'bin/'? But, it's weird that the build scripts create multiple
executables with the same name in these different directories.

> We can try searching for the bits in CMakeLists that install this
> wrapper or we can simply drop the file.  WDYT?

I don't know... I wonder if Audacity is worse for Guix users since this
shell script doesn't end up in $PATH.

Message #14 received at 53790 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53790 <at> debbugs.gnu.org
Subject: Re: Audacity has extraneous binary at directory root
Date: Sat, 05 Feb 2022 23:52:07 +0100

Hi,

Am Samstag, dem 05.02.2022 um 13:52 -0500 schrieb Leo Famulari:
> On Sat, Feb 05, 2022 at 08:22:32AM +0100, Liliana Marie Prikler
> wrote:
> > Looking at the size of this thing compared to our audacity, I
> > thought to myself "hmm, that's a shell script" and sure enough
> > 
> > --8<---------------cut here---------------start------------->8---
> > #!/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-
> > 5.1.8/bin/sh
> > 
> > lib="${0%/*}/lib/audacity"
> > share="${0%/*}/share/audacity"
> > 
> > export LD_LIBRARY_PATH="${lib}:${LD_LIBRARY_PATH}"
> > export
> > AUDACITY_MODULES_PATH="${AUDACITY_MODULES_PATH}:${lib}/modules"
> > export AUDACITY_PATH="${AUDACITY_PATH}:${share}"
> > 
> > exec "${0%/*}/bin/audacity" "$@"
> > --8<---------------cut here---------------end--------------->8---
> 
> Interesting...
> 
> > At the time of writing none of these appear particularly needed,
> > though
> > if the time comes we might just port over the 'wrap-emacs-paths
> > phase.
> 
> I figure it's there for a reason. Maybe we just need to make sure it
> ends up in 'bin/'? But, it's weird that the build scripts create
> multiple executables with the same name in these different
> directories.
I don't think it should be in bin/. Looking at the script, it appears
to be written for the install root, which... eh...

> > We can try searching for the bits in CMakeLists that install this
> > wrapper or we can simply drop the file.  WDYT?
> 
> I don't know... I wonder if Audacity is worse for Guix users since
> this shell script doesn't end up in $PATH.
Concerning LD_LIBRARY_PATH, that probably has no effect on Guix users.
AUDACITY_MODULES_PATH and AUDACITY_PATH could bug them, but only if run
through the store – I already added search-path specifications for
them. The question therefore really is whether to extend our wrapper or
not.

   1. Cheers

Message #19 received at 53790-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53790-done <at> debbugs.gnu.org
Subject: Re: Audacity has extraneous binary at directory root
Date: Sun, 21 Aug 2022 16:54:24 +0200

Am Samstag, dem 05.02.2022 um 13:52 -0500 schrieb Leo Famulari:
> 
> > We can try searching for the bits in CMakeLists that install this
> > wrapper or we can simply drop the file.  WDYT?
> 
> I don't know... I wonder if Audacity is worse for Guix users since
> this shell script doesn't end up in $PATH.
After more than half a year without any complaint about our audacity
command, I doubt this.  Thus I pushed a patch that removes the
gratuitous audacity.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.