GNU bug report logs - #53825
[PATCH] gnu: Add sbase.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sun, 6 Feb 2022 17:58:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53825 in the body.
You can then email your comments to 53825 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Sun, 06 Feb 2022 17:58:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 06 Feb 2022 17:58:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add sbase.
Date: Sun,  6 Feb 2022 12:56:18 -0500
* gnu/packages/suckless.scm (sbase): New variable.
---
 gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..af7c0a8801 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,38 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/dylanaraps/sbase")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         (list (string-append "CC=" ,(cc-for-target))
+               (string-append "PREFIX=" %output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of unix tools that are portable across
+  unix-systems.")
+      (license license:expat))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0





Information forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Sun, 06 Feb 2022 18:25:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>, 53825 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: Re: [bug#53825] [PATCH] gnu: Add sbase.
Date: Sun, 06 Feb 2022 19:24:35 +0100
[Message part 1 (text/plain, inline)]
jgart via schrieb am Sonntag der 06. Februar 2022 um 12:56 -05:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>  gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 708eb2c338..af7c0a8801 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -988,6 +988,38 @@ (define-public snooze
>  running a command.")
>      (license license:cc0)))
>  
> +(define-public sbase
> +  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
> +        (revision "0"))

What’s the reason for using a specific commit instead of a tag?  There
should be a comment about this.

> +    (package
> +      (name "sbase")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/dylanaraps/sbase")

The homepage points to <https://git.suckless.org/sbase/>.  This Github
repo seems to be private or deleted.  Guix wasn’t able to clone it.

--8<---------------cut here---------------start------------->8---
fatal: could not read Username for 'https://github.com': No such device or address
Failed to do a shallow fetch; retrying a full fetch...
fatal: could not read Username for 'https://github.com': No such device or address
git-fetch: '/gnu/store/avdv1l8zyfnjm8z5f9c4y5fgncqb03zc-git-minimal-2.34.0/bin/git fetch origin' failed with exit code 128
--8<---------------cut here---------------end--------------->8---

> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f ; There are no tests.
> +         #:make-flags
> +         (list (string-append "CC=" ,(cc-for-target))
> +               (string-append "PREFIX=" %output))

Use gexps instead (untested)

  ,#~(list (string-append "CC=" #$(cc-for-target))
           (string-append "PREFIX=" #$output))
        
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure))))
> +      (home-page "https://core.suckless.org/sbase/")
> +      (synopsis "Collection of unix tools that are portable across unix-systems")

Capitalize “unix”.

> +      (description
> +  "@command{sbase} is a collection of unix tools that are portable across
> +  unix-systems.")

Likewise

> +      (license license:expat))))

LICENSE says MIT/X Consortium[1], so it should be ‘license:x11’

[1]: <https://en.wikipedia.org/wiki/MIT_License#Minor_ambiguity_and_variants>
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Sun, 06 Feb 2022 18:25:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Mon, 07 Feb 2022 02:20:02 GMT) Full text and rfc822 format available.

Message #14 received at 53825 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 53825 <at> debbugs.gnu.org
Cc: Xinglu Chen <public <at> yoctocell.xyz>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add sbase.
Date: Sun,  6 Feb 2022 21:17:18 -0500
* gnu/packages/suckless.scm (sbase): New variable.
---

Hi Xinglu,

Not sure how dylanaraps got in that url... :)

Something bugged out or I didn't notice.

Anyways here is version 2 with all of your suggestions. 

Thanks for the review, Much appreciated!

all best,

jgart

 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..6aedb2b3ba 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,39 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  ;; There are no tagged releases.
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://git.suckless.org/sbase/")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         ,#~(list (string-append "CC=" #$(cc-for-target))
+                  (string-append "PREFIX=" #$output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of Unix tools that are portable across
+  Unix-systems.")
+      (license license:x11))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0





Information forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Wed, 09 Feb 2022 13:38:01 GMT) Full text and rfc822 format available.

Message #17 received at 53825 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: jgart <jgart <at> dismail.de>, 53825 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: Re: [PATCH v2] gnu: Add sbase.
Date: Wed, 09 Feb 2022 14:37:44 +0100
[Message part 1 (text/plain, inline)]
Hi,

jgart schrieb am Sonntag der 06. Februar 2022 um 21:17 -05:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi Xinglu,
>
> Not sure how dylanaraps got in that url... :)
>
> Something bugged out or I didn't notice.
>
> Anyways here is version 2 with all of your suggestions. 
>
> Thanks for the review, Much appreciated!
>
> all best,
>
> jgart
>
>  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 708eb2c338..6aedb2b3ba 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -988,6 +988,39 @@ (define-public snooze
>  running a command.")
>      (license license:cc0)))
>  
> +(define-public sbase
> +  ;; There are no tagged releases.
> +  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
> +        (revision "0"))
> +    (package
> +      (name "sbase")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://git.suckless.org/sbase/")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f ; There are no tests.
> +         #:make-flags
> +         ,#~(list (string-append "CC=" #$(cc-for-target))
> +                  (string-append "PREFIX=" #$output))
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure))))
> +      (home-page "https://core.suckless.org/sbase/")
> +      (synopsis "Collection of unix tools that are portable across
> unix-systems")

“unix” isn’t capitalized.  Whoever merges the patch can probably do it
for you though; no need to send a new reroll.

Otherwise, LGTM.  I didn’t test if all the binaries worked though.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Wed, 09 Feb 2022 17:59:02 GMT) Full text and rfc822 format available.

Message #20 received at 53825 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 53825 <at> debbugs.gnu.org
Cc: Xinglu Chen <public <at> yoctocell.xyz>, jgart <jgart <at> dismail.de>
Subject: [PATCH v3] gnu: Add sbase.
Date: Wed,  9 Feb 2022 12:57:10 -0500
* gnu/packages/suckless.scm (sbase): New variable.
---

Hi, 

Here is version 3 with the fix Xinglu mentioned.

I haven't tested all the binaries.

all best,

jgart

https://whereiseveryone.srht.site/
gemini://whereiseveryone.srht.site/


 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 708eb2c338..198e17384e 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -988,6 +988,39 @@ (define-public snooze
 running a command.")
     (license license:cc0)))
 
+(define-public sbase
+  ;; There are no tagged releases.
+  (let ((commit "2c2a7f54ab55a022a617e510b6e00c3e2736fabd")
+        (revision "0"))
+    (package
+      (name "sbase")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://git.suckless.org/sbase/")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; There are no tests.
+         #:make-flags
+         ,#~(list (string-append "CC=" #$(cc-for-target))
+                  (string-append "PREFIX=" #$output))
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure))))
+      (home-page "https://core.suckless.org/sbase/")
+      (synopsis "Collection of Unix tools that are portable across unix-systems")
+      (description
+  "@command{sbase} is a collection of Unix tools that are portable across
+  Unix-systems.")
+      (license license:x11))))
+
 (define-public scron
   (package
     (name "scron")
-- 
2.35.0





Information forwarded to guix-patches <at> gnu.org:
bug#53825; Package guix-patches. (Sun, 20 Mar 2022 15:22:02 GMT) Full text and rfc822 format available.

Message #23 received at 53825 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 53825 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add sbase.
Date: Sun, 20 Mar 2022 16:21:18 +0100
[Message part 1 (text/plain, inline)]
> +      (license license:x11))))

The license does not have the

  Except as contained in this notice, the name of the X Consortium
  shall not be used in advertising or otherwise to promote the sale,
  use or other dealings in this Software without prior written
  authorization from the X Consortium.

  X Window System is a trademark of X Consortium, Inc.

clause, so this seems to be the license:expat?  Looks like the first
line in LICENSE is incorrect.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Thu, 07 Jul 2022 19:58:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Thu, 07 Jul 2022 19:58:02 GMT) Full text and rfc822 format available.

Message #28 received at 53825-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 53825-done <at> debbugs.gnu.org, Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: bug#53825: [PATCH] gnu: Add sbase.
Date: Thu, 07 Jul 2022 15:57:12 -0400
Hi,

jgart <jgart <at> dismail.de> writes:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi, 
>
> Here is version 3 with the fix Xinglu mentioned.
>
> I haven't tested all the binaries.
>
> all best,
>
> jgart
>
> https://whereiseveryone.srht.site/
> gemini://whereiseveryone.srht.site/

I've adjusted it like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/suckless.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407 <at> posteo.ro>
 ;;; Copyright © 2021 Nikolay Korotkiy <sikmir <at> disroot.org>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1011,19 +1012,19 @@ (define-public sbase
           (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
       (build-system gnu-build-system)
       (arguments
-       `(#:tests? #f ; There are no tests.
-         #:make-flags
-         ,#~(list (string-append "CC=" #$(cc-for-target))
-                  (string-append "PREFIX=" #$output))
-         #:phases
-         (modify-phases %standard-phases
-           (delete 'configure))))
+       (list
+        #:tests? #f                     ;no test suite
+        #:make-flags #~(list (string-append "CC=" #$(cc-for-target))
+                             (string-append "PREFIX=" #$output))
+        #:phases
+        #~(modify-phases %standard-phases
+            (delete 'configure))))
       (home-page "https://core.suckless.org/sbase/")
-      (synopsis "Collection of Unix tools that are portable across unix-systems")
-      (description
-  "@command{sbase} is a collection of Unix tools that are portable across
-  Unix-systems.")
-      (license license:x11))))
+      (synopsis "Collection of UNIX tools")
+      (description "@command{sbase} is a collection of UNIX tools similar to those of GNU
+Coreutils, containing utilities commands such as @command{grep}, @command{cp},
+@command{rm}, etc.")
+      (license license:expat))))
 
 (define-public scron
   (package
--8<---------------cut here---------------end--------------->8---

Reverting the license to Expat as pointed by Maxime, fully capitalizing
UNIX, using a gexp for the phases and adding a few commands to the
description to give a better idea.  I've also removed the bits "portable
across UNIX systems" as on Guix that's not useful (the tools are as
portable as Guix itself is).

Pushed as 5299628b90.

Thanks!

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 05 Aug 2022 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 236 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.