GNU bug report logs - #53862
[PATCH] tests: Add system tests for each supported kernel version.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53862 in the body.
You can then email your comments to 53862 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] tests: Add system tests for each supported kernel version.
Date: Mon,  7 Feb 2022 23:38:14 +0100

* gnu/tests/base.scm (test-basic-os-with-kernel): New procedure.
(%test-linux-libre-5.10, %test-linux-libre-5.4, %test-linux-libre-4.19,
%test-linux-libre-4.14, %test-linux-libre-4.9, %test-linux-libre-4.4): New
tests.
---
 gnu/tests/base.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
---
Guix,

I just discovered #52667 and figured it would be neat to have system
tests for each kernel to catch regressions faster.

WDYT?

diff --git a/gnu/tests/base.scm b/gnu/tests/base.scm
index 38d4317e52..88de421ed1 100644
--- a/gnu/tests/base.scm
+++ b/gnu/tests/base.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2018 Clément Lassieur <clement <at> lassieur.org>
+;;; Copyright © 2022 Marius Bakke <marius <at> gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -41,10 +42,18 @@ (define-module (gnu tests base)
   #:use-module (guix store)
   #:use-module (guix monads)
   #:use-module (guix packages)
+  #:use-module (guix utils)
   #:use-module (srfi srfi-1)
   #:use-module (ice-9 match)
   #:export (run-basic-test
             %test-basic-os
+            test-basic-os-with-kernel
+            %test-linux-libre-5.10
+            %test-linux-libre-5.4
+            %test-linux-libre-4.19
+            %test-linux-libre-4.14
+            %test-linux-libre-4.9
+            %test-linux-libre-4.4
             %test-halt
             %test-cleanup
             %test-mcron
@@ -537,6 +546,38 @@ (define %test-basic-os
       (run-basic-test (virtualized-operating-system os '())
                       #~(list #$vm))))))
 
+(define (test-basic-os-with-kernel kernel)
+  (system-test
+   (name (string-append (package-name kernel) "-"
+                        (version-major+minor (package-version kernel))))
+   (description "Run %TEST-BASIC-OS with the given KERNEL.")
+   (value
+    (let* ((os (marionette-operating-system
+                (operating-system
+                  (inherit %simple-os)
+                  (kernel kernel))))
+           (vm (virtual-machine os)))
+      (run-basic-test (virtualized-operating-system os '())
+                      #~(list #$vm))))))
+
+(define %test-linux-libre-5.10
+  (test-basic-os-with-kernel linux-libre-5.10))
+
+(define %test-linux-libre-5.4
+  (test-basic-os-with-kernel linux-libre-5.4))
+
+(define %test-linux-libre-4.19
+  (test-basic-os-with-kernel linux-libre-4.19))
+
+(define %test-linux-libre-4.14
+  (test-basic-os-with-kernel linux-libre-4.14))
+
+(define %test-linux-libre-4.9
+  (test-basic-os-with-kernel linux-libre-4.9))
+
+(define %test-linux-libre-4.4
+  (test-basic-os-with-kernel linux-libre-4.4))
+
 
 ;;;
 ;;; Halt.
-- 
2.34.0

Message #8 received at 53862 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Marius Bakke <marius <at> gnu.org>
Cc: 53862 <at> debbugs.gnu.org
Subject: Re: bug#53862: [PATCH] tests: Add system tests for each supported
 kernel version.
Date: Thu, 03 Mar 2022 23:44:47 +0100

Hi,

Marius Bakke <marius <at> gnu.org> skribis:

> * gnu/tests/base.scm (test-basic-os-with-kernel): New procedure.
> (%test-linux-libre-5.10, %test-linux-libre-5.4, %test-linux-libre-4.19,
> %test-linux-libre-4.14, %test-linux-libre-4.9, %test-linux-libre-4.4): New
> tests.
> ---
>  gnu/tests/base.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> ---
> Guix,
>
> I just discovered #52667 and figured it would be neat to have system
> tests for each kernel to catch regressions faster.
>
> WDYT?

Good idea, go for it!

Thanks,
Ludo’.

Message #11 received at 53862 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Marius Bakke <marius <at> gnu.org>
Cc: 53862 <at> debbugs.gnu.org
Subject: Re: bug#53862: [PATCH] tests: Add system tests for each supported
 kernel version.
Date: Tue, 05 Apr 2022 18:07:58 +0200

Ping! :-)

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Hi,
>
> Marius Bakke <marius <at> gnu.org> skribis:
>
>> * gnu/tests/base.scm (test-basic-os-with-kernel): New procedure.
>> (%test-linux-libre-5.10, %test-linux-libre-5.4, %test-linux-libre-4.19,
>> %test-linux-libre-4.14, %test-linux-libre-4.9, %test-linux-libre-4.4): New
>> tests.
>> ---
>>  gnu/tests/base.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 41 insertions(+)
>> ---
>> Guix,
>>
>> I just discovered #52667 and figured it would be neat to have system
>> tests for each kernel to catch regressions faster.
>>
>> WDYT?
>
> Good idea, go for it!
>
> Thanks,
> Ludo’.

Message #16 received at 53862-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 53862-done <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#53862: [PATCH] tests: Add system tests for each supported
 kernel version.
Date: Mon, 12 Dec 2022 20:29:27 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> skriver:

> Hi,
>
> Marius Bakke <marius <at> gnu.org> skribis:
>
>> * gnu/tests/base.scm (test-basic-os-with-kernel): New procedure.
>> (%test-linux-libre-5.10, %test-linux-libre-5.4, %test-linux-libre-4.19,
>> %test-linux-libre-4.14, %test-linux-libre-4.9, %test-linux-libre-4.4): New
>> tests.
>> ---
>>  gnu/tests/base.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 41 insertions(+)
>> ---
>> Guix,
>>
>> I just discovered #52667 and figured it would be neat to have system
>> tests for each kernel to catch regressions faster.
>>
>> WDYT?
>
> Good idea, go for it!

I finally went ahead and committed a variant of this in
2c1b488d19831702288b8bdee4cecf661da91b60.

CC Leo and Tobias who now have to remove/add a system test with each
removed/added LTS kernel.  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.