GNU logs - #53921, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#53921: The libvirt service does not contain a way to turn-on remote listening
Resent-From: Katherine Cox-Buday <cox.katherine.e@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 10 Feb 2022 17:10:01 +0000
Resent-Message-ID: <handler.53921.B.164451298111661 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 53921 <at> debbugs.gnu.org
From: Katherine Cox-Buday <cox.katherine.e@HIDDEN>
Date: Thu, 10 Feb 2022 11:09:29 -0600
Message-ID: <8735kq8x86.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::d34;
 envelope-from=cox.katherine.e@HIDDEN; helo=mail-io1-xd34.google.com
X-Spam_score_int: 17
X-Spam_score: 1.7
X-Spam_bar: +
X-Spam_report: (1.7 / 5.0 requ) AC_FROM_MANY_DOTS=2.996, BAYES_00=-1.9,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001,
 RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

The shepherd libvirt service contains ways to configure "listening mode" (i.e. listening over TCP) capabilities, but contains no way to actually turn this feature on, despite referencing[1] an unimplemented `listen` option:

> You must set listen for this to have any effect. 

From libvirt's documentation[2]:

> Note: it is also necessary to start the server in listening mode by
> running it with --listen or adding a LIBVIRTD_ARGS="--listen" line to
> /etc/sysconfig/libvirtd.

Our service definition requires the ability to specify that shepherd should start the service with the `--listen` flag.

[1] - https://guix.gnu.org/manual/en/guix.html#index-listen_002dtcp_003f
[2] - https://libvirt.org/remote.html#Remote_libvirtd_configuration

-- 
Katherine

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Katherine Cox-Buday <cox.katherine.e@HIDDEN>
Subject: bug#53921: Acknowledgement (The libvirt service does not contain
 a way to turn-on remote listening)
Message-ID: <handler.53921.B.164451298111661.ack <at> debbugs.gnu.org>
References: <8735kq8x86.fsf@HIDDEN>
X-Gnu-PR-Message: ack 53921
X-Gnu-PR-Package: guix
Reply-To: 53921 <at> debbugs.gnu.org
Date: Thu, 10 Feb 2022 17:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 53921 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
53921: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53921
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#53921: [PATCH] services: libvirt: Enable listening mode based on configuration.
References: <8735kq8x86.fsf@HIDDEN>
In-Reply-To: <8735kq8x86.fsf@HIDDEN>
Resent-From: Brice Waegeneire <brice@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 12 Feb 2022 12:31:02 +0000
Resent-Message-ID: <handler.53921.B53921.164466904314656 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: cox.katherine.e@HIDDEN
Cc: 53921 <at> debbugs.gnu.org
From: Brice Waegeneire <brice@HIDDEN>
Date: Sat, 12 Feb 2022 13:30:28 +0100
Message-Id: <20220212123028.6320-1-brice@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Fixes <https://bugs.gnu.org/53921>.

* gnu/services/virtualization.scm (libvirt-shepherd-service): Use
  'match-record' instead of accessors.
  Conditionally add "--listen" flag to the start command.
---
Hello Katherine,

Katherine Cox-Buday <cox.katherine.e@HIDDEN> writes:

> The shepherd libvirt service contains ways to configure "listening mode"
> (i.e. listening over TCP) capabilities, but contains no way to actually turn
> this feature on, despite referencing[1] an unimplemented `listen` option:

Good catch!  This patch fixes the reported issue, I've tested it with success.

Cheers,
- Brice

 gnu/services/virtualization.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index 66ae1a1565..ba9fe0505c 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2018, 2020, 2021 Ludovic Courtès <ludo@HIDDEN>
 ;;; Copyright © 2020,2021 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
 ;;; Copyright © 2021 Timotej Lazar <timotej.lazar@HIDDEN>
+;;; Copyright © 2022 Brice Waegeneire <brice@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -467,16 +468,18 @@ (define (%libvirt-activation config)
         (use-modules (guix build utils))
         (mkdir-p #$sock-dir))))

-
 (define (libvirt-shepherd-service config)
-  (let* ((config-file (libvirt-conf-file config))
-         (libvirt (libvirt-configuration-libvirt config)))
+  (match-record config <libvirt-configuration>
+    (libvirt listen-tcp? listen-tls?)
     (list (shepherd-service
            (documentation "Run the libvirt daemon.")
            (provision '(libvirtd))
            (start #~(make-forkexec-constructor
-                     (list (string-append #$libvirt "/sbin/libvirtd")
-                           "-f" #$config-file)
+                     (list #$(file-append libvirt "/sbin/libvirtd")
+                           (if (or #$listen-tcp? #$listen-tls?)
+                               "--listen"
+                               "")
+                           "-f" #$(libvirt-conf-file config))
                      ;; For finding qemu and ip binaries.
                      #:environment-variables
                      (list (string-append

base-commit: 068d99978a0c9c6fb66f95455060c8d08ba55ac5
-- 
2.34.0

Last modified: Sat, 12 Feb 2022 12:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.