GNU bug report logs - #53931
[PATCH] gnu: Add python-onlykey-solo-python

Previous Next

To reply to this bug, email your comments to 53931 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pāladhammika <paladhammika <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add python-onlykey-solo-python
Date: Thu, 10 Feb 2022 21:31:25 +0000

[Message part 1 (text/plain, inline)]

All the best,
Pāladhammika

[0001-gnu-Add-python-onlykey-solo-python.patch (text/x-patch, attachment)]

Message #8 received at 53931 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Pāladhammika <paladhammika <at> protonmail.com>, 
 53931 <at> debbugs.gnu.org
Subject: Re: [bug#53931] [PATCH] gnu: Add python-onlykey-solo-python
Date: Sat, 12 Feb 2022 16:43:02 +0100

[Message part 1 (text/plain, inline)]

Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:31
[+0000]:
> +   (home-page "https://github.com/trustcrypto/onlykey-solo-python")

Why not use the upstream <https://github.com/solokeys/solo-python> of
the fork? The latest commits are the same.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53931 <at> debbugs.gnu.org (full text, mbox):

From: Pāladhammika <paladhammika <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53931 <at> debbugs.gnu.org
Subject: Re: [bug#53931] [PATCH] gnu: Add python-onlykey-solo-python
Date: Sat, 12 Feb 2022 16:21:19 +0000

Are they? The trustcrypto fork claims to be 12 commits ahead. Even still it makes sense to use the fork that by trustcrypto since they also produce the onlykey package, no?

All the best,
Pāladhammika

------- Original Message -------

On Saturday, February 12th, 2022 at 3:43 PM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:31
>
> [+0000]:
>
> > +   (home-page "https://github.com/trustcrypto/onlykey-solo-python")
>
> Why not use the upstream https://github.com/solokeys/solo-python of
>
> the fork? The latest commits are the same.
>
> Greetings,
>
> Maxime.

Message #14 received at 53931 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Pāladhammika <paladhammika <at> protonmail.com>
Cc: 53931 <at> debbugs.gnu.org
Subject: Re: [bug#53931] [PATCH] gnu: Add python-onlykey-solo-python
Date: Sat, 12 Feb 2022 18:45:56 +0100

[Message part 1 (text/plain, inline)]

Pāladhammika schreef op za 12-02-2022 om 16:21 [+0000]:
Are they? The trustcrypto fork claims to be 12 commits ahead.
> Even still it makes sense to use the fork that by trustcrypto
> since they also produce the onlykey package, no?

AFAICT the fork is exactly the same as upstream, except with a slightly
different name, without any text in the README and with some
docstrings, warnings and error messages tweaked.

The only non-tweak commit appears to be
<https://github.com/trustcrypto/onlykey-solo-python/commit/1d4e03ac00a60286554f4a8f4f22bf892446788e>,
which seems a tiny change that should have been discussed upstream
(maybe it's as simple as recognising both pairs of vendor_id/product_id).

Also, no development seems to happen in the fork, development happens
upstream.  The fork does not appear to accept pull requests and there
is no option for submitting an issue, whereas upstream does, so it
seems that upstream has a much better community.

Considering all this, this does not appear to be a fork
in the sense that, say, XEmacs is a fork of Emacs.  Instead, it appears
to be pure branding -- and branding that will cause collisions in the profile
at that if both upstream and the trustcrypto-branded variant are installed
in the same profile, since the variant didn't change module names.

As such, I do not see a reason to prefer the branded variant over upstream,
and I would recommend not to, to prevent future problems (see profile
collisions), to reduce the number of packages that need to be updated
and to not cater to marketing.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.