GNU bug report logs - #53950
[PATCH] m4: cache build env sanity checks

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53950 in the body.
You can then email your comments to 53950 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] m4: cache build env sanity checks
Date: Sat, 12 Feb 2022 04:00:17 -0500

When rerunning configure in an existing build dir, cache the previous
results about environment settings.  There should be no need to retest
these in a dir that has already been configured.

* m4/sanity.m4: Cache sanity results.
---
 m4/sanity.m4 | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/m4/sanity.m4 b/m4/sanity.m4
index 11b0bde5c86b..4e44dd9c4096 100644
--- a/m4/sanity.m4
+++ b/m4/sanity.m4
@@ -9,7 +9,9 @@
 # AM_SANITY_CHECK
 # ---------------
 AC_DEFUN([AM_SANITY_CHECK],
-[AC_MSG_CHECKING([whether build environment is sane])
+[dnl
+rm -f conftest.file
+AC_CACHE_CHECK([whether build environment is sane], am_cv_build_env_is_sane, [dnl
 # Reject unsafe characters in $srcdir or the absolute working directory
 # name.  Accept space and tab only in the latter.
 am_lf='
@@ -57,17 +59,16 @@ if (
    test "$[2]" = conftest.file
    )
 then
-   # Ok.
-   :
+  am_cv_build_env_is_sane=yes
 else
    AC_MSG_ERROR([newly created file is older than distributed files!
 Check your system clock])
 fi
-AC_MSG_RESULT([yes])
+])
 # If we didn't sleep, we still need to ensure time stamps of config.status and
 # generated files are strictly newer.
 am_sleep_pid=
-if grep 'slept: no' conftest.file >/dev/null 2>&1; then
+if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then
   ( sleep 1 ) &
   am_sleep_pid=$!
 fi
-- 
2.34.1

Message #8 received at 53950 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 53950 <at> debbugs.gnu.org
Subject: Re: [bug#53950] [PATCH] m4: cache build env sanity checks
Date: Sat, 12 Feb 2022 15:14:13 -0700

    Subject: [bug#53950] [PATCH] m4: cache build env sanity checks

Sounds fine to me. Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.