GNU bug report logs - #54067
[PATCH] gnu: Add python-gym.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54067 in the body.
You can then email your comments to 54067 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <at> tutanota.com
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add python-gym.
Date: Sat, 19 Feb 2022 22:29:33 +0100 (CET)

[Message part 1 (text/plain, inline)]

Importing this module in python fails because python-importlib-metadata is too old. At least it builds successfully when sanity check is disabled.

[0001-gnu-Add-python-gym.patch (text/x-patch, attachment)]

Message #8 received at 54067 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: kiasoc5 <at> tutanota.com, 54067 <at> debbugs.gnu.org
Subject: Re: [bug#54067] [PATCH] gnu: Add python-gym.
Date: Sun, 20 Feb 2022 11:35:08 +0100

[Message part 1 (text/plain, inline)]

kiasoc5--- via Guix-patches via schreef op za 19-02-2022 om 22:29 [+0100]:
Importing this module in python fails because python-importlib-
metadata is too old.
> +         (delete 'sanity-check))))   ; requires python-importlib-metadata>4.10

In that case, could python-importlib-metadata be updated?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54067 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: kiasoc5 <at> tutanota.com, 54067 <at> debbugs.gnu.org
Subject: Re: [bug#54067] [PATCH] gnu: Add python-gym.
Date: Sun, 20 Feb 2022 11:36:33 +0100

[Message part 1 (text/plain, inline)]

kiasoc5--- via Guix-patches via schreef op za 19-02-2022 om 22:29
[+0100]:
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'check)   ; tests require nonfree library

How about setting the #:tests? argument instead?

  (arguments
    (list
      #:tests? #false ; tests require nonfree library
      #:phases
      #~(modify-phases ...)))

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 54067 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: kiasoc5 <at> tutanota.com
Cc: 54067 <at> debbugs.gnu.org
Subject: Re: [bug#54067] [PATCH] gnu: Add python-gym.
Date: Sun, 20 Feb 2022 20:12:53 +0100

[Message part 1 (text/plain, inline)]

[Please keep 54067 <at> debbugs.gnu.org in CC, such that other people
can comment]

kiasoc5 <at> tutanota.com schreef op zo 20-02-2022 om 19:50 [+0100]:
Of course updating python-importlib-metadata is the natural option,
> I don't intend to submit broken patches. But I'm not sure whether
> updating python-importlib-metadata will be smooth, if I run guix
> refresh -l python-importlib-metadata, it says `Building the following
> 74 packages would ensure 131 dependent packages are rebuilt`. It's a
> lot of packages to comb through.

What I'd usually do for testing is

$ ./pre-inst-env guix build python-astroquery <at> 0.4.5 vorta <at> 0.8.3 komikku <at> 0.36.1 [...]

and verify that the builds succeeded.

If their test suites are good, this should catch most issues.
Python packages are typically relatively cheap to build I think, so this
shouldn't take overly long.

We'll have to update python-importlib-metadata anyway eventually,
and it's not realistic to test each individual dependent manually.

> Is there any policy on testing packages for breakage when upgrading?
> Apologies, I should have asked this earlier.

There's (guix)Submitting patches:

  10. For important changes, check that dependent packages (if
     applicable) are not affected by the change; ‘guix refresh
     --list-dependent PACKAGE’ will help you do that (*note Invoking
     guix refresh::).

[...]

     All these branches are tracked by our build farm
     (https://ci.guix.gnu.org) and merged into ‘master’ once everything
     has been successfully built.  This allows us to fix issues before
     they hit users, and to reduce the window during which pre-built
     binaries are not available.

(so if building the python packages locally takes too long,
perhaps a temporary branch can be set up to let the build farm
take care of building).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 54067-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 54067-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-gym.
Date: Mon, 29 Jan 2024 21:58:35 +0000

[Message part 1 (text/plain, inline)]

From the project's page https://github.com/openai/gym:

> The team that has been maintaining Gym since 2021 has moved all future
> development to Gymnasium, a drop in replacement for Gym (import
> gymnasium as gym), and Gym will not be receiving any future updates.
> Please switch over to Gymnasium as soon as you're able to do so. If
> you'd like to read more about the story behind this switch, please check
> out this blog post.

Gymnasium is successor of Gym.
Closing as not actual. 

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.