GNU bug report logs - #54085
[PATCH 3/3] gnu: Add jless.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54085 in the body.
You can then email your comments to 54085 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 3/3] gnu: Add jless.
Date: Mon, 21 Feb 2022 09:48:10 +0000

[Message part 1 (text/plain, inline)]

Hi,

These patches add JSON viewer in Rust.

----
Petr

[Message part 2 (text/html, inline)]

[0001-gnu-Add-rust-logos-derive-0.12.patch (text/x-patch, attachment)]

[0002-gnu-Add-rust-logos-0.12.patch (text/x-patch, attachment)]

[0003-gnu-Add-jless.patch (text/x-patch, attachment)]

Message #8 received at 54085 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 54085 <at> debbugs.gnu.org
Subject: Re: [bug#54085] [PATCH 3/3] gnu: Add jless.
Date: Mon, 21 Feb 2022 14:24:49 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op ma 21-02-2022 om 09:48 [+0000]:
> +    (synopsis "Macros for deriving common traits for fast Lexers")
> +    (description "This package provides macros for deriving common
> traits for
> +fast Lexers.")

What's the difference between a regular lexer and an uppercase Lexer?
Also, does this package only derive traits for lexers, or also the
lexers theirselves?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54085 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 54085 <at> debbugs.gnu.org
Subject: Re: [bug#54085] [PATCH 3/3] gnu: Add jless.
Date: Mon, 21 Feb 2022 14:25:33 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op ma 21-02-2022 om 09:48 [+0000]:
> +     `(#:skip-build? #t

Why skip the builld?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 54085 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 54085 <at> debbugs.gnu.org
Subject: Re: [bug#54085] [PATCH 3/3] gnu: Add jless.
Date: Mon, 21 Feb 2022 14:27:11 +0100

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op ma 21-02-2022 om 09:48 [+0000]:
> +    (description "This package provides macros for deriving common
> traits for
> +fast Lexers.")

The README has some information that could be added to make the
description more descriptive.  Also, why is the name rust-logos-derive
and not rust-logos?

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 54085 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: phodina <phodina <at> protonmail.com>
Cc: 54085 <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#54085: [PATCH 3/3] gnu: Add jless.
Date: Wed, 28 Sep 2022 15:29:25 -0400

Hi Petr,

Maxime Devos <maximedevos <at> telenet.be> writes:

> phodina via Guix-patches via schreef op ma 21-02-2022 om 09:48 [+0000]:
>> +    (description "This package provides macros for deriving common
>> traits for
>> +fast Lexers.")
>
> The README has some information that could be added to make the
> description more descriptive.  Also, why is the name rust-logos-derive
> and not rust-logos?

Could you please follow up to Maxime's comments? :-) With a simple v2 we
should be able to get this merged.

Thanks!

Maxim

Message #22 received at 54085 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 phodina <phodina <at> protonmail.com>
Cc: 54085 <at> debbugs.gnu.org
Subject: Re: bug#54085: [PATCH 3/3] gnu: Add jless.
Date: Wed, 28 Sep 2022 22:17:14 +0200

[Message part 1 (text/plain, inline)]

On 28-09-2022 21:29, Maxim Cournoyer wrote:
>> phodina via Guix-patches via schreef op ma 21-02-2022 om 09:48 [+0000]:
>>> +    (description "This package provides macros for deriving common
>>> traits for
>>> +fast Lexers.")
>> The README has some information that could be added to make the
>> description more descriptive.  Also, why is the name rust-logos-derive
>> and not rust-logos?

Nevermind the naming bit, that's just the convention in Rust on 
separating macros from other things.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #25 received at 54085 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54085 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#54085: [PATCH 3/3] gnu: Add jless.
Date: Mon, 21 Nov 2022 16:14:56 +0000

[Message part 1 (text/plain, inline)]

Hi Maxim and Maxime,

Here are the patches. Should have the issues you mentioned fixed.

----
Petr

[v2-0003-gnu-Add-jless.patch (text/x-patch, attachment)]

[v2-0002-gnu-Add-rust-logos-0.12.patch (text/x-patch, attachment)]

[v2-0001-gnu-Add-rust-logos-derive-0.12.patch (text/x-patch, attachment)]

Message #30 received at 54085-done <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 54085-done <at> debbugs.gnu.org
Subject: RE: Add jless to Guix
Date: Sun, 23 Mar 2025 00:52:05 +0000

Hi Petr,

Thanks for submitting jless to be adding to Guix. I updated the patch to a later version and committed it to the rust-team branch in b8692833d2f257e263efcc7552387f7887d2973a

Steve / Futurile

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.