GNU bug report logs - #54105
[PATCH] build-system/go: Use different default go on powerpc-linux.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54105 in the body.
You can then email your comments to 54105 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] build-system/go: Use different default go on powerpc-linux.
Date: Tue, 22 Feb 2022 13:08:29 +0200

* guix/build-system/go.scm (default-go): Return a different package
based on the target architecture.
---
 guix/build-system/go.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm
index 5e0e5bbad3..8330d3aa8e 100644
--- a/guix/build-system/go.scm
+++ b/guix/build-system/go.scm
@@ -3,7 +3,7 @@
 ;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;; Copyright © 2021-2022 Ludovic Courtès <ludo <at> gnu.org>
-;;; Copyright © 2021 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2021, 2022 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -110,8 +110,11 @@ (define %go-build-system-modules
 
 (define (default-go)
   ;; Lazily resolve the binding to avoid a circular dependency.
-  (let ((go (resolve-interface '(gnu packages golang))))
-    (module-ref go 'go)))
+  (let ((gcc    (resolve-interface '(gnu packages gcc)))
+        (golang (resolve-interface '(gnu packages golang))))
+    (if (target-ppc32?)
+      (module-ref gcc 'gccgo-11)
+      (module-ref golang 'go))))
 
 (define (make-go-std)
   (module-ref (resolve-interface '(gnu packages golang)) 'make-go-std))

base-commit: 7d72da6b07e99854751187d2694b067733fedda5
prerequisite-patch-id: 861786541b1231efceea28ba4d80d00c000a1b5e
prerequisite-patch-id: 7926cb990933a395cef6672939d171f8cd384170
-- 
2.34.0

Message #8 received at 54105 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 54105 <at> debbugs.gnu.org
Cc: Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] build-system/go: Use different default go on powerpc-linux.
Date: Thu, 12 Sep 2024 15:43:21 +0100

[Message part 1 (text/plain, inline)]

Hi Efraim,

Is this patch still actually to be applied?

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54105 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 54105 <at> debbugs.gnu.org
Subject: Re: [PATCH] build-system/go: Use different default go on
 powerpc-linux.
Date: Thu, 12 Sep 2024 18:36:26 +0300

[Message part 1 (text/plain, inline)]

On Thu, Sep 12, 2024 at 03:43:21PM +0100, Sharlatan Hellseher wrote:
> 
> Hi Efraim,
> 
> Is this patch still actually to be applied?

Let me get back to you about that. I thought I had a newer version of
that patch somewhere.  I'll have to double-check that x86_64 -> ppc32
and ppc32->x86_64 both use gccgo. I think I had to do something also
with go-std also, which isn't needed with gccgo.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 54105-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 54105-done <at> debbugs.gnu.org
Subject: Re: [PATCH] build-system/go: Use different default go on
 powerpc-linux.
Date: Fri, 27 Dec 2024 13:13:55 +0200

[Message part 1 (text/plain, inline)]

On Thu, Sep 12, 2024 at 03:43:21PM +0100, Sharlatan Hellseher wrote:
> 
> Hi Efraim,
> 
> Is this patch still actually to be applied?

I'm going to go with no. I have my powerpc machine back up and building,
but I haven't tested this patch out again.

It looks like instead of this patch I went with one that added a
default-gccgo, and then set 'go' in the build system depending on
"(if (supported-package? (default-go))".  I think it falls over quickly
for cross-building (and for packages which don't build with go-18),
but that is a different issue.

Thanks for following up on one of my (many) forgotten patches!


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.